mirror of
https://github.com/woodpecker-ci/woodpecker.git
synced 2025-10-23 04:24:05 +00:00
Enable gocritic
and don't ignore globally (#3159)
Use `nolint` directives instead. From #2960
This commit is contained in:
@@ -17,6 +17,7 @@ package main
|
||||
import (
|
||||
"crypto/tls"
|
||||
"errors"
|
||||
"fmt"
|
||||
"net"
|
||||
"net/http"
|
||||
"net/http/httputil"
|
||||
@@ -55,7 +56,9 @@ import (
|
||||
)
|
||||
|
||||
func run(c *cli.Context) error {
|
||||
logger.SetupGlobalLogger(c, true)
|
||||
if err := logger.SetupGlobalLogger(c, true); err != nil {
|
||||
return err
|
||||
}
|
||||
|
||||
// set gin mode based on log level
|
||||
if zerolog.GlobalLevel() > zerolog.DebugLevel {
|
||||
@@ -63,17 +66,15 @@ func run(c *cli.Context) error {
|
||||
}
|
||||
|
||||
if c.String("server-host") == "" {
|
||||
log.Fatal().Msg("WOODPECKER_HOST is not properly configured")
|
||||
return fmt.Errorf("WOODPECKER_HOST is not properly configured")
|
||||
}
|
||||
|
||||
if !strings.Contains(c.String("server-host"), "://") {
|
||||
log.Fatal().Msg(
|
||||
"WOODPECKER_HOST must be <scheme>://<hostname> format",
|
||||
)
|
||||
return fmt.Errorf("WOODPECKER_HOST must be <scheme>://<hostname> format")
|
||||
}
|
||||
|
||||
if _, err := url.Parse(c.String("server-host")); err != nil {
|
||||
log.Fatal().Err(err).Msg("could not parse WOODPECKER_HOST")
|
||||
return fmt.Errorf("could not parse WOODPECKER_HOST: %w", err)
|
||||
}
|
||||
|
||||
if strings.Contains(c.String("server-host"), "://localhost") {
|
||||
@@ -84,10 +85,13 @@ func run(c *cli.Context) error {
|
||||
|
||||
_forge, err := setupForge(c)
|
||||
if err != nil {
|
||||
log.Fatal().Err(err).Msg("can't setup forge")
|
||||
return fmt.Errorf("can't setup forge: %w", err)
|
||||
}
|
||||
|
||||
_store := setupStore(c)
|
||||
_store, err := setupStore(c)
|
||||
if err != nil {
|
||||
return fmt.Errorf("can't setup store: %w", err)
|
||||
}
|
||||
defer func() {
|
||||
if err := _store.Close(); err != nil {
|
||||
log.Error().Err(err).Msg("could not close store")
|
||||
@@ -96,7 +100,7 @@ func run(c *cli.Context) error {
|
||||
|
||||
err = setupEvilGlobals(c, _store, _forge)
|
||||
if err != nil {
|
||||
log.Fatal().Err(err).Msg("can't setup globals")
|
||||
return fmt.Errorf("can't setup globals: %w", err)
|
||||
}
|
||||
|
||||
var g errgroup.Group
|
||||
@@ -111,7 +115,7 @@ func run(c *cli.Context) error {
|
||||
g.Go(func() error {
|
||||
lis, err := net.Listen("tcp", c.String("grpc-addr"))
|
||||
if err != nil {
|
||||
log.Fatal().Err(err).Msg("failed to listen on grpc-addr")
|
||||
log.Fatal().Err(err).Msg("failed to listen on grpc-addr") //nolint:forbidigo
|
||||
}
|
||||
|
||||
jwtSecret := c.String("grpc-secret")
|
||||
@@ -144,7 +148,7 @@ func run(c *cli.Context) error {
|
||||
|
||||
err = grpcServer.Serve(lis)
|
||||
if err != nil {
|
||||
log.Fatal().Err(err).Msg("failed to serve grpc server")
|
||||
log.Fatal().Err(err).Msg("failed to serve grpc server") //nolint:forbidigo
|
||||
}
|
||||
return nil
|
||||
})
|
||||
@@ -155,7 +159,8 @@ func run(c *cli.Context) error {
|
||||
if proxyWebUI == "" {
|
||||
webEngine, err := web.New()
|
||||
if err != nil {
|
||||
log.Fatal().Err(err).Msg("failed to create web engine")
|
||||
log.Error().Err(err).Msg("failed to create web engine")
|
||||
return err
|
||||
}
|
||||
webUIServe = webEngine.ServeHTTP
|
||||
} else {
|
||||
@@ -180,7 +185,8 @@ func run(c *cli.Context) error {
|
||||
middleware.Store(c, _store),
|
||||
)
|
||||
|
||||
if c.String("server-cert") != "" {
|
||||
switch {
|
||||
case c.String("server-cert") != "":
|
||||
// start the server with tls enabled
|
||||
g.Go(func() error {
|
||||
serve := &http.Server{
|
||||
@@ -195,7 +201,7 @@ func run(c *cli.Context) error {
|
||||
c.String("server-key"),
|
||||
)
|
||||
if err != nil && !errors.Is(err, http.ErrServerClosed) {
|
||||
log.Fatal().Err(err).Msg("failed to start server with tls")
|
||||
log.Fatal().Err(err).Msg("failed to start server with tls") //nolint:forbidigo
|
||||
}
|
||||
return err
|
||||
})
|
||||
@@ -214,11 +220,11 @@ func run(c *cli.Context) error {
|
||||
g.Go(func() error {
|
||||
err := http.ListenAndServe(server.Config.Server.Port, http.HandlerFunc(redirect))
|
||||
if err != nil && !errors.Is(err, http.ErrServerClosed) {
|
||||
log.Fatal().Err(err).Msg("unable to start server to redirect from http to https")
|
||||
log.Fatal().Err(err).Msg("unable to start server to redirect from http to https") //nolint:forbidigo
|
||||
}
|
||||
return err
|
||||
})
|
||||
} else if c.Bool("lets-encrypt") {
|
||||
case c.Bool("lets-encrypt"):
|
||||
// start the server with lets-encrypt
|
||||
certmagic.DefaultACME.Email = c.String("lets-encrypt-email")
|
||||
certmagic.DefaultACME.Agreed = true
|
||||
@@ -230,11 +236,11 @@ func run(c *cli.Context) error {
|
||||
|
||||
g.Go(func() error {
|
||||
if err := certmagic.HTTPS([]string{address.Host}, handler); err != nil {
|
||||
log.Fatal().Err(err).Msg("certmagic does not work")
|
||||
log.Fatal().Err(err).Msg("certmagic does not work") //nolint:forbidigo
|
||||
}
|
||||
return nil
|
||||
})
|
||||
} else {
|
||||
default:
|
||||
// start the server without tls
|
||||
g.Go(func() error {
|
||||
err := http.ListenAndServe(
|
||||
@@ -242,7 +248,7 @@ func run(c *cli.Context) error {
|
||||
handler,
|
||||
)
|
||||
if err != nil && !errors.Is(err, http.ErrServerClosed) {
|
||||
log.Fatal().Err(err).Msg("could not start server")
|
||||
log.Fatal().Err(err).Msg("could not start server") //nolint:forbidigo
|
||||
}
|
||||
return err
|
||||
})
|
||||
@@ -254,7 +260,7 @@ func run(c *cli.Context) error {
|
||||
metricsRouter.GET("/metrics", gin.WrapH(promhttp.Handler()))
|
||||
err := http.ListenAndServe(metricsServerAddr, metricsRouter)
|
||||
if err != nil && !errors.Is(err, http.ErrServerClosed) {
|
||||
log.Fatal().Err(err).Msg("could not start metrics server")
|
||||
log.Fatal().Err(err).Msg("could not start metrics server") //nolint:forbidigo
|
||||
}
|
||||
return err
|
||||
})
|
||||
@@ -298,7 +304,10 @@ func setupEvilGlobals(c *cli.Context, v store.Store, f forge.Forge) error {
|
||||
}
|
||||
server.Config.Services.Membership = setupMembershipService(c, f)
|
||||
|
||||
server.Config.Services.SignaturePrivateKey, server.Config.Services.SignaturePublicKey = setupSignatureKeys(v)
|
||||
server.Config.Services.SignaturePrivateKey, server.Config.Services.SignaturePublicKey, err = setupSignatureKeys(v)
|
||||
if err != nil {
|
||||
return err
|
||||
}
|
||||
|
||||
server.Config.Services.ConfigService, err = setupConfigService(c)
|
||||
if err != nil {
|
||||
|
Reference in New Issue
Block a user