github/woodpecker
1
0
Fork 0
mirror of https://github.com/woodpecker-ci/woodpecker.git synced 2025-09-17 20:20:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

Never log tokens (#2466)

Browse Source
This commit is contained in:
qwerty287
2023-09-16 10:53:37 +02:00
committed by GitHub
parent a40bb4f890
commit 29e93bdf8b
2 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
agent/rpc/auth_interceptor.go
View File

@@ -107,7 +107,7 @@ func (interceptor *AuthInterceptor) refreshToken() error {
} }
interceptor.accessToken = accessToken interceptor.accessToken = accessToken
log.Trace().Str("token", accessToken).Msg("Token refreshed") log.Trace().Msg("token refreshed")
return nil return nil
} }

3
server/cron/cron.go
View File

@@ -126,13 +126,14 @@ func CreatePipeline(ctx context.Context, store store.Store, f forge.Forge, cron
// the pipeline. // the pipeline.
if refresher, ok := f.(forge.Refresher); ok { if refresher, ok := f.(forge.Refresher); ok {
refreshed, err := refresher.Refresh(ctx, creator) refreshed, err := refresher.Refresh(ctx, creator)
log.Debug().Msgf("token refreshed: %t", refreshed)
if err != nil { if err != nil {
log.Error().Err(err).Msgf("failed to refresh oauth2 token for creator: %s", creator.Login) log.Error().Err(err).Msgf("failed to refresh oauth2 token for creator: %s", creator.Login)
} else if refreshed { } else if refreshed {
if err := store.UpdateUser(creator); err != nil { if err := store.UpdateUser(creator); err != nil {
log.Error().Err(err).Msgf("error while updating creator: %s", creator.Login) log.Error().Err(err).Msgf("error while updating creator: %s", creator.Login)
// move forward // move forward
} else {
log.Debug().Msgf("token refreshed for creator: %s", creator.Login)
} }
} }
} }