From 36e528e3658a1c850e3587aff4f8fa032b5e2f40 Mon Sep 17 00:00:00 2001 From: Don Date: Thu, 17 Nov 2016 10:09:58 -0800 Subject: [PATCH] Modify return to follow Golang conventions --- agent/secret.go | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/agent/secret.go b/agent/secret.go index 4f6e4575f..531963bd2 100644 --- a/agent/secret.go +++ b/agent/secret.go @@ -22,17 +22,13 @@ func NewSecretReplacer(secrets []*model.Secret) SecretReplacer { } } - var replacer SecretReplacer - - if len(r) > 0 { - replacer = &secretReplacer{ - replacer: strings.NewReplacer(r...), - } - } else { - replacer = &noopReplacer{} + if len(r) == 0 { + return &noopReplacer{} } - return replacer + return &secretReplacer{ + replacer: strings.NewReplacer(r...), + } } type noopReplacer struct{}