Support ChangedFiles for Github & Gitlab PRs and Gitlab pushes (#697)

shared/utils/strings.go

@@ -0,0 +1,32 @@
+// Copyright 2022 Woodpecker Authors
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package utils
+
+// DedupStrings deduplicate string list, empty items are dropped
+func DedupStrings(list []string) []string {
+	m := make(map[string]struct{}, len(list))
+
+	for i := range list {
+		if s := list[i]; len(s) > 0 {
+			m[list[i]] = struct{}{}
+		}
+	}
+
+	newList := make([]string, 0, len(m))
+	for k := range m {
+		newList = append(newList, k)
+	}
+	return newList
+}

shared/utils/strings_test.go

@@ -0,0 +1,48 @@
+// Copyright 2022 Woodpecker Authors
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package utils
+
+import (
+	"sort"
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+)
+
+func TestDedupStrings(t *testing.T) {
+	tests := []struct {
+		in  []string
+		out []string
+	}{{
+		in:  []string{"", "ab", "12", "ab"},
+		out: []string{"12", "ab"},
+	}, {
+		in:  nil,
+		out: nil,
+	}, {
+		in:  []string{""},
+		out: nil,
+	}}
+
+	for _, tc := range tests {
+		result := DedupStrings(tc.in)
+		sort.Strings(result)
+		if len(tc.out) == 0 {
+			assert.Len(t, result, 0)
+		} else {
+			assert.EqualValues(t, tc.out, result, "could not correctly process input '%#v'", tc.in)
+		}
+	}
+}