github/woodpecker
1
0
Fork 0
mirror of https://github.com/woodpecker-ci/woodpecker.git synced 2025-10-22 11:54:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

Nits Collected over last month (#595)

Browse Source 
- add coverage.out
- add context queue
- fix misspell
- sanitize config: WOODPECKER_GITEA_URL
- storage backend migration should have no xorm session within migration function
This commit is contained in:
6543
2021-12-11 13:15:04 +01:00
committed by GitHub
parent 7ab33f62f7
commit 4cbdacb21c
7 changed files with 35 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
server/queue/fifo_test.go
View File

@@ -15,7 +15,7 @@ var noContext = context.Background()
func TestFifo(t *testing.T) {
want := &Task{ID: "1"}
q := New()
q := New(context.Background())
assert.NoError(t, q.Push(noContext, want))
info := q.Info(noContext)
if len(info.Pending) != 1 {
@@ -54,7 +54,7 @@ func TestFifo(t *testing.T) {
func TestFifoExpire(t *testing.T) {
want := &Task{ID: "1"}
q := New().(*fifo)
q := New(context.Background()).(*fifo)
q.extension = 0
assert.NoError(t, q.Push(noContext, want))
info := q.Info(noContext)
@@ -79,7 +79,7 @@ func TestFifoExpire(t *testing.T) {
func TestFifoWait(t *testing.T) {
want := &Task{ID: "1"}
q := New().(*fifo)
q := New(context.Background()).(*fifo)
assert.NoError(t, q.Push(noContext, want))
got, _ := q.Poll(noContext, func(*Task) bool { return true })
@@ -103,7 +103,7 @@ func TestFifoWait(t *testing.T) {
func TestFifoEvict(t *testing.T) {
t1 := &Task{ID: "1"}
q := New()
q := New(context.Background())
assert.NoError(t, q.Push(noContext, t1))
info := q.Info(noContext)
if len(info.Pending) != 1 {
@@ -132,7 +132,7 @@ func TestFifoDependencies(t *testing.T) {
DepStatus: make(map[string]string),
}
q := New().(*fifo)
q := New(context.Background()).(*fifo)
assert.NoError(t, q.PushAtOnce(noContext, []*Task{task2, task1}))
got, _ := q.Poll(noContext, func(*Task) bool { return true })
@@ -168,7 +168,7 @@ func TestFifoErrors(t *testing.T) {
RunOn: []string{"success", "failure"},
}
q := New().(*fifo)
q := New(context.Background()).(*fifo)
assert.NoError(t, q.PushAtOnce(noContext, []*Task{task2, task3, task1}))
got, _ := q.Poll(noContext, func(*Task) bool { return true })
@@ -217,7 +217,7 @@ func TestFifoErrors2(t *testing.T) {
DepStatus: make(map[string]string),
}
q := New().(*fifo)
q := New(context.Background()).(*fifo)
assert.NoError(t, q.PushAtOnce(noContext, []*Task{task2, task3, task1}))
for i := 0; i < 2; i++ {
@@ -264,7 +264,7 @@ func TestFifoErrorsMultiThread(t *testing.T) {
DepStatus: make(map[string]string),
}
q := New().(*fifo)
q := New(context.Background()).(*fifo)
assert.NoError(t, q.PushAtOnce(noContext, []*Task{task2, task3, task1}))
obtainedWorkCh := make(chan *Task)
@@ -354,7 +354,7 @@ func TestFifoTransitiveErrors(t *testing.T) {
DepStatus: make(map[string]string),
}
q := New().(*fifo)
q := New(context.Background()).(*fifo)
assert.NoError(t, q.PushAtOnce(noContext, []*Task{task2, task3, task1}))
got, _ := q.Poll(noContext, func(*Task) bool { return true })
@@ -404,7 +404,7 @@ func TestFifoCancel(t *testing.T) {
RunOn: []string{"success", "failure"},
}
q := New().(*fifo)
q := New(context.Background()).(*fifo)
assert.NoError(t, q.PushAtOnce(noContext, []*Task{task2, task3, task1}))
_, _ = q.Poll(noContext, func(*Task) bool { return true })
@@ -424,7 +424,7 @@ func TestFifoPause(t *testing.T) {
ID: "1",
}
q := New().(*fifo)
q := New(context.Background()).(*fifo)
var wg sync.WaitGroup
wg.Add(1)
go func() {
@@ -456,7 +456,7 @@ func TestFifoPauseResume(t *testing.T) {
ID: "1",
}
q := New().(*fifo)
q := New(context.Background()).(*fifo)
q.Pause()
assert.NoError(t, q.Push(noContext, task1))
q.Resume()
@@ -482,7 +482,7 @@ func TestWaitingVsPending(t *testing.T) {
RunOn: []string{"success", "failure"},
}
q := New().(*fifo)
q := New(context.Background()).(*fifo)
assert.NoError(t, q.PushAtOnce(noContext, []*Task{task2, task3, task1}))
got, _ := q.Poll(noContext, func(*Task) bool { return true })