github/woodpecker
1
0
Fork 0
mirror of https://github.com/woodpecker-ci/woodpecker.git synced 2025-10-20 20:50:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

remove "panic()" as much as posible from code (#682)

Browse Source
This commit is contained in:
6543
2022-01-09 23:27:30 +01:00
committed by GitHub
parent 6eecfa4b88
commit 5a120db69d
3 changed files with 12 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
shared/oauth2/oauth2.go
View File

@@ -213,13 +213,13 @@ func (t *Transport) transport() http.RoundTripper {
// AuthCodeURL returns a URL that the end-user should be redirected to,
// so that they may obtain an authorization code.
func (c *Config) AuthCodeURL(state string) string {
func (c *Config) AuthCodeURL(state string) (string, error) {
_url, err := url.Parse(c.AuthURL)
if err != nil {
panic("AuthURL malformed: " + err.Error())
return "", fmt.Errorf("AuthURL malformed: %v", err)
}
if err := _url.Query().Get("error"); err != "" {
panic("AuthURL contains error: " + err)
return "", fmt.Errorf("AuthURL contains error: %v", err)
}
q := url.Values{
"response_type": {"code"},
@@ -235,7 +235,7 @@ func (c *Config) AuthCodeURL(state string) string {
} else {
_url.RawQuery += "&" + q
}
return _url.String()
return _url.String(), nil
}
func condVal(v string) []string {