Add default option for allowing pull requests on repositories (#4873)

cmd/server/flags.go

@@ -141,6 +141,12 @@ var flags = append([]cli.Flag{
 		Name:    "authenticate-public-repos",
 		Usage:   "Always use authentication to clone repositories even if they are public. Needed if the SCM requires to always authenticate as used by many companies.",
 	},
+	&cli.BoolFlag{
+		Sources: cli.EnvVars("WOODPECKER_DEFAULT_ALLOW_PULL_REQUESTS"),
+		Name:    "default-allow-pull-requests",
+		Usage:   "The default value for allowing pull requests on a repo.",
+		Value:   true,
+	},
 	&cli.StringSliceFlag{
 		Sources: cli.EnvVars("WOODPECKER_DEFAULT_CANCEL_PREVIOUS_PIPELINE_EVENTS"),
 		Name:    "default-cancel-previous-pipeline-events",

cmd/server/setup.go

@@ -173,6 +173,9 @@ func setupEvilGlobals(ctx context.Context, c *cli.Command, s store.Store) (err e
 	// authentication
 	server.Config.Pipeline.AuthenticatePublicRepos = c.Bool("authenticate-public-repos")
 
+	// Pull requests
+	server.Config.Pipeline.DefaultAllowPullRequests = c.Bool("default-allow-pull-requests")
+
 	// Cloning
 	server.Config.Pipeline.DefaultClonePlugin = c.String("default-clone-plugin")
 	server.Config.Pipeline.TrustedClonePlugins = c.StringSlice("plugins-trusted-clone")

docs/docs/30-administration/10-server-config.md

@@ -337,6 +337,12 @@ Enable to allow user registration.
 
 Always use authentication to clone repositories even if they are public. Needed if the forge requires to always authenticate as used by many companies.
 
+### `WOODPECKER_DEFAULT_ALLOW_PULL_REQUESTS`
+
+> Default: `true`
+
+The default setting for allowing pull requests on a repo.
+
 ### `WOODPECKER_DEFAULT_CANCEL_PREVIOUS_PIPELINE_EVENTS`
 
 > Default: `pull_request, push`

server/api/repo.go

@@ -92,7 +92,7 @@ func PostRepo(c *gin.Context) {
 	} else {
 		repo = from
 		repo.RequireApproval = model.RequireApprovalForks
-		repo.AllowPull = true
+		repo.AllowPull = server.Config.Pipeline.DefaultAllowPullRequests
 		repo.AllowDeploy = false
 		repo.CancelPreviousPipelineEvents = server.Config.Pipeline.DefaultCancelPreviousPipelineEvents
 	}

server/config.go

@@ -66,6 +66,7 @@ var Config = struct {
 	}
 	Pipeline struct {
 		AuthenticatePublicRepos             bool
+		DefaultAllowPullRequests            bool
 		DefaultCancelPreviousPipelineEvents []model.WebhookEvent
 		DefaultWorkflowLabels               map[string]string
 		DefaultClonePlugin                  string