github/woodpecker
1
0
Fork 0
mirror of https://github.com/woodpecker-ci/woodpecker.git synced 2025-09-02 11:30:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove empty strings from slice before parsing agent config (#3387)

Browse Source 
Fixes: https://github.com/woodpecker-ci/woodpecker/issues/3385
This commit is contained in:
Robert Kaussow
2024-02-14 23:22:31 +01:00
committed by GitHub
parent 5e0ec973ba
commit 6abeff0165
3 changed files with 33 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
shared/utils/slices_test.go
View File

@@ -68,3 +68,24 @@ func TestSliceToBoolMap(t *testing.T) {
assert.Equal(t, map[string]bool{}, SliceToBoolMap([]string{}))
assert.Equal(t, map[string]bool{}, SliceToBoolMap([]string{""}))
}
func TestStringSliceDeleteEmpty(t *testing.T) {
tests := []struct {
in []string
out []string
}{{
in: []string{"", "ab", "ab"},
out: []string{"ab", "ab"},
}, {
in: []string{"", "ab", ""},
out: []string{"ab"},
}, {
in: []string{""},
out: []string{},
}}
for _, tc := range tests {
exp := StringSliceDeleteEmpty(tc.in)
assert.EqualValues(t, tc.out, exp, "got '%#v', expects %#v", exp, tc.out)
}
}