From 9c208c1ab070b9cbf13ae15d01e38fdbd09f7ac1 Mon Sep 17 00:00:00 2001 From: 6543 <6543@obermui.de> Date: Sun, 10 Oct 2021 13:59:48 +0200 Subject: [PATCH] Fix channel buffer used with signal.Notify (#421) (#423) Co-authored-by: Masaya Watanabe --- cmd/drone-agent/signal.go | 2 +- cncd/pipeline/pipeline/interrupt/interrupt.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/cmd/drone-agent/signal.go b/cmd/drone-agent/signal.go index f3362a9a4..41782d7d3 100644 --- a/cmd/drone-agent/signal.go +++ b/cmd/drone-agent/signal.go @@ -26,7 +26,7 @@ func WithContext(ctx context.Context) context.Context { func WithContextFunc(ctx context.Context, f func()) context.Context { ctx, cancel := context.WithCancel(ctx) go func() { - c := make(chan os.Signal) + c := make(chan os.Signal, 1) signal.Notify(c, syscall.SIGINT, syscall.SIGTERM) defer signal.Stop(c) diff --git a/cncd/pipeline/pipeline/interrupt/interrupt.go b/cncd/pipeline/pipeline/interrupt/interrupt.go index 0296d7548..adf79b6f1 100644 --- a/cncd/pipeline/pipeline/interrupt/interrupt.go +++ b/cncd/pipeline/pipeline/interrupt/interrupt.go @@ -20,7 +20,7 @@ func WithContext(ctx context.Context) context.Context { func WithContextFunc(ctx context.Context, f func()) context.Context { ctx, cancel := context.WithCancel(ctx) go func() { - c := make(chan os.Signal) + c := make(chan os.Signal, 1) signal.Notify(c, os.Interrupt) defer signal.Stop(c)