From c4b22cc4937a08efb48711c8956e3b367c689b06 Mon Sep 17 00:00:00 2001 From: 6543 <6543@obermui.de> Date: Wed, 26 Mar 2025 19:37:38 +0100 Subject: [PATCH] Use xorm quoter for feed query (#5018) --- server/store/datastore/feed.go | 2 +- server/store/datastore/helper.go | 12 ------------ 2 files changed, 1 insertion(+), 13 deletions(-) diff --git a/server/store/datastore/feed.go b/server/store/datastore/feed.go index 698507c5a..bca5d7910 100644 --- a/server/store/datastore/feed.go +++ b/server/store/datastore/feed.go @@ -41,7 +41,7 @@ pipelines.author as pipeline_author, pipelines.email as pipeline_email, pipelines.avatar as pipeline_avatar` - return fmt.Sprintf(feedTemplate, s.quoteIdentifier("commit")) + return fmt.Sprintf(feedTemplate, s.engine.Dialect().Quoter().Quote("commit")) } func (s storage) GetPipelineQueue() ([]*model.Feed, error) { diff --git a/server/store/datastore/helper.go b/server/store/datastore/helper.go index b3b2bfffc..4e3c4f48f 100644 --- a/server/store/datastore/helper.go +++ b/server/store/datastore/helper.go @@ -76,15 +76,3 @@ func callerName(skip int) string { } return fnName } - -func (s storage) quoteIdentifier(identifier string) string { - driver := s.engine.DriverName() - switch driver { - case DriverMysql: - return "`" + identifier + "`" - case DriverPostgres, DriverSqlite: - return "\"" + identifier + "\"" - default: - return identifier - } -}