github/woodpecker
1
0
Fork 0
mirror of https://github.com/woodpecker-ci/woodpecker.git synced 2025-08-21 11:13:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

Support namespace per org for Kubernetes step secrets (#5383)

Browse Source 
Co-authored-by: Robert Kaussow <mail@thegeeklab.de>
This commit is contained in:
Harri Avellan 2025-08-05 10:27:18 +03:00 committed by GitHub
parent 966c417286
commit e9ab04f88b
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
pipeline/backend/kubernetes/secrets.go
View File

@ -319,7 +319,7 @@ func startStepSecret(ctx context.Context, e *kube, step *types.Step) error {
return err return err
} }
log.Trace().Msgf("creating secret: %s", secret.Name) log.Trace().Msgf("creating secret: %s", secret.Name)
_, err = e.client.CoreV1().Secrets(e.config.Namespace).Create(ctx, secret, meta_v1.CreateOptions{}) _, err = e.client.CoreV1().Secrets(e.config.GetNamespace(step.OrgID)).Create(ctx, secret, meta_v1.CreateOptions{})
if err != nil { if err != nil {
return err return err
} }
@ -334,7 +334,7 @@ func mkStepSecret(step *types.Step, config *config) (*v1.Secret, error) {
return &v1.Secret{ return &v1.Secret{
ObjectMeta: meta_v1.ObjectMeta{ ObjectMeta: meta_v1.ObjectMeta{
Namespace: config.Namespace, Namespace: config.GetNamespace(step.OrgID),
Name: name, Name: name,
}, },
Type: v1.SecretTypeOpaque, Type: v1.SecretTypeOpaque,
@ -357,7 +357,7 @@ func stopStepSecret(ctx context.Context, engine *kube, step *types.Step, deleteO
} }
log.Trace().Str("name", name).Msg("deleting secret") log.Trace().Str("name", name).Msg("deleting secret")
err = engine.client.CoreV1().Secrets(engine.config.Namespace).Delete(ctx, name, deleteOpts) err = engine.client.CoreV1().Secrets(engine.config.GetNamespace(step.OrgID)).Delete(ctx, name, deleteOpts)
if errors.IsNotFound(err) { if errors.IsNotFound(err) {
return nil return nil
} }