github/woodpecker
1
0
Fork 0
mirror of https://github.com/woodpecker-ci/woodpecker.git synced 2025-10-21 08:27:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

Drop error only on purpose or else report back or log (#514)

Browse Source 
- Remove Deadcode
- Simplify Code
- Drop error only on purpose
This commit is contained in:
6543
2021-11-23 15:36:52 +01:00
committed by GitHub
parent f454371e56
commit fe31fb1e06
59 changed files with 464 additions and 347 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
agent/runner.go
View File

@@ -122,7 +122,9 @@ func (r *Runner) Run(ctx context.Context) error {
case <-time.After(time.Minute):
logger.Debug().Msg("pipeline lease renewed")
r.client.Extend(ctx, work.ID)
if err := r.client.Extend(ctx, work.ID); err != nil {
log.Error().Err(err).Msg("extending pipeline deadline failed")
}
}
}
}()
@@ -159,12 +161,14 @@ func (r *Runner) Run(ctx context.Context) error {
loglogger.Debug().Msg("log stream opened")
limitedPart := io.LimitReader(part, maxLogsUpload)
logstream := rpc.NewLineWriter(r.client, work.ID, proc.Alias, secrets...)
io.Copy(logstream, limitedPart)
logStream := rpc.NewLineWriter(r.client, work.ID, proc.Alias, secrets...)
if _, err := io.Copy(logStream, limitedPart); err != nil {
log.Error().Err(err).Msg("copy limited logStream part")
}
loglogger.Debug().Msg("log stream copied")
data, err := json.Marshal(logstream.Lines())
data, err := json.Marshal(logStream.Lines())
if err != nil {
loglogger.Err(err).Msg("could not marshal logstream")
}