From 1997bc344e70e35e5f8f9d6ee6fe28ba7db71785 Mon Sep 17 00:00:00 2001 From: llj Date: Wed, 29 May 2024 20:29:50 +0800 Subject: [PATCH] [library 'Folder Permission' dialog] fixup: enable users to 'choose' the root folder; removed those unused prop type checking which caused errors (#6130) --- .../dialog/lib-sub-folder-set-group-permission-dialog.js | 4 +--- .../dialog/lib-sub-folder-set-user-permission-dialog.js | 4 ++-- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/frontend/src/components/dialog/lib-sub-folder-set-group-permission-dialog.js b/frontend/src/components/dialog/lib-sub-folder-set-group-permission-dialog.js index e52f9b7483..6c4ac32b77 100644 --- a/frontend/src/components/dialog/lib-sub-folder-set-group-permission-dialog.js +++ b/frontend/src/components/dialog/lib-sub-folder-set-group-permission-dialog.js @@ -77,11 +77,8 @@ class GroupItem extends React.Component { GroupItem.propTypes = { item: PropTypes.object.isRequired, permissions: PropTypes.array.isRequired, - deleteUserFolderPermission: PropTypes.func.isRequired, - onChangeUserFolderPerm: PropTypes.func.isRequired, showPath: PropTypes.bool.isRequired, repoName: PropTypes.string.isRequired, - handleChange: PropTypes.func.isRequired, deleteGroupPermissionItem: PropTypes.func.isRequired, onChangeGroupPermission: PropTypes.func.isRequired, }; @@ -247,6 +244,7 @@ class LibSubFolderSetGroupPermissionDialog extends React.Component { handleSubmit = () => { this.setState({ + folderPath: this.state.folderPath || '/', showFileChooser: !this.state.showFileChooser }); }; diff --git a/frontend/src/components/dialog/lib-sub-folder-set-user-permission-dialog.js b/frontend/src/components/dialog/lib-sub-folder-set-user-permission-dialog.js index 5f7dfa1422..19c4d71fa0 100644 --- a/frontend/src/components/dialog/lib-sub-folder-set-user-permission-dialog.js +++ b/frontend/src/components/dialog/lib-sub-folder-set-user-permission-dialog.js @@ -82,14 +82,13 @@ UserItem.propTypes = { onChangeUserFolderPerm: PropTypes.func.isRequired, showPath: PropTypes.bool.isRequired, repoName: PropTypes.string.isRequired, - handleChange: PropTypes.func.isRequired, }; const propTypes = { repoID: PropTypes.string.isRequired, isDepartmentRepo: PropTypes.bool, - folderPath: PropTypes.string.isRequired, + folderPath: PropTypes.string, repoName: PropTypes.string, }; @@ -226,6 +225,7 @@ class LibSubFolderSetUserPermissionDialog extends React.Component { handleFileChooserSubmit = () => { this.setState({ + folderPath: this.state.folderPath || '/', showFileChooser: !this.state.showFileChooser }); };