diff --git a/frontend/package-lock.json b/frontend/package-lock.json index c5a28f84ff..dfb109233d 100644 --- a/frontend/package-lock.json +++ b/frontend/package-lock.json @@ -10793,9 +10793,9 @@ } }, "seafile-js": { - "version": "0.2.55", - "resolved": "https://registry.npmjs.org/seafile-js/-/seafile-js-0.2.55.tgz", - "integrity": "sha512-Q9qE/RE0rg3wmXlYENO8mcEhu+OHC3emK9/+Fq3k3u38z6iy/Kc/1ntJjNpHYI5VS4oipum/Lc8gIvPL/FZQAQ==", + "version": "0.2.56", + "resolved": "https://registry.npmjs.org/seafile-js/-/seafile-js-0.2.56.tgz", + "integrity": "sha512-Stm5Xa3OmXZ8beNVftS2OPU5nZlGGSIL7JazD2R4KrOtxQElfUWA5XsGsFnfbuAFv25mUxABzteWpYsMPVtOqg==", "requires": { "axios": "^0.18.0", "form-data": "^2.3.2", diff --git a/frontend/package.json b/frontend/package.json index e38f32edae..7728024cf3 100644 --- a/frontend/package.json +++ b/frontend/package.json @@ -31,7 +31,7 @@ "react-moment": "^0.7.9", "react-select": "^2.1.1", "reactstrap": "^6.4.0", - "seafile-js": "^0.2.55", + "seafile-js": "^0.2.56", "seafile-ui": "^0.1.10", "socket.io-client": "^2.2.0", "sw-precache-webpack-plugin": "0.11.4", diff --git a/frontend/src/components/dialog/share-to-group.js b/frontend/src/components/dialog/share-to-group.js index 5de11e41be..25a55a6375 100644 --- a/frontend/src/components/dialog/share-to-group.js +++ b/frontend/src/components/dialog/share-to-group.js @@ -5,7 +5,7 @@ import Select from 'react-select'; import makeAnimated from 'react-select/lib/animated'; import { gettext } from '../../utils/constants'; import { seafileAPI } from '../../utils/seafile-api.js'; -import PermissionEditor from '../select-editor/permission-editor'; +import SharePermissionEditor from '../select-editor/share-permission-editor'; class GroupItem extends React.Component { @@ -40,7 +40,7 @@ class GroupItem extends React.Component {
{gettext('Name')} | +{gettext('Name')} | {gettext('Owner')} | {gettext('Last Update')} | +{gettext('Permission')} | {/* operation */} | {item.folder_name} | {shareTo}
- |
{shareTo}
-
diff --git a/seahub/api2/endpoints/wiki_pages.py b/seahub/api2/endpoints/wiki_pages.py
index 9eb727bbed..cc95468bf5 100644
--- a/seahub/api2/endpoints/wiki_pages.py
+++ b/seahub/api2/endpoints/wiki_pages.py
@@ -225,7 +225,7 @@ class WikiPagesDirView(APIView):
return api_error(status.HTTP_404_NOT_FOUND, error_msg)
# perm check
- if not wiki.check_access_wiki(request):
+ if not wiki.has_read_perm(request.user):
error_msg = "Permission denied"
return api_error(status.HTTP_403_FORBIDDEN, error_msg)
@@ -266,7 +266,7 @@ class WikiPageContentView(APIView):
return api_error(status.HTTP_404_NOT_FOUND, error_msg)
# perm check
- if not wiki.check_access_wiki(request):
+ if not wiki.has_read_perm(request.user):
error_msg = 'Permission denied.'
return api_error(status.HTTP_403_FORBIDDEN, error_msg)
diff --git a/seahub/wiki/views.py b/seahub/wiki/views.py
index 2ae81f0792..183b08bc39 100644
--- a/seahub/wiki/views.py
+++ b/seahub/wiki/views.py
@@ -54,11 +54,11 @@ def slug(request, slug, file_path="home.md"):
# perm check
req_user = request.user.username
- if not req_user:
+ if not req_user and not wiki.has_read_perm(request.user):
return redirect('auth_login')
-
- if not wiki.check_access_wiki(request):
- return render_permission_error(request, _(u'Permission denied.'))
+ else:
+ if not wiki.has_read_perm(request.user):
+ return render_permission_error(request, _(u'Unable to view Wiki'))
file_type, ext = get_file_type_and_ext(posixpath.basename(file_path))
if file_type == IMAGE:
|
---|