haiwen/seahub
1
0
Fork 0
mirror of https://github.com/haiwen/seahub.git synced 2025-09-02 07:27:04 +00:00
Code Issues Releases Wiki Activity

[api] update share dir item api

Browse Source 
1. update perm check when share repo/dir
2. check if user registered when share repo/dir
This commit is contained in:
lian
2015-12-09 15:10:40 +08:00
parent 12448d95d4
commit 2450f1f3b0
2 changed files with 87 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

57
tests/api/endpoints/test_dir_shared_items.py
View File

@@ -2,6 +2,8 @@ import json
from seaserv import seafile_api
from tests.common.utils import randstring
from seahub.test_utils import BaseTestCase
class DirSharedItemsTest(BaseTestCase):
@@ -60,24 +62,43 @@ class DirSharedItemsTest(BaseTestCase):
resp = self.client.put(
'/api2/repos/%s/dir/shared_items/?p=%s' % (self.repo.id,
self.folder),
"share_type=user&username=a@a.com&username=b@b.com",
"share_type=user&username=%s" % self.admin.email,
'application/x-www-form-urlencoded',
)
self.assertEqual(200, resp.status_code)
json_resp = json.loads(resp.content)
assert len(json_resp['success']) == 2
assert len(json_resp['success']) == 1
assert json_resp['success'][0]['permission'] == 'r'
def test_share_folder_to_invalid_email(self):
self.login_as(self.user)
invalid_email = '%s' % randstring(6)
resp = self.client.put(
'/api2/repos/%s/dir/shared_items/?p=%s' % (self.repo.id,
self.folder),
"share_type=user&username=abc",
"share_type=user&username=%s" % invalid_email,
'application/x-www-form-urlencoded',
)
self.assertEqual(400, resp.status_code)
self.assertEqual(200, resp.status_code)
json_resp = json.loads(resp.content)
assert len(json_resp['failed']) == 1
assert invalid_email in json_resp['failed']
def test_share_folder_to_unregistered_user(self):
self.login_as(self.user)
unregistered_user = '%s@%s.com' % (randstring(6), randstring(6))
resp = self.client.put(
'/api2/repos/%s/dir/shared_items/?p=%s' % (self.repo.id,
self.folder),
"share_type=user&username=%s" % unregistered_user,
'application/x-www-form-urlencoded',
)
self.assertEqual(200, resp.status_code)
json_resp = json.loads(resp.content)
assert len(json_resp['failed']) == 1
assert unregistered_user in json_resp['failed']
def test_can_share_root_to_groups(self):
self.login_as(self.user)
@@ -134,6 +155,21 @@ class DirSharedItemsTest(BaseTestCase):
json_resp = json.loads(resp.content)
assert json_resp[0]['permission'] == 'r'
def test_modify_shared_repo_with_unregistered_user(self):
self._add_shared_items()
self.login_as(self.user)
unregistered_user = '%s@%s.com' % (randstring(6), randstring(6))
resp = self.client.post('/api2/repos/%s/dir/shared_items/?p=%s&share_type=user&username=%s' % (
self.repo.id,
self.folder,
unregistered_user), {
'permission': 'r'
}
)
self.assertEqual(400, resp.status_code)
def test_can_modify_group_shared_repo(self):
self._add_shared_items()
self.login_as(self.user)
@@ -174,6 +210,19 @@ class DirSharedItemsTest(BaseTestCase):
json_resp = json.loads(resp.content)
assert len(json_resp) == 0
def test_unshare_repo_with_unregistered_user(self):
self._add_shared_items()
self.login_as(self.user)
unregistered_user = '%s@%s.com' % (randstring(6), randstring(6))
resp = self.client.delete('/api2/repos/%s/dir/shared_items/?p=%s&share_type=user&username=%s' % (
self.repo.id,
self.folder,
unregistered_user
))
self.assertEqual(400, resp.status_code)
def test_can_unshare_repo_to_group(self):
self._add_shared_items()
self.login_as(self.user)