haiwen/seahub
1
0
Fork 0
mirror of https://github.com/haiwen/seahub.git synced 2025-09-12 13:24:52 +00:00
Code Issues Releases Wiki Activity

optimized code

Browse Source
This commit is contained in:
shanshuirenjia
2019-04-22 12:18:35 +08:00
parent ddb7ec369e
commit 2f0ea56aa8
6 changed files with 45 additions and 46 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
frontend/src/components/dirent-list-view/dirent-list-item.js
View File

@@ -24,8 +24,8 @@ const propTypes = {
showShareBtn: PropTypes.bool.isRequired, showShareBtn: PropTypes.bool.isRequired,
dirent: PropTypes.object.isRequired, dirent: PropTypes.object.isRequired,
onItemClick: PropTypes.func.isRequired, onItemClick: PropTypes.func.isRequired,
onFreezedItem: PropTypes.func.isRequired, freezeItem: PropTypes.func.isRequired,
onUnfreezedItem: PropTypes.func.isRequired, unfreezeItem: PropTypes.func.isRequired,
onItemRenameToggle: PropTypes.func.isRequired, onItemRenameToggle: PropTypes.func.isRequired,
onItemSelected: PropTypes.func.isRequired, onItemSelected: PropTypes.func.isRequired,
onItemDelete: PropTypes.func.isRequired, onItemDelete: PropTypes.func.isRequired,
@@ -110,12 +110,12 @@ class DirentListItem extends React.Component {
this.setState({isDragTipShow: false}); this.setState({isDragTipShow: false});
} }
onUnfreezedItem = () => { unfreezeItem = () => {
this.setState({ this.setState({
highlight: false, highlight: false,
isOperationShow: false, isOperationShow: false,
}); });
this.props.onUnfreezedItem(); this.props.unfreezeItem();
} }
//buiness handler //buiness handler
@@ -248,7 +248,7 @@ class DirentListItem extends React.Component {
onRenameCancel = () => { onRenameCancel = () => {
this.setState({isRenameing: false}); this.setState({isRenameing: false});
this.onUnfreezedItem(); this.unfreezeItem();
} }
onItemMoveToggle = () => { onItemMoveToggle = () => {
@@ -433,10 +433,10 @@ class DirentListItem extends React.Component {
opItem={this.props.dirent} opItem={this.props.dirent}
menuClass={'sf2-icon-caret-down'} menuClass={'sf2-icon-caret-down'}
isHandleContextMenuEvent={true} isHandleContextMenuEvent={true}
getOpItemMenuList={this.props.getDirentItemMenuList} getMenuList={this.props.getDirentItemMenuList}
onMenuItemClick={this.onMenuItemClick} onMenuItemClick={this.onMenuItemClick}
onUnfreezedItem={this.onUnfreezedItem} unfreezeItem={this.unfreezeItem}
onFreezedItem={this.props.onFreezedItem} freezeItem={this.props.freezeItem}
/> />
</li> </li>
</ul> </ul>
@@ -461,13 +461,12 @@ class DirentListItem extends React.Component {
<li className="operation-group-item"> <li className="operation-group-item">
<ItemDropDownMenu <ItemDropDownMenu
opItem={this.props.dirent} opItem={this.props.dirent}
menuType={'pc'}
menuClass={'sf2-icon-caret-down'} menuClass={'sf2-icon-caret-down'}
isHandleContextMenuEvent={true} isHandleContextMenuEvent={true}
getOpItemMenuList={this.props.getDirentItemMenuList} getMenuList={this.props.getDirentItemMenuList}
onMenuItemClick={this.onMenuItemClick} onMenuItemClick={this.onMenuItemClick}
onUnfreezedItem={this.onUnfreezedItem} unfreezeItem={this.unfreezeItem}
onFreezedItem={this.props.onFreezedItem} freezeItem={this.props.freezeItem}
/> />
</li> </li>
</ul> </ul>

14
frontend/src/components/dirent-list-view/dirent-list-view.js
View File

@@ -78,11 +78,11 @@ class DirentListView extends React.Component {
this.zipToken = null; this.zipToken = null;
} }
onFreezedItem = () => { freezeItem = () => {
this.setState({isItemFreezed: true}); this.setState({isItemFreezed: true});
} }
onUnfreezedItem = () => { unfreezeItem = () => {
this.setState({isItemFreezed: false}); this.setState({isItemFreezed: false});
} }
@@ -100,7 +100,7 @@ class DirentListView extends React.Component {
} }
onItemRenameToggle = () => { onItemRenameToggle = () => {
this.onFreezedItem(); this.freezeItem();
} }
onItemSelected = (dirent) => { onItemSelected = (dirent) => {
@@ -425,11 +425,11 @@ class DirentListView extends React.Component {
} }
onShowMenu = (e) => { onShowMenu = (e) => {
this.onFreezedItem(); this.freezeItem();
} }
onHideMenu = (e) => { onHideMenu = (e) => {
this.onUnfreezedItem(); this.unfreezeItem();
} }
// contextmenu utils // contextmenu utils
@@ -575,8 +575,8 @@ class DirentListView extends React.Component {
onItemCopy={this.props.onItemCopy} onItemCopy={this.props.onItemCopy}
updateDirent={this.props.updateDirent} updateDirent={this.props.updateDirent}
isItemFreezed={this.state.isItemFreezed} isItemFreezed={this.state.isItemFreezed}
onFreezedItem={this.onFreezedItem} freezeItem={this.freezeItem}
onUnfreezedItem={this.onUnfreezedItem} unfreezeItem={this.unfreezeItem}
onDirentClick={this.onDirentClick} onDirentClick={this.onDirentClick}
showImagePopup={this.showImagePopup} showImagePopup={this.showImagePopup}
onItemMouseDown={this.onItemMouseDown} onItemMouseDown={this.onItemMouseDown}

22
frontend/src/components/dropdown-menu/item-dropdown-menu.js
View File

@@ -9,10 +9,10 @@ const propTypes = {
opItem: PropTypes.object.isRequired, opItem: PropTypes.object.isRequired,
menuClass: PropTypes.string, menuClass: PropTypes.string,
isHandleContextMenuEvent: PropTypes.bool, isHandleContextMenuEvent: PropTypes.bool,
getOpItemMenuList: PropTypes.func.isRequired, getMenuList: PropTypes.func.isRequired,
onMenuItemClick: PropTypes.func.isRequired, onMenuItemClick: PropTypes.func.isRequired,
onFrezeedItem: PropTypes.func, freezeItem: PropTypes.func,
onUnfrezeedItem: PropTypes.func, unfreezeItem: PropTypes.func,
}; };
class ItemDropDownMenu extends React.Component { class ItemDropDownMenu extends React.Component {
@@ -35,14 +35,14 @@ class ItemDropDownMenu extends React.Component {
this.listenerId = listener.register(this.onShowMenu, this.onHideMenu); this.listenerId = listener.register(this.onShowMenu, this.onHideMenu);
} }
let { opItem } = this.props; let { opItem } = this.props;
let menuList = this.props.getOpItemMenuList(opItem); let menuList = this.props.getMenuList(opItem);
this.setState({menuList: menuList}); this.setState({menuList: menuList});
} }
componentWillReceiveProps(nextProps) { // for toolbar opItem operation componentWillReceiveProps(nextProps) { // for toolbar opItem operation
let { opItem } = nextProps; let { opItem } = nextProps;
if (opItem.name !== this.props.opItem.name) { if (opItem.name !== this.props.opItem.name) {
let menuList = this.props.getOpItemMenuList(opItem); let menuList = this.props.getMenuList(opItem);
this.setState({menuList: menuList}); this.setState({menuList: menuList});
} }
} }
@@ -60,8 +60,8 @@ class ItemDropDownMenu extends React.Component {
onHideMenu = () => { onHideMenu = () => {
if (this.state.isItemMenuShow) { if (this.state.isItemMenuShow) {
this.setState({isItemMenuShow: false}); this.setState({isItemMenuShow: false});
if (typeof(this.props.onUnfreezedItem) === 'function') { if (typeof(this.props.unfreezeItem) === 'function') {
this.props.onUnfreezedItem(); this.props.unfreezeItem();
} }
} }
} }
@@ -77,10 +77,10 @@ class ItemDropDownMenu extends React.Component {
this.setState( this.setState(
{isItemMenuShow: !this.state.isItemMenuShow}, {isItemMenuShow: !this.state.isItemMenuShow},
() => { () => {
if (this.state.isItemMenuShow && typeof(this.props.onFreezedItem) === 'function') { if (this.state.isItemMenuShow && typeof(this.props.freezeItem) === 'function') {
this.props.onFreezedItem(); this.props.freezeItem();
} else if (!this.state.isItemMenuShow && typeof(this.props.onUnfreezedItem) === 'function') { } else if (!this.state.isItemMenuShow && typeof(this.props.unfreezeItem) === 'function') {
this.props.onUnfreezedItem(); this.props.unfreezeItem();
} }
} }
); );

2
frontend/src/components/toolbar/mutilple-dir-operation-toolbar.js
View File

@@ -287,7 +287,7 @@ class MutipleDirOperationToolbar extends React.Component {
opItem={this.props.selectedDirentList[0]} opItem={this.props.selectedDirentList[0]}
menuClass={'fas fa-ellipsis-v dirents-more-menu'} menuClass={'fas fa-ellipsis-v dirents-more-menu'}
onMenuItemClick={this.onMenuItemClick} onMenuItemClick={this.onMenuItemClick}
getOpItemMenuList={this.getDirentMenuList} getMenuList={this.getDirentMenuList}
/> />
} }
</ButtonGroup> </ButtonGroup>

18
frontend/src/components/tree-view/tree-node-view.js
View File

@@ -15,8 +15,8 @@ const propTypes = {
onNodeExpanded: PropTypes.func.isRequired, onNodeExpanded: PropTypes.func.isRequired,
onNodeCollapse: PropTypes.func.isRequired, onNodeCollapse: PropTypes.func.isRequired,
onNodeDragStart: PropTypes.func.isRequired, onNodeDragStart: PropTypes.func.isRequired,
onFreezedItem: PropTypes.func.isRequired, freezeItem: PropTypes.func.isRequired,
onUnfreezedItem: PropTypes.func.isRequired, unfreezeItem: PropTypes.func.isRequired,
onMenuItemClick: PropTypes.func, onMenuItemClick: PropTypes.func,
registerHandlers: PropTypes.func, registerHandlers: PropTypes.func,
unregisterHandlers: PropTypes.func, unregisterHandlers: PropTypes.func,
@@ -113,9 +113,9 @@ class TreeNodeView extends React.Component {
this.props.onNodeDrop(e, this.props.node); this.props.onNodeDrop(e, this.props.node);
} }
onUnfreezedItem = () => { unfreezeItem = () => {
this.setState({isShowOperationMenu: false}); this.setState({isShowOperationMenu: false});
this.props.onUnfreezedItem(); this.props.unfreezeItem();
} }
onMenuItemClick = (operation, event, node) => { onMenuItemClick = (operation, event, node) => {
@@ -199,9 +199,9 @@ class TreeNodeView extends React.Component {
onNodeClick={this.props.onNodeClick} onNodeClick={this.props.onNodeClick}
onNodeCollapse={this.props.onNodeCollapse} onNodeCollapse={this.props.onNodeCollapse}
onNodeExpanded={this.props.onNodeExpanded} onNodeExpanded={this.props.onNodeExpanded}
onFreezedItem={this.props.onFreezedItem} freezeItem={this.props.freezeItem}
onMenuItemClick={this.props.onMenuItemClick} onMenuItemClick={this.props.onMenuItemClick}
onUnfreezedItem={this.onUnfreezedItem} unfreezeItem={this.unfreezeItem}
onNodeChanged={this.props.onNodeChanged} onNodeChanged={this.props.onNodeChanged}
registerHandlers={this.props.registerHandlers} registerHandlers={this.props.registerHandlers}
unregisterHandlers={this.props.unregisterHandlers} unregisterHandlers={this.props.unregisterHandlers}
@@ -256,10 +256,10 @@ class TreeNodeView extends React.Component {
<ItemDropDownMenu <ItemDropDownMenu
opItem={this.props.node} opItem={this.props.node}
menuClass={'fas fa-ellipsis-v'} menuClass={'fas fa-ellipsis-v'}
getOpItemMenuList={this.caculateMenuList} getMenuList={this.caculateMenuList}
onMenuItemClick={this.onMenuItemClick} onMenuItemClick={this.onMenuItemClick}
onFreezedItem={this.props.onFreezedItem} freezeItem={this.props.freezeItem}
onUnfreezedItem={this.onUnfreezedItem} unfreezeItem={this.unfreezeItem}
/> />
)} )}
</div> </div>

12
frontend/src/components/tree-view/tree-view.js
View File

@@ -112,11 +112,11 @@ class TreeView extends React.Component {
this.onItemMove(this.props.currentRepoInfo, nodeDirent, dropNodeData.path, nodeParentPath); this.onItemMove(this.props.currentRepoInfo, nodeDirent, dropNodeData.path, nodeParentPath);
} }
onFreezedItem = () => { freezeItem = () => {
this.setState({isItemFreezed: true}); this.setState({isItemFreezed: true});
} }
onUnfreezedItem = () => { unfreezeItem = () => {
this.setState({isItemFreezed: false}); this.setState({isItemFreezed: false});
} }
@@ -194,11 +194,11 @@ class TreeView extends React.Component {
} }
onShowMenu = () => { onShowMenu = () => {
this.onFreezedItem(); this.freezeItem();
} }
onHideMenu = () => { onHideMenu = () => {
this.onUnfreezedItem(); this.unfreezeItem();
} }
render() { render() {
@@ -223,8 +223,8 @@ class TreeView extends React.Component {
onNodeExpanded={this.props.onNodeExpanded} onNodeExpanded={this.props.onNodeExpanded}
onNodeCollapse={this.props.onNodeCollapse} onNodeCollapse={this.props.onNodeCollapse}
onNodeDragStart={this.onNodeDragStart} onNodeDragStart={this.onNodeDragStart}
onFreezedItem={this.onFreezedItem} freezeItem={this.freezeItem}
onUnfreezedItem={this.onUnfreezedItem} unfreezeItem={this.unfreezeItem}
onNodeDragMove={this.onNodeDragMove} onNodeDragMove={this.onNodeDragMove}
onNodeDrop={this.onNodeDrop} onNodeDrop={this.onNodeDrop}
onNodeDragEnter={this.onNodeDragEnter} onNodeDragEnter={this.onNodeDragEnter}