haiwen/seahub
1
0
Fork 0
mirror of https://github.com/haiwen/seahub.git synced 2025-08-11 11:52:08 +00:00
Code Issues Releases Wiki Activity

optimized function naming (#2824)

Browse Source
This commit is contained in:
杨顺强 2019-01-14 13:33:36 +08:00 committed by Daniel Pan
parent 2cdba5012a
commit 3d2e21eecd
10 changed files with 18 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
frontend/src/components/dialog/manage-members-dialog.js
View File

@ -182,7 +182,7 @@ class Member extends React.PureComponent {
isEditIconShow={true} isEditIconShow={true}
currentRole={this.props.item.role} currentRole={this.props.item.role}
roles={this.roles} roles={this.roles}
onRoleChangedHandler={this.onChangeUserRole} onRoleChanged={this.onChangeUserRole}
/> />
} }
</td> </td>

4
frontend/src/components/dialog/share-to-group.js
View File

@ -45,7 +45,7 @@ class GroupItem extends React.Component {
isEditIconShow={this.state.isOperationShow} isEditIconShow={this.state.isOperationShow}
currentPermission={item.permission} currentPermission={item.permission}
permissions={this.props.permissions} permissions={this.props.permissions}
onPermissionChangedHandler={this.onChangeUserPermission} onPermissionChanged={this.onChangeUserPermission}
/> />
</td> </td>
<td> <td>
@ -275,7 +275,7 @@ class ShareToGroup extends React.Component {
isEditIconShow={false} isEditIconShow={false}
currentPermission={this.state.permission} currentPermission={this.state.permission}
permissions={this.permissions} permissions={this.permissions}
onPermissionChangedHandler={this.setPermission} onPermissionChanged={this.setPermission}
/> />
</td> </td>
<td> <td>

4
frontend/src/components/dialog/share-to-user.js
View File

@ -45,7 +45,7 @@ class UserItem extends React.Component {
isEditIconShow={this.state.isOperationShow} isEditIconShow={this.state.isOperationShow}
currentPermission={currentPermission} currentPermission={currentPermission}
permissions={this.props.permissions} permissions={this.props.permissions}
onPermissionChangedHandler={this.onChangeUserPermission} onPermissionChanged={this.onChangeUserPermission}
/> />
</td> </td>
<td> <td>
@ -297,7 +297,7 @@ class ShareToUser extends React.Component {
isEditIconShow={false} isEditIconShow={false}
currentPermission={this.state.permission} currentPermission={this.state.permission}
permissions={this.permissions} permissions={this.permissions}
onPermissionChangedHandler={this.setPermission} onPermissionChanged={this.setPermission}
/> />
</td> </td>
<td> <td>

4
frontend/src/components/select-editor/role-eidtor.js
View File

@ -8,7 +8,7 @@ const propTypes = {
isEditIconShow: PropTypes.bool.isRequired, isEditIconShow: PropTypes.bool.isRequired,
roles: PropTypes.array.isRequired, roles: PropTypes.array.isRequired,
currentRole: PropTypes.string.isRequired, currentRole: PropTypes.string.isRequired,
onRoleChangedHandler: PropTypes.func.isRequired, onRoleChanged: PropTypes.func.isRequired,
}; };
class RoleEditor extends React.Component { class RoleEditor extends React.Component {
@ -30,7 +30,7 @@ class RoleEditor extends React.Component {
isEditIconShow={this.props.isEditIconShow} isEditIconShow={this.props.isEditIconShow}
options={this.props.roles} options={this.props.roles}
currentOption={this.props.currentRole} currentOption={this.props.currentRole}
onOptionChangedHandler={this.props.onRoleChangedHandler} onOptionChanged={this.props.onRoleChanged}
translateOption={this.translateRole} translateOption={this.translateRole}
/> />
); );

8
frontend/src/components/select-editor/select-editor.js
View File

@ -9,7 +9,7 @@ const propTypes = {
options: PropTypes.array.isRequired, options: PropTypes.array.isRequired,
currentOption: PropTypes.string.isRequired, currentOption: PropTypes.string.isRequired,
translateOption: PropTypes.func.isRequired, translateOption: PropTypes.func.isRequired,
onOptionChangedHandler: PropTypes.func.isRequired, onOptionChanged: PropTypes.func.isRequired,
}; };
class SelectEditor extends React.Component { class SelectEditor extends React.Component {
@ -34,11 +34,11 @@ class SelectEditor extends React.Component {
this.setState({isEditing: true}); this.setState({isEditing: true});
} }
onOptionChangedHandler = (e) => { onOptionChanged = (e) => {
e.nativeEvent.stopImmediatePropagation(); e.nativeEvent.stopImmediatePropagation();
let permission = e.target.value; let permission = e.target.value;
if (permission !== this.props.currentOption) { if (permission !== this.props.currentOption) {
this.props.onOptionChangedHandler(permission); this.props.onOptionChanged(permission);
} }
this.setState({isEditing: false}); this.setState({isEditing: false});
} }
@ -66,7 +66,7 @@ class SelectEditor extends React.Component {
return ( return (
<div className="permission-editor"> <div className="permission-editor">
{(!isTextMode || this.state.isEditing) && {(!isTextMode || this.state.isEditing) &&
<Input style={selectStyle} type="select" onChange={this.onOptionChangedHandler} onClick={this.onSelectHandler} value={currentOption}> <Input style={selectStyle} type="select" onChange={this.onOptionChanged} onClick={this.onSelectHandler} value={currentOption}>
{options.map((item, index) => { {options.map((item, index) => {
return ( return (
<option key={index} value={item}>{this.props.translateOption(item)}</option> <option key={index} value={item}>{this.props.translateOption(item)}</option>

4
frontend/src/components/select-editor/share-permission-editor.js
View File

@ -8,7 +8,7 @@ const propTypes = {
isEditIconShow: PropTypes.bool.isRequired, isEditIconShow: PropTypes.bool.isRequired,
permissions: PropTypes.array.isRequired, permissions: PropTypes.array.isRequired,
currentPermission: PropTypes.string.isRequired, currentPermission: PropTypes.string.isRequired,
onPermissionChangedHandler: PropTypes.func.isRequired onPermissionChanged: PropTypes.func.isRequired
}; };
class SharePermissionEditor extends React.Component { class SharePermissionEditor extends React.Component {
@ -24,7 +24,7 @@ class SharePermissionEditor extends React.Component {
isEditIconShow={this.props.isEditIconShow} isEditIconShow={this.props.isEditIconShow}
options={this.props.permissions} options={this.props.permissions}
currentOption={this.props.currentPermission} currentOption={this.props.currentPermission}
onOptionChangedHandler={this.props.onPermissionChangedHandler} onOptionChanged={this.props.onPermissionChanged}
translateOption={this.translatePermission} translateOption={this.translatePermission}
/> />
); );

4
frontend/src/components/select-editor/wiki-permission-editor.js
View File

@ -8,7 +8,7 @@ const propTypes = {
isEditIconShow: PropTypes.bool.isRequired, isEditIconShow: PropTypes.bool.isRequired,
permissions: PropTypes.array.isRequired, permissions: PropTypes.array.isRequired,
currentPermission: PropTypes.string.isRequired, currentPermission: PropTypes.string.isRequired,
onPermissionChangedHandler: PropTypes.func.isRequired onPermissionChanged: PropTypes.func.isRequired
}; };
class WikiPermissionEditor extends React.Component { class WikiPermissionEditor extends React.Component {
@ -30,7 +30,7 @@ class WikiPermissionEditor extends React.Component {
isEditIconShow={this.props.isEditIconShow} isEditIconShow={this.props.isEditIconShow}
options={this.props.permissions} options={this.props.permissions}
currentOption={this.props.currentPermission} currentOption={this.props.currentPermission}
onOptionChangedHandler={this.props.onPermissionChangedHandler} onOptionChanged={this.props.onPermissionChanged}
translateOption={this.translatePermission} translateOption={this.translatePermission}
/> />
); );

2
frontend/src/components/wiki-list-view/wiki-list-item.js
View File

@ -175,7 +175,7 @@ class WikiListItem extends Component {
isEditIconShow={this.state.showOpIcon} isEditIconShow={this.state.showOpIcon}
currentPermission={this.state.permission} currentPermission={this.state.permission}
permissions={this.permissions} permissions={this.permissions}
onPermissionChangedHandler={this.changePerm} onPermissionChanged={this.changePerm}
/> />
</td> </td>
<td className="text-center cursor-pointer"> <td className="text-center cursor-pointer">

2
frontend/src/pages/share-admin/folders.js
View File

@ -158,7 +158,7 @@ class Item extends Component {
isEditIconShow={this.state.showOpIcon} isEditIconShow={this.state.showOpIcon}
currentPermission={this.state.share_permission} currentPermission={this.state.share_permission}
permissions={this.permissions} permissions={this.permissions}
onPermissionChangedHandler={this.changePerm} onPermissionChanged={this.changePerm}
/> />
</td> </td>
<td><a href="#" className={unshareIconClassName} title={gettext('Unshare')} onClick={this.unshare}></a></td> <td><a href="#" className={unshareIconClassName} title={gettext('Unshare')} onClick={this.unshare}></a></td>

2
frontend/src/pages/share-admin/libraries.js
View File

@ -178,7 +178,7 @@ class Item extends Component {
isEditIconShow={this.state.showOpIcon} isEditIconShow={this.state.showOpIcon}
currentPermission={share_permission} currentPermission={share_permission}
permissions={this.permissions} permissions={this.permissions}
onPermissionChangedHandler={this.changePerm} onPermissionChanged={this.changePerm}
/> />
</td> </td>
<td><a href="#" className={unshareIconClassName} title={gettext('Unshare')} onClick={this.unshare}></a></td> <td><a href="#" className={unshareIconClassName} title={gettext('Unshare')} onClick={this.unshare}></a></td>