1
0
mirror of https://github.com/haiwen/seahub.git synced 2025-09-06 01:12:03 +00:00

optimized params name

This commit is contained in:
shanshuirenjia
2018-12-25 21:04:03 +08:00
parent 4cc406036b
commit 4a62c15356
3 changed files with 15 additions and 15 deletions

View File

@@ -43,7 +43,7 @@ class GroupItem extends React.Component {
<PermissionEditor <PermissionEditor
isTextMode={true} isTextMode={true}
currentPermission={item.permission} currentPermission={item.permission}
ownedPermissions={this.props.ownedPermissions} permissions={this.props.permissions}
onPermissionChangedHandler={this.onChangeUserPermission} onPermissionChangedHandler={this.onChangeUserPermission}
/> />
</td> </td>
@@ -71,7 +71,7 @@ class GroupList extends React.Component {
<GroupItem <GroupItem
key={index} key={index}
item={item} item={item}
ownedPermissions={this.props.ownedPermissions} permissions={this.props.permissions}
deleteShareItem={this.props.deleteShareItem} deleteShareItem={this.props.deleteShareItem}
onChangeUserPermission={this.props.onChangeUserPermission} onChangeUserPermission={this.props.onChangeUserPermission}
/> />
@@ -99,9 +99,9 @@ class ShareToGroup extends React.Component {
sharedItems: [] sharedItems: []
}; };
this.options = []; this.options = [];
this.ownedPermissions = ['rw', 'r', 'cloud-edit', 'preview']; this.permissions = ['rw', 'r', 'cloud-edit', 'preview'];
if (this.props.isGroupOwnedRepo) { if (this.props.isGroupOwnedRepo) {
this.ownedPermissions = ['rw', 'r']; this.permissions = ['rw', 'r'];
} }
} }
@@ -268,7 +268,7 @@ class ShareToGroup extends React.Component {
<PermissionEditor <PermissionEditor
isTextMode={false} isTextMode={false}
currentPermission={this.state.permission} currentPermission={this.state.permission}
ownedPermissions={this.ownedPermissions} permissions={this.permissions}
onPermissionChangedHandler={this.setPermission} onPermissionChangedHandler={this.setPermission}
/> />
</td> </td>
@@ -289,7 +289,7 @@ class ShareToGroup extends React.Component {
</thead> </thead>
<GroupList <GroupList
items={this.state.sharedItems} items={this.state.sharedItems}
ownedPermissions={this.ownedPermissions} permissions={this.permissions}
deleteShareItem={this.deleteShareItem} deleteShareItem={this.deleteShareItem}
onChangeUserPermission={this.onChangeUserPermission} onChangeUserPermission={this.onChangeUserPermission}
/> />

View File

@@ -42,7 +42,7 @@ class UserItem extends React.Component {
<PermissionEditor <PermissionEditor
isTextMode={true} isTextMode={true}
currentPermission={item.permission} currentPermission={item.permission}
ownedPermissions={this.props.ownedPermissions} permissions={this.props.permissions}
onPermissionChangedHandler={this.onChangeUserPermission} onPermissionChangedHandler={this.onChangeUserPermission}
/> />
</td> </td>
@@ -70,7 +70,7 @@ class UserList extends React.Component {
<UserItem <UserItem
key={index} key={index}
item={item} item={item}
ownedPermissions={this.props.ownedPermissions} permissions={this.props.permissions}
deleteShareItem={this.props.deleteShareItem} deleteShareItem={this.props.deleteShareItem}
onChangeUserPermission={this.props.onChangeUserPermission} onChangeUserPermission={this.props.onChangeUserPermission}
/> />
@@ -98,9 +98,9 @@ class ShareToUser extends React.Component {
sharedItems: [] sharedItems: []
}; };
this.options = []; this.options = [];
this.ownedPermissions = ['rw', 'r', 'admin', 'cloud-edit', 'preview']; this.permissions = ['rw', 'r', 'admin', 'cloud-edit', 'preview'];
if (this.props.isGroupOwnedRepo) { if (this.props.isGroupOwnedRepo) {
this.ownedPermissions = ['rw', 'r']; this.permissions = ['rw', 'r'];
} }
} }
@@ -288,7 +288,7 @@ class ShareToUser extends React.Component {
<PermissionEditor <PermissionEditor
isTextMode={false} isTextMode={false}
currentPermission={this.state.permission} currentPermission={this.state.permission}
ownedPermissions={this.ownedPermissions} permissions={this.permissions}
onPermissionChangedHandler={this.setPermission} onPermissionChangedHandler={this.setPermission}
/> />
</td> </td>
@@ -314,7 +314,7 @@ class ShareToUser extends React.Component {
</thead> </thead>
<UserList <UserList
items={sharedItems} items={sharedItems}
ownedPermissions={this.ownedPermissions} permissions={this.permissions}
deleteShareItem={this.deleteShareItem} deleteShareItem={this.deleteShareItem}
onChangeUserPermission={this.onChangeUserPermission} onChangeUserPermission={this.onChangeUserPermission}
/> />

View File

@@ -6,7 +6,7 @@ import { Input } from 'reactstrap';
const propTypes = { const propTypes = {
isTextMode: PropTypes.bool.isRequired, // there will be two mode. first: text and select. second: just select isTextMode: PropTypes.bool.isRequired, // there will be two mode. first: text and select. second: just select
currentPermission: PropTypes.string.isRequired, currentPermission: PropTypes.string.isRequired,
ownedPermissions: PropTypes.array.isRequired, permissions: PropTypes.array.isRequired,
onPermissionChangedHandler: PropTypes.func.isRequired, onPermissionChangedHandler: PropTypes.func.isRequired,
}; };
@@ -50,7 +50,7 @@ class PermissionEditor extends React.Component {
} }
render() { render() {
let { currentPermission, ownedPermissions, isTextMode } = this.props; let { currentPermission, permissions, isTextMode } = this.props;
// scence1: isTextMode (text)editor-icon --> select // scence1: isTextMode (text)editor-icon --> select
// scence2: !isTextMode select // scence2: !isTextMode select
@@ -65,7 +65,7 @@ class PermissionEditor extends React.Component {
<div className="permission-editor"> <div className="permission-editor">
{(!isTextMode || this.state.isEditing) && {(!isTextMode || this.state.isEditing) &&
<Input style={selectStyle} type="select" onChange={this.onPermissionChangedHandler} onClick={this.onSelectHandler} value={currentPermission}> <Input style={selectStyle} type="select" onChange={this.onPermissionChangedHandler} onClick={this.onSelectHandler} value={currentPermission}>
{ownedPermissions.map((item, index) => { {permissions.map((item, index) => {
return ( return (
<option key={index} value={item}>{Utils.sharePerms(item)}</option> <option key={index} value={item}>{Utils.sharePerms(item)}</option>
) )