haiwen/seahub
1
0
Fork 0
mirror of https://github.com/haiwen/seahub.git synced 2025-08-14 21:23:50 +00:00
Code Issues Releases Wiki Activity

optimized param name

Browse Source
This commit is contained in:
shanshuirenjia 2018-12-25 20:45:40 +08:00
parent cf321b3662
commit 4cc406036b
3 changed files with 23 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
frontend/src/components/dialog/share-to-group.js
View File

@ -42,8 +42,8 @@ class GroupItem extends React.Component {
<td> <td>
<PermissionEditor <PermissionEditor
isTextMode={true} isTextMode={true}
permission={item.permission} currentPermission={item.permission}
permissions={this.props.permissions} ownedPermissions={this.props.ownedPermissions}
onPermissionChangedHandler={this.onChangeUserPermission} onPermissionChangedHandler={this.onChangeUserPermission}
/> />
</td> </td>
@ -71,7 +71,7 @@ class GroupList extends React.Component {
<GroupItem <GroupItem
key={index} key={index}
item={item} item={item}
permissions={this.props.permissions} ownedPermissions={this.props.ownedPermissions}
deleteShareItem={this.props.deleteShareItem} deleteShareItem={this.props.deleteShareItem}
onChangeUserPermission={this.props.onChangeUserPermission} onChangeUserPermission={this.props.onChangeUserPermission}
/> />
@ -99,9 +99,9 @@ class ShareToGroup extends React.Component {
sharedItems: [] sharedItems: []
}; };
this.options = []; this.options = [];
this.permissions = ['rw', 'r', 'cloud-edit', 'preview']; this.ownedPermissions = ['rw', 'r', 'cloud-edit', 'preview'];
if (this.props.isGroupOwnedRepo) { if (this.props.isGroupOwnedRepo) {
this.permissions = ['rw', 'r']; this.ownedPermissions = ['rw', 'r'];
} }
} }
@ -267,8 +267,8 @@ class ShareToGroup extends React.Component {
<td> <td>
<PermissionEditor <PermissionEditor
isTextMode={false} isTextMode={false}
permission={this.state.permission} currentPermission={this.state.permission}
permissions={this.permissions} ownedPermissions={this.ownedPermissions}
onPermissionChangedHandler={this.setPermission} onPermissionChangedHandler={this.setPermission}
/> />
</td> </td>
@ -289,7 +289,7 @@ class ShareToGroup extends React.Component {
</thead> </thead>
<GroupList <GroupList
items={this.state.sharedItems} items={this.state.sharedItems}
permissions={this.permissions} ownedPermissions={this.ownedPermissions}
deleteShareItem={this.deleteShareItem} deleteShareItem={this.deleteShareItem}
onChangeUserPermission={this.onChangeUserPermission} onChangeUserPermission={this.onChangeUserPermission}
/> />

16
frontend/src/components/dialog/share-to-user.js
View File

@ -41,8 +41,8 @@ class UserItem extends React.Component {
<td> <td>
<PermissionEditor <PermissionEditor
isTextMode={true} isTextMode={true}
permission={item.permission} currentPermission={item.permission}
permissions={this.props.permissions} ownedPermissions={this.props.ownedPermissions}
onPermissionChangedHandler={this.onChangeUserPermission} onPermissionChangedHandler={this.onChangeUserPermission}
/> />
</td> </td>
@ -70,7 +70,7 @@ class UserList extends React.Component {
<UserItem <UserItem
key={index} key={index}
item={item} item={item}
permissions={this.props.permissions} ownedPermissions={this.props.ownedPermissions}
deleteShareItem={this.props.deleteShareItem} deleteShareItem={this.props.deleteShareItem}
onChangeUserPermission={this.props.onChangeUserPermission} onChangeUserPermission={this.props.onChangeUserPermission}
/> />
@ -98,9 +98,9 @@ class ShareToUser extends React.Component {
sharedItems: [] sharedItems: []
}; };
this.options = []; this.options = [];
this.permissions = ['rw', 'r', 'admin', 'cloud-edit', 'preview']; this.ownedPermissions = ['rw', 'r', 'admin', 'cloud-edit', 'preview'];
if (this.props.isGroupOwnedRepo) { if (this.props.isGroupOwnedRepo) {
this.permissions = ['rw', 'r']; this.ownedPermissions = ['rw', 'r'];
} }
} }
@ -287,8 +287,8 @@ class ShareToUser extends React.Component {
<td> <td>
<PermissionEditor <PermissionEditor
isTextMode={false} isTextMode={false}
permission={this.state.permission} currentPermission={this.state.permission}
permissions={this.permissions} ownedPermissions={this.ownedPermissions}
onPermissionChangedHandler={this.setPermission} onPermissionChangedHandler={this.setPermission}
/> />
</td> </td>
@ -314,7 +314,7 @@ class ShareToUser extends React.Component {
</thead> </thead>
<UserList <UserList
items={sharedItems} items={sharedItems}
permissions={this.permissions} ownedPermissions={this.ownedPermissions}
deleteShareItem={this.deleteShareItem} deleteShareItem={this.deleteShareItem}
onChangeUserPermission={this.onChangeUserPermission} onChangeUserPermission={this.onChangeUserPermission}
/> />

14
frontend/src/components/permission-editor.js
View File

@ -5,8 +5,8 @@ import { Input } from 'reactstrap';
const propTypes = { const propTypes = {
isTextMode: PropTypes.bool.isRequired, // there will be two mode. first: text and select. second: just select isTextMode: PropTypes.bool.isRequired, // there will be two mode. first: text and select. second: just select
permission: PropTypes.string.isRequired, currentPermission: PropTypes.string.isRequired,
permissions: PropTypes.array.isRequired, ownedPermissions: PropTypes.array.isRequired,
onPermissionChangedHandler: PropTypes.func.isRequired, onPermissionChangedHandler: PropTypes.func.isRequired,
}; };
@ -35,7 +35,7 @@ class PermissionEditor extends React.Component {
onPermissionChangedHandler = (e) => { onPermissionChangedHandler = (e) => {
e.nativeEvent.stopImmediatePropagation(); e.nativeEvent.stopImmediatePropagation();
let permission = e.target.value; let permission = e.target.value;
if (permission !== this.props.permission) { if (permission !== this.props.currentPermission) {
this.props.onPermissionChangedHandler(permission); this.props.onPermissionChangedHandler(permission);
} }
this.setState({isEditing: false}); this.setState({isEditing: false});
@ -50,7 +50,7 @@ class PermissionEditor extends React.Component {
} }
render() { render() {
let { permission, permissions, isTextMode } = this.props; let { currentPermission, ownedPermissions, isTextMode } = this.props;
// scence1: isTextMode (text)editor-icon --> select // scence1: isTextMode (text)editor-icon --> select
// scence2: !isTextMode select // scence2: !isTextMode select
@ -64,8 +64,8 @@ class PermissionEditor extends React.Component {
return ( return (
<div className="permission-editor"> <div className="permission-editor">
{(!isTextMode || this.state.isEditing) && {(!isTextMode || this.state.isEditing) &&
<Input style={selectStyle} type="select" onChange={this.onPermissionChangedHandler} onClick={this.onSelectHandler} value={permission}> <Input style={selectStyle} type="select" onChange={this.onPermissionChangedHandler} onClick={this.onSelectHandler} value={currentPermission}>
{permissions.map((item, index) => { {ownedPermissions.map((item, index) => {
return ( return (
<option key={index} value={item}>{Utils.sharePerms(item)}</option> <option key={index} value={item}>{Utils.sharePerms(item)}</option>
) )
@ -74,7 +74,7 @@ class PermissionEditor extends React.Component {
} }
{(isTextMode && !this.state.isEditing) && {(isTextMode && !this.state.isEditing) &&
<div> <div>
{Utils.sharePerms(permission)} {Utils.sharePerms(currentPermission)}
<span style={{fontSize: '0.875rem', marginLeft: '0.5rem'}} className="fa fa-pencil op-icon" onClick={this.onEidtPermission}></span> <span style={{fontSize: '0.875rem', marginLeft: '0.5rem'}} className="fa fa-pencil op-icon" onClick={this.onEidtPermission}></span>
</div> </div>
} }