Merge pull request #3633 from haiwen/fix-warnings

fix recent warnings

frontend/src/components/common/notice-item.js

@@ -210,7 +210,7 @@ class NoticeItem extends React.Component {
       <li onClick={this.onNoticeItemClick} className={noticeItem.seen ? 'read' : 'unread'}>
         <div className="notice-item">
           <div className="main-info">
-            <img src={avatar_url} width="32" height="32" className="avatar" />
+            <img src={avatar_url} width="32" height="32" className="avatar" alt=""/>
             <p className="brief" dangerouslySetInnerHTML={{__html: notice}}></p>
           </div>
           <p className="time">{moment(noticeItem.time).fromNow()}</p>

frontend/src/components/dialog/change-repo-password-dialog.js

@@ -1,4 +1,4 @@
-import React, { Fragment } from 'react';
+import React from 'react';
 import PropTypes from 'prop-types';
 import { Modal, ModalHeader, ModalBody, ModalFooter, Alert } from 'reactstrap'; 
 import { gettext, repoPasswordMinLength } from '../../utils/constants';
@@ -102,7 +102,7 @@ class ChangeRepoPasswordDialog extends React.Component {
 
 
   render() {
-    const { repoID, repoName, toggleDialog } = this.props;
+    const { repoName, toggleDialog } = this.props;
 
     return (
       <Modal isOpen={true} centered={true} style={{height: 'auto'}}>

frontend/src/components/wiki-markdown-viewer.js

@@ -235,7 +235,7 @@ class WikiMarkdownViewer extends React.Component {
       return <Loading />;
     }
     // In dir-column-file repoID is one of props, width is 100%; In wiki-viewer repoID is not props, width isn't 100%
-    let contentClassName = `${this.props.repoID ? contentClass + ' w-100' : contentClass}`
+    let contentClassName = `${this.props.repoID ? contentClass + ' w-100' : contentClass}`;
     return (
       <div ref={this.markdownContainer} className="wiki-page-container" onScroll={this.onScrollHandler.bind(this)}>
         <div className={contentClassName}>

frontend/src/pages/data-grid/app-main.js

@@ -23,7 +23,7 @@ const DEFAULT_DATA = {
     }
   ],
   rows:  [{name: 'name_' + 0}]
-}
+};
 
 class AppMain extends React.Component {
 

frontend/src/pages/groups/group-view.js

@@ -222,11 +222,11 @@ class GroupView extends React.Component {
       });
       this.setState({repoList: repoList});
       let name = repo.repo_name;
-      var msg = gettext("Successfully deleted {name}.").replace('{name}', name);
+      var msg = gettext('Successfully deleted {name}.').replace('{name}', name);
       toaster.success(msg);
     }).catch(() => {
       let name = repo.repo_name;
-      var msg = gettext("Failed to delete {name}.").replace('{name}', name);
+      var msg = gettext('Failed to delete {name}.').replace('{name}', name);
       toaster.danger(msg);
     });
   }

frontend/src/pages/my-libs/mylib-repo-list-item.js

@@ -196,11 +196,11 @@ class MylibRepoListItem extends React.Component {
     seafileAPI.deleteRepo(repo.repo_id).then((res) => {
       this.props.onDeleteRepo(repo);
       let name = repo.repo_name;
-      var msg = gettext("Successfully deleted {name}.").replace('{name}', name);
+      var msg = gettext('Successfully deleted {name}.').replace('{name}', name);
       toaster.success(msg);
     }).catch(() => {
       let name = repo.repo_name;
-      var msg = gettext("Failed to delete {name}.").replace('{name}', name);
+      var msg = gettext('Failed to delete {name}.').replace('{name}', name);
       toaster.danger(msg);
     });
   }

frontend/src/pages/share-admin/share-links.js

@@ -121,7 +121,7 @@ class Item extends Component {
   constructor(props) {
     super(props);
 
-    let item = this.props.item
+    let item = this.props.item;
     this.state = {
       currentPermission: item.permissions.can_download ? 'Preview and download' : 'Preview only',
       showOpIcon: false,
@@ -210,7 +210,7 @@ class Item extends Component {
     let deleteIconClassName = 'sf2-icon-delete action-icon' + iconVisibility;
     return (
       <tr onMouseEnter={this.handleMouseOver} onMouseLeave={this.handleMouseOut}>
-        <td><img src={iconUrl} width="24" /></td>
+        <td><img src={iconUrl} width="24" alt=""/></td>
         <td>
           {item.is_dir ?
             <Link to={linkUrl}>{item.obj_name}</Link> :

frontend/src/pages/shared-libs/shared-libs.js

@@ -196,7 +196,7 @@ class Item extends Component {
     } else {
       seafileAPI.starItem(this.props.data.repo_id, '/').then(() => {
         this.setState({isStarred: !this.state.isStarred});
-      })
+      });
     }
   }
 
@@ -266,7 +266,7 @@ class Item extends Component {
             {(isPro && data.is_admin) &&
               <a href="#" className={shareIconClassName} title={gettext('Share')} onClick={this.share}></a>
             }
-            <a href="#" className={leaveShareIconClassName} title={gettext("Leave Share")} onClick={this.leaveShare}></a>
+            <a href="#" className={leaveShareIconClassName} title={gettext('Leave Share')} onClick={this.leaveShare}></a>
           </td>
         </tr>
         {this.state.isShowSharedDialog && (

frontend/src/pages/sys-admin/index.js

@@ -1,11 +1,11 @@
 import React from 'react';
 import ReactDOM from 'react-dom';
 import { Router } from '@reach/router';
-import { siteRoot, gettext } from '../../utils/constants';
+import { siteRoot } from '../../utils/constants';
 import SidePanel from './side-panel';
 import MainPanel from './main-panel';
 import FileScanRecords from './file-scan-records';
-import WorkWeixinDepartments from './work-weixin-departments'
+import WorkWeixinDepartments from './work-weixin-departments';
 
 import '../../assets/css/fa-solid.css';
 import '../../assets/css/fa-regular.css';

frontend/src/pages/sys-admin/work-weixin-departments.js

@@ -231,8 +231,8 @@ class WorkWeixinDepartments extends Component {
       <div className="main-panel-north border-left-show">
         <div className="cur-view-toolbar">
           <span className="sf2-icon-menu side-nav-toggle hidden-md-up d-md-none" title="Side Nav Menu"></span>
-          <Button className={btnClass + "my-1 d-md-none"} onClick={this.onSubmit}>{'导入用户'}</Button>
+          <Button className={btnClass + 'my-1 d-md-none'} onClick={this.onSubmit}>{'导入用户'}</Button>
-          <Button className={btnClass + "hidden-md-up"} onClick={this.onSubmit}>{'导入用户'}</Button>
+          <Button className={btnClass + 'hidden-md-up'} onClick={this.onSubmit}>{'导入用户'}</Button>
         </div>
         <div className="common-toolbar">
           <Account isAdminPanel={true}/>

frontend/src/pages/sys-admin/work-weixin/work-weixin-department-members-list.js

@@ -70,7 +70,7 @@ class WorkWeixinDepartmentMembersList extends Component {
         }
         {!isMembersListLoading && this.props.membersList.length === 0 &&
           <div className="message empty-tip text-center">
-            <img src={`${siteRoot}media/img/member-list-empty-2x.png`}/>
+            <img src={`${siteRoot}media/img/member-list-empty-2x.png`} alt=""/>
             <h4>{'成员列表为空'}</h4>
           </div>
         }

frontend/src/pages/sys-admin/work-weixin/work-weixin-departments-tree-node.js

@@ -55,7 +55,7 @@ class WorkWeixinDepartmentsTreeNode extends Component {
     let toggleClass = classNames({
       'folder-toggle-icon fa fa-caret-down': department.children && this.state.isChildrenShow,
       'folder-toggle-icon fa fa-caret-right': department.children && !this.state.isChildrenShow,
-    })
+    });
     let nodeInnerClass = classNames({
       'tree-node-inner': true,
       'tree-node-hight-light': checkedDepartmentId === department.id