use post request when download multy file/folder (#2529)

seahub/api2/endpoints/zip_task.py

@@ -32,10 +32,13 @@ class ZipTaskView(APIView):
     throttle_classes = (UserRateThrottle,)
 
     def get(self, request, repo_id, format=None):
-        """ Get file server token for download-dir and download-multi.
+        """ Deprecated.
 
-        Permission checking:
-        1. user with 'r' or 'rw' permission;
+        Sometimes when user download too many files in one request,
+        Nginx will return 414-Request-URI Too Large error.
+
+        So, use the following POST request instead.
+        Put all parameters in request body.
         """
 
         # argument check
@@ -150,3 +153,123 @@ class ZipTaskView(APIView):
                 send_file_access_msg(request, repo, full_dirent_path, 'web')
 
         return Response({'zip_token': zip_token})
+
+    def post(self, request, repo_id, format=None):
+        """ Get file server token for download-dir and download-multi.
+
+        Permission checking:
+        1. user with 'r' or 'rw' permission;
+        """
+
+        # argument check
+        parent_dir = request.data.get('parent_dir', None)
+        if not parent_dir:
+            error_msg = 'parent_dir invalid.'
+            return api_error(status.HTTP_400_BAD_REQUEST, error_msg)
+
+        dirent_name_list = request.data.getlist('dirents', None)
+        if not dirent_name_list:
+            error_msg = 'dirents invalid.'
+            return api_error(status.HTTP_400_BAD_REQUEST, error_msg)
+
+        if len(dirent_name_list) == 1:
+            download_type = 'download-dir'
+        elif len(dirent_name_list) > 1:
+            download_type = 'download-multi'
+        else:
+            error_msg = 'dirents invalid.'
+            return api_error(status.HTTP_400_BAD_REQUEST, error_msg)
+
+        # recourse check
+        repo = seafile_api.get_repo(repo_id)
+        if not repo:
+            error_msg = 'Library %s not found.' % repo_id
+            return api_error(status.HTTP_404_NOT_FOUND, error_msg)
+
+        if not seafile_api.get_dir_id_by_path(repo_id, parent_dir):
+            error_msg = 'Folder %s not found.' % parent_dir
+            return api_error(status.HTTP_404_NOT_FOUND, error_msg)
+
+        # permission check
+        if not check_folder_permission(request, repo_id, parent_dir):
+            error_msg = 'Permission denied.'
+            return api_error(status.HTTP_403_FORBIDDEN, error_msg)
+
+        # get file server access token
+        is_windows = 0
+        if is_windows_operating_system(request):
+            is_windows = 1
+
+        if download_type == 'download-dir':
+            dir_name = dirent_name_list[0].strip('/')
+            full_dir_path = posixpath.join(parent_dir, dir_name)
+
+            dir_id = seafile_api.get_dir_id_by_path(repo_id, full_dir_path)
+            if not dir_id:
+                error_msg = 'Folder %s not found.' % full_dir_path
+                return api_error(status.HTTP_404_NOT_FOUND, error_msg)
+
+            dir_size = seafile_api.get_dir_size(
+                    repo.store_id, repo.version, dir_id)
+
+            if dir_size > seaserv.MAX_DOWNLOAD_DIR_SIZE:
+                error_msg = 'Unable to download directory "%s": size is too large.' % dir_name
+                return api_error(status.HTTP_400_BAD_REQUEST, error_msg)
+
+            fake_obj_id = {
+                'obj_id': dir_id,
+                'dir_name': dir_name,
+                'is_windows': is_windows
+            }
+
+        if download_type == 'download-multi':
+            dirent_list = []
+            total_size = 0
+            for dirent_name in dirent_name_list:
+                dirent_name = dirent_name.strip('/')
+                dirent_list.append(dirent_name)
+
+                full_dirent_path = posixpath.join(parent_dir, dirent_name)
+                current_dirent = seafile_api.get_dirent_by_path(repo_id, full_dirent_path)
+                if not current_dirent:
+                    continue
+
+                if stat.S_ISDIR(current_dirent.mode):
+                    total_size += seafile_api.get_dir_size(repo.store_id,
+                        repo.version, current_dirent.obj_id)
+                else:
+                    total_size += current_dirent.size
+
+            if total_size > seaserv.MAX_DOWNLOAD_DIR_SIZE:
+                error_msg = _('Total size exceeds limit.')
+                return api_error(status.HTTP_400_BAD_REQUEST, error_msg)
+
+            fake_obj_id = {
+                'parent_dir': parent_dir,
+                'file_list': dirent_list,
+                'is_windows': is_windows
+            }
+
+        username = request.user.username
+        try:
+            zip_token = seafile_api.get_fileserver_access_token(
+                repo_id, json.dumps(fake_obj_id), download_type, username,
+                use_onetime=settings.FILESERVER_TOKEN_ONCE_ONLY
+            )
+        except Exception as e:
+            logger.error(e)
+            error_msg = 'Internal Server Error'
+            return api_error(status.HTTP_500_INTERNAL_SERVER_ERROR, error_msg)
+
+        if not zip_token:
+            error_msg = 'Internal Server Error'
+            return api_error(status.HTTP_500_INTERNAL_SERVER_ERROR, error_msg)
+
+        if len(dirent_name_list) > 10:
+            send_file_access_msg(request, repo, parent_dir, 'web')
+        else:
+            for dirent_name in dirent_name_list:
+                full_dirent_path = posixpath.join(parent_dir, dirent_name)
+                send_file_access_msg(request, repo, full_dirent_path, 'web')
+
+        return Response({'zip_token': zip_token})

static/scripts/common.js

@@ -1141,8 +1141,10 @@ define([
                     'parent_dir': parent_dir,
                     'dirents': dirents
                 },
+                type: 'POST',
                 traditional: true,
                 dataType: 'json',
+                beforeSend: this.prepareCSRFToken,
                 success: function(data) {
                     zip_token = data['zip_token'];
                     $tip.html(packagingTip).modal({