From f53815baf9f825da6aafe392fcef5fe7394601ee Mon Sep 17 00:00:00 2001
From: Michael An <2331806369@qq.com>
Date: Mon, 26 Aug 2019 10:54:27 +0800
Subject: [PATCH 1/6] add title in published repo folder item (#4020)

---
 frontend/src/components/index-viewer.js | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/frontend/src/components/index-viewer.js b/frontend/src/components/index-viewer.js
index 7549326bd3..a5e86abfd7 100644
--- a/frontend/src/components/index-viewer.js
+++ b/frontend/src/components/index-viewer.js
@@ -249,12 +249,12 @@ class FolderItem extends React.Component {
     });
   }
 
-  renderLink = (node) => {
-    const className = node.path === this.props.currentPath ? 'wiki-nav-content wiki-nav-content-highlight' : 'wiki-nav-content';
-    if (node.href && node.name) {
-      return <div className={className}><a href={node.href} data-path={node.path} onClick={this.toggleExpanded}>{node.name}</a></div>;
-    } else if (node.name) {
-      return <div className="wiki-nav-content"><span onClick={this.toggleExpanded}>{node.name}</span></div>;
+  renderLink = ({ href, name, path }) => {
+    const className = `wiki-nav-content ${path === this.props.currentPath ? 'wiki-nav-content-highlight' : ''}`;
+    if (href && name) {
+      return <div className={className}><a href={href} data-path={path} onClick={this.toggleExpanded} title={name}>{name}</a></div>;
+    } else if (name) {
+      return <div className="wiki-nav-content"><span onClick={this.toggleExpanded} title={name}>{name}</span></div>;
     } else {
       return null;
     }

From 7aa426935f19ff5c4fb916041299c0e08dedb346 Mon Sep 17 00:00:00 2001
From: llj <lingjun.li1@gmail.com>
Date: Tue, 27 Aug 2019 12:04:03 +0800
Subject: [PATCH 2/6] [share dialog] share link: improved 'permission' (#4018)

---
 .../components/dialog/generate-share-link.js  | 87 +++++++------------
 1 file changed, 33 insertions(+), 54 deletions(-)

diff --git a/frontend/src/components/dialog/generate-share-link.js b/frontend/src/components/dialog/generate-share-link.js
index 1f6fc7de6b..741d75630b 100644
--- a/frontend/src/components/dialog/generate-share-link.js
+++ b/frontend/src/components/dialog/generate-share-link.js
@@ -24,6 +24,12 @@ class GenerateShareLink extends React.Component {
 
     this.isExpireDaysNoLimit = (parseInt(shareLinkExpireDaysMin) === 0 && parseInt(shareLinkExpireDaysMax) === 0 && shareLinkExpireDaysDefault == 0);
     this.defaultExpireDays = this.isExpireDaysNoLimit ? '' : shareLinkExpireDaysDefault;
+
+    if (isPro) {
+      this.editOption = 'edit_download';
+      this.permissionOptions = ['preview_download', 'preview_only'];
+    }   
+
     this.state = {
       isValidate: false,
       isShowPasswordInput: false,
@@ -36,14 +42,9 @@ class GenerateShareLink extends React.Component {
       sharedLinkInfo: null,
       isNoticeMessageShow: false,
       isLoading: true,
-      fileInfo: null,
+      currentPermission: isPro ? this.permissionOptions[0] : '',
       isSendLinkShown: false
     };
-    this.permissions = {
-      'can_edit': false, 
-      'can_download': true
-    };
-    this.isOfficeFile = Utils.isEditableOfficeFile(this.props.itemPath);
   }
 
   componentDidMount() {
@@ -63,10 +64,11 @@ class GenerateShareLink extends React.Component {
       let errMessage = Utils.getErrorMsg(error);
       toaster.danger(errMessage);
     });
-    if (this.isOfficeFile) {
+
+    if (isPro && Utils.isEditableOfficeFile(path)) {
       seafileAPI.getFileInfo(repoID, path).then((res) => {
-        if (res.data) {
-          this.setState({fileInfo: res.data});
+        if (res.data.can_edit) {
+          this.permissionOptions.push(this.editOption);
         }
       }).catch(error => {
         let errMessage = Utils.getErrorMsg(error);
@@ -108,23 +110,8 @@ class GenerateShareLink extends React.Component {
     this.setState({passwdnew: passwd});
   }
 
-  setPermission = (permission) => {
-    if (permission == 'previewAndDownload') {
-      this.permissions = {
-        'can_edit': false,
-        'can_download': true
-      };
-    } else if (permission == 'preview') {
-      this.permissions = {
-        'can_edit': false,
-        'can_download': false
-      };     
-    } else if (permission == 'editOnCloudAndDownload'){
-      this.permissions = {
-        'can_edit': true,
-        'can_download': true
-      };
-    }
+  setPermission = (e) => {
+    this.setState({currentPermission: e.target.value});
   }
 
   generateShareLink = () => {
@@ -133,7 +120,11 @@ class GenerateShareLink extends React.Component {
       this.setState({errorInfo: ''});
       let { itemPath, repoID } = this.props;
       let { password, isExpireChecked, expireDays } = this.state;
-      let permissions = isPro ? JSON.stringify(this.permissions) : '';
+      let permissions;
+      if (isPro) {
+        const permissionDetails = Utils.getShareLinkPermissionObject(this.state.currentPermission).permissionDetails;
+        permissions = JSON.stringify(permissionDetails);
+      }
       const expireDaysSent = isExpireChecked ? expireDays : '';
       seafileAPI.createShareLink(repoID, itemPath, password, expireDaysSent, permissions).then((res) => {
         let sharedLinkInfo = new ShareLink(res.data);
@@ -172,10 +163,6 @@ class GenerateShareLink extends React.Component {
         sharedLinkInfo: null,
         isNoticeMessageShow: false,
       });
-      this.permissions = {
-        'can_edit': false,
-        'can_download': true
-      };
     }).catch((error) => {
       let errMessage = Utils.getErrorMsg(error);
       toaster.danger(errMessage);
@@ -340,7 +327,6 @@ class GenerateShareLink extends React.Component {
         </div>
       );
     } else {
-      let fileInfo = this.state.fileInfo;
       return (
         <Form className="generate-share-link">
           <FormGroup check>
@@ -403,28 +389,21 @@ class GenerateShareLink extends React.Component {
           )}
           {isPro && ( 
             <Fragment>
-          <FormGroup check>
-            <Label check>
-              <span>{'  '}{gettext('Set permission')}</span>
-            </Label>
-          </FormGroup>
-          <FormGroup check className="permission">
-            <Label className="form-check-label">
-              <Input type="radio" name="radio1" defaultChecked={true} onChange={() => this.setPermission('previewAndDownload')}/>{'  '}{gettext('Preview and download')}
-            </Label>
-          </FormGroup>
-          <FormGroup check className="permission">
-            <Label className="form-check-label">
-              <Input type="radio" name="radio1" onChange={() => this.setPermission('preview')} />{'  '}{gettext('Preview only')}
-            </Label>
-          </FormGroup>
-          {(this.isOfficeFile && fileInfo && fileInfo.can_edit) &&
-            <FormGroup check className="permission">
-              <Label className="form-check-label">
-                <Input type="radio" name="radio1" onChange={() => this.setPermission('editOnCloudAndDownload')} />{'  '}{gettext('Edit on cloud and download')}
-              </Label>
-            </FormGroup>
-          }
+              <FormGroup check>
+                <Label check>
+                  <span>{gettext('Set permission')}</span>
+                </Label>
+              </FormGroup>
+              {this.permissionOptions.map((item, index) => {
+                return (
+                  <FormGroup check className="permission" key={index}>
+                    <Label className="form-check-label">
+                      <Input type="radio" name="permission" value={item} checked={this.state.currentPermission == item} onChange={this.setPermission} className="mr-1" />
+                      {Utils.getShareLinkPermissionObject(item).text}
+                    </Label>
+                  </FormGroup>
+                );
+              })}
             </Fragment>
           )}
           {this.state.errorInfo && <Alert color="danger" className="mt-2">{gettext(this.state.errorInfo)}</Alert>}

From c487805b5988593af36b23bb7a7da665af7f6ef0 Mon Sep 17 00:00:00 2001
From: llj <lingjun.li1@gmail.com>
Date: Wed, 28 Aug 2019 11:23:15 +0800
Subject: [PATCH 3/6] [shared file view] fixup for download url (#4026)

---
 .../src/components/shared-file-view/shared-file-view-tip.js   | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/frontend/src/components/shared-file-view/shared-file-view-tip.js b/frontend/src/components/shared-file-view/shared-file-view-tip.js
index 90170bf150..0c7add7e79 100644
--- a/frontend/src/components/shared-file-view/shared-file-view-tip.js
+++ b/frontend/src/components/shared-file-view/shared-file-view-tip.js
@@ -2,7 +2,7 @@ import React from 'react';
 import PropTypes from 'prop-types';
 import { gettext } from '../../utils/constants';
 
-const { err, trafficOverLimit } = window.shared.pageOptions;
+const { err, trafficOverLimit, zipped, filePath } = window.shared.pageOptions;
 
 const propTypes = {
   errorMsg: PropTypes.string
@@ -21,7 +21,7 @@ class SharedFileViewTip extends React.Component {
         <div className="file-view-tip">
           {errorMsg}
           {!trafficOverLimit &&
-            <a href="?dl=1" className="btn btn-secondary">{gettext('Download')}</a>
+            <a href={`?${zipped ? 'p=' + encodeURIComponent(filePath) + '&' : ''}dl=1`} className="btn btn-secondary">{gettext('Download')}</a>
           }
         </div>
       </div>

From 752aa3001c5a660e924f2e89441db3b871a20d50 Mon Sep 17 00:00:00 2001
From: llj <lingjun.li1@gmail.com>
Date: Wed, 28 Aug 2019 12:16:56 +0800
Subject: [PATCH 4/6] [side nav] sort group list (#4027)

---
 frontend/src/components/main-side-nav.js | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/frontend/src/components/main-side-nav.js b/frontend/src/components/main-side-nav.js
index f3e229eccd..713dd1762f 100644
--- a/frontend/src/components/main-side-nav.js
+++ b/frontend/src/components/main-side-nav.js
@@ -54,7 +54,9 @@ class MainSideNav extends React.Component {
 
       this.groupsHeight = (groupList.length + 1) * _this.listHeight;
       _this.setState({
-        groupItems: groupList
+        groupItems: groupList.sort((a, b) => {
+          return a.name.toLowerCase() < b.name.toLowerCase() ? -1 : 1;
+        })
       });
     }).catch(error => {
       let errMessage = Utils.getErrorMsg(error);

From 84735b6eaa4286bb1d77334305b792f27a53ed11 Mon Sep 17 00:00:00 2001
From: llj <lingjun.li1@gmail.com>
Date: Wed, 28 Aug 2019 18:30:19 +0800
Subject: [PATCH 5/6] [dir view] designed top toolbar for mobile (#4029)

---
 .../toolbar/dir-operation-toolbar.js          | 39 +++++++++++++++----
 .../lib-content-view/lib-content-toolbar.js   |  3 +-
 .../shared-with-all/public-shared-view.js     |  2 +-
 3 files changed, 34 insertions(+), 10 deletions(-)

diff --git a/frontend/src/components/toolbar/dir-operation-toolbar.js b/frontend/src/components/toolbar/dir-operation-toolbar.js
index 09a95dd5ed..f313d291e2 100644
--- a/frontend/src/components/toolbar/dir-operation-toolbar.js
+++ b/frontend/src/components/toolbar/dir-operation-toolbar.js
@@ -1,5 +1,6 @@
 import React, { Fragment } from 'react';
 import PropTypes from 'prop-types';
+import { Dropdown, DropdownToggle, DropdownMenu, DropdownItem } from 'reactstrap';
 import { Utils } from '../../utils/utils';
 import { gettext } from '../../utils/constants';
 import ModalPortal from '../modal-portal';
@@ -35,6 +36,7 @@ class DirOperationToolbar extends React.Component {
       isCreateMenuShow: false,
       isShareDialogShow: false,
       operationMenuStyle: '',
+      isMobileOpMenuOpen: false
     };
   }
 
@@ -46,6 +48,10 @@ class DirOperationToolbar extends React.Component {
     document.removeEventListener('click', this.hideOperationMenu);
   }
 
+  toggleMobileOpMenu = () => {
+    this.setState({isMobileOpMenuOpen: !this.state.isMobileOpMenuOpen});
+  }
+
   hideOperationMenu = () => {
     this.setState({
       isUploadMenuShow: false,
@@ -161,17 +167,34 @@ class DirOperationToolbar extends React.Component {
 
     let itemType = path === '/' ? 'library' : 'dir';
     let itemName = path == '/' ? repoName : Utils.getFolderName(path);
+
+    const content = Utils.isDesktop() ? (
+      <Fragment>
+        {Utils.isSupportUploadFolder() ?
+          <button className="btn btn-secondary operation-item" title={gettext('Upload')} onClick={this.onUploadClick}>{gettext('Upload')}</button> :
+          <button className="btn btn-secondary operation-item" title={gettext('Upload')} onClick={this.onUploadFile}>{gettext('Upload')}</button>}
+        <button className="btn btn-secondary operation-item" title={gettext('New')} onClick={this.onCreateClick}>{gettext('New')}</button>
+        {this.props.showShareBtn &&
+          <button className="btn btn-secondary operation-item" title={gettext('Share')} onClick={this.onShareClick}>{gettext('Share')}</button>}
+      </Fragment>
+    ) : (
+      <Dropdown isOpen={this.state.isMobileOpMenuOpen} toggle={this.toggleMobileOpMenu}>
+        <DropdownToggle
+          tag="span"
+          className="sf2-icon-plus mobile-toolbar-icon"
+        />
+        <DropdownMenu>
+          <DropdownItem onClick={this.onUploadFile}>{gettext('Upload')}</DropdownItem>
+          <DropdownItem onClick={this.onCreateFolderToggle}>{gettext('New Folder')}</DropdownItem>
+          <DropdownItem onClick={this.onCreateFileToggle}>{gettext('New File')}</DropdownItem>
+        </DropdownMenu>
+      </Dropdown>
+    );
+
     return (
       <Fragment>
         <div className="operation">
-          {Utils.isSupportUploadFolder() ?
-            <button className="btn btn-secondary operation-item" title={gettext('Upload')} onClick={this.onUploadClick}>{gettext('Upload')}</button> :
-            <button className="btn btn-secondary operation-item" title={gettext('Upload')} onClick={this.onUploadFile}>{gettext('Upload')}</button>
-          }
-          <button className="btn btn-secondary operation-item" title={gettext('New')} onClick={this.onCreateClick}>{gettext('New')}</button>
-          {this.props.showShareBtn &&
-          <button className="btn btn-secondary operation-item" title={gettext('Share')} onClick={this.onShareClick}>{gettext('Share')}</button>
-          }
+          {content}
         </div>
         {this.state.isUploadMenuShow && (
           <ul className="menu dropdown-menu" style={this.state.operationMenuStyle}>
diff --git a/frontend/src/pages/lib-content-view/lib-content-toolbar.js b/frontend/src/pages/lib-content-view/lib-content-toolbar.js
index 739211dcf9..c8705bff16 100644
--- a/frontend/src/pages/lib-content-view/lib-content-toolbar.js
+++ b/frontend/src/pages/lib-content-view/lib-content-toolbar.js
@@ -1,5 +1,6 @@
 import React, { Fragment } from 'react';
 import PropTypes from 'prop-types';
+import { Utils } from '../../utils/utils';
 import { gettext } from '../../utils/constants';
 import CommonToolbar from '../../components/toolbar/common-toolbar';
 import ViewModeToolbar from '../../components/toolbar/view-mode-toolbar';
@@ -123,7 +124,7 @@ class LibContentToolbar extends React.Component {
               />
             }
           </div>
-          <ViewModeToolbar currentMode={this.props.currentMode} switchViewMode={this.props.switchViewMode}/>
+          {Utils.isDesktop() && <ViewModeToolbar currentMode={this.props.currentMode} switchViewMode={this.props.switchViewMode} />}
         </div>
         <CommonToolbar repoID={this.props.repoID} onSearchedClick={this.props.onSearchedClick} searchPlaceholder={gettext('Search files in this library')}/>
       </Fragment>
diff --git a/frontend/src/pages/shared-with-all/public-shared-view.js b/frontend/src/pages/shared-with-all/public-shared-view.js
index 9a90c6eef0..5a07910a3b 100644
--- a/frontend/src/pages/shared-with-all/public-shared-view.js
+++ b/frontend/src/pages/shared-with-all/public-shared-view.js
@@ -2,7 +2,7 @@ import React, { Fragment } from 'react';
 import PropTypes from 'prop-types';
 import cookie from 'react-cookies';
 import MediaQuery from 'react-responsive';
-import { Dropdown, DropdownToggle, DropdownMenu, DropdownItem} from 'reactstrap';
+import { Dropdown, DropdownToggle, DropdownMenu, DropdownItem } from 'reactstrap';
 import { seafileAPI } from '../../utils/seafile-api';
 import { gettext, loginUrl, canAddPublicRepo } from '../../utils/constants';
 import { Utils } from '../../utils/utils';

From 291ccf347e5aab5189913aad824eca7386aa27c8 Mon Sep 17 00:00:00 2001
From: lian <imwhatiam123@gmail.com>
Date: Thu, 29 Aug 2019 10:26:39 +0800
Subject: [PATCH 6/6] redirect user back to previous page after user login
 (#4024)

---
 seahub/auth/views.py | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/seahub/auth/views.py b/seahub/auth/views.py
index 5b3efb70d3..68c8e56e60 100644
--- a/seahub/auth/views.py
+++ b/seahub/auth/views.py
@@ -86,15 +86,18 @@ def _handle_login_form_valid(request, user, redirect_to, remember_me):
 @csrf_protect
 @never_cache
 def login(request, template_name='registration/login.html',
-          redirect_if_logged_in=None,
+          redirect_if_logged_in='libraries',
           redirect_field_name=REDIRECT_FIELD_NAME,
           authentication_form=AuthenticationForm):
     """Displays the login form and handles the login action."""
 
-    if request.user.is_authenticated() and redirect_if_logged_in:
-        return HttpResponseRedirect(reverse(redirect_if_logged_in))
-
     redirect_to = request.GET.get(redirect_field_name, '')
+    if request.user.is_authenticated():
+        if redirect_to:
+            return HttpResponseRedirect(redirect_to)
+        else:
+            return HttpResponseRedirect(reverse(redirect_if_logged_in))
+
     ip = get_remote_ip(request)
 
     if request.method == "POST":