From 390424fe306ce56649d82576347279dde3d165ec Mon Sep 17 00:00:00 2001 From: llj Date: Sat, 22 Apr 2017 15:47:25 +0800 Subject: [PATCH 1/2] [dir view] enable 'select text' when rename --- static/scripts/app/views/dirent.js | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/static/scripts/app/views/dirent.js b/static/scripts/app/views/dirent.js index e5297d9224..016ec8965b 100644 --- a/static/scripts/app/views/dirent.js +++ b/static/scripts/app/views/dirent.js @@ -366,6 +366,8 @@ define([ $op.hide(); $name.hide(); + this.$el.attr('draggable', false); + var $input = $('[name="newname"]', form); var dot_index = dirent_name.lastIndexOf('.'); if (!this.model.get('is_dir') && dot_index != -1) { @@ -383,6 +385,8 @@ define([ app.ui.currentHighlightedItem.rmHighlight(); } + _this.$el.attr('draggable', true); + if (_this.model.get('is_img')) { var index = $('.img-name-link', _this.dirView.$dirent_list).index(_this.$('.img-name-link')); _this.dirView.updateMagnificPopupOptions({ @@ -403,6 +407,8 @@ define([ $td.attr('colspan', 1).css({ 'width': $name.width() }); + + _this.$el.attr('draggable', true); return false; // stop bubbling (to 'doc click to hide .hidden-op') }; $('.cancel', form).click(cancelRename); From dbc8d1b041b3b793fd850024e4905c504c8bff07 Mon Sep 17 00:00:00 2001 From: llj Date: Sat, 22 Apr 2017 16:30:58 +0800 Subject: [PATCH 2/2] [dir view] rename: fix --- static/scripts/app/models/dirent.js | 2 +- static/scripts/app/views/dialogs/dirent-rename.js | 1 + static/scripts/app/views/dirent.js | 1 + 3 files changed, 3 insertions(+), 1 deletion(-) diff --git a/static/scripts/app/models/dirent.js b/static/scripts/app/models/dirent.js index 92b007b00c..d2651fb77d 100644 --- a/static/scripts/app/models/dirent.js +++ b/static/scripts/app/models/dirent.js @@ -108,7 +108,7 @@ define([ data: post_data, success: function(data) { var renamed_dirent_data = { - 'obj_name': options.newname, + 'obj_name': data.obj_name, 'last_modified': new Date().getTime()/1000, 'last_update': gettext("Just now") }; diff --git a/static/scripts/app/views/dialogs/dirent-rename.js b/static/scripts/app/views/dialogs/dirent-rename.js index e6c7d530ef..a94805db5c 100644 --- a/static/scripts/app/views/dialogs/dirent-rename.js +++ b/static/scripts/app/views/dialogs/dirent-rename.js @@ -24,6 +24,7 @@ define([ var $input = this.$('[name="newname"]'); var dot_index = this.dirent.get('obj_name').lastIndexOf('.'); if (!this.dirent.get('is_dir') && dot_index != -1) { + $input[0].focus(); $input[0].setSelectionRange(0, dot_index); } else { $input.select(); diff --git a/static/scripts/app/views/dirent.js b/static/scripts/app/views/dirent.js index 016ec8965b..75df7cd541 100644 --- a/static/scripts/app/views/dirent.js +++ b/static/scripts/app/views/dirent.js @@ -371,6 +371,7 @@ define([ var $input = $('[name="newname"]', form); var dot_index = dirent_name.lastIndexOf('.'); if (!this.model.get('is_dir') && dot_index != -1) { + $input[0].focus(); $input[0].setSelectionRange(0, dot_index); } else { $input.select();