mirror of
https://github.com/haiwen/seahub.git
synced 2025-09-10 03:11:07 +00:00
optimize code (#5605)
This commit is contained in:
@@ -8,6 +8,7 @@ const propTypes = {
|
||||
isTextMode: PropTypes.bool.isRequired, // there will be two mode. first: text and select. second: just select
|
||||
isEditing: PropTypes.bool,
|
||||
isEditIconShow: PropTypes.bool.isRequired,
|
||||
autoFocus: PropTypes.bool,
|
||||
options: PropTypes.array.isRequired,
|
||||
currentOption: PropTypes.string.isRequired,
|
||||
translateOption: PropTypes.func.isRequired,
|
||||
@@ -16,7 +17,6 @@ const propTypes = {
|
||||
toggleItemFreezed: PropTypes.func,
|
||||
enableAddCustomPermission: PropTypes.bool,
|
||||
onAddCustomPermissionToggle: PropTypes.func,
|
||||
|
||||
};
|
||||
|
||||
class SelectEditor extends React.Component {
|
||||
@@ -24,6 +24,7 @@ class SelectEditor extends React.Component {
|
||||
static defaultProps = {
|
||||
enableAddCustomPermission: false,
|
||||
isEditing: false,
|
||||
autoFocus: false,
|
||||
}
|
||||
|
||||
constructor(props) {
|
||||
@@ -145,6 +146,7 @@ class SelectEditor extends React.Component {
|
||||
menuPortalTarget={document.querySelector('#wrapper')}
|
||||
styles={MenuSelectStyle}
|
||||
onMenuClose={this.onMenuClose}
|
||||
autoFocus={this.props.autoFocus}
|
||||
menuShouldScrollIntoView
|
||||
/>
|
||||
}
|
||||
|
@@ -11,6 +11,7 @@ const propTypes = {
|
||||
repoID: PropTypes.string,
|
||||
isTextMode: PropTypes.bool.isRequired,
|
||||
isEditing: PropTypes.bool,
|
||||
autoFocus: PropTypes.bool,
|
||||
isEditIconShow: PropTypes.bool.isRequired,
|
||||
permissions: PropTypes.array.isRequired,
|
||||
currentPermission: PropTypes.string.isRequired,
|
||||
@@ -23,6 +24,7 @@ class SharePermissionEditor extends React.Component {
|
||||
|
||||
static defaultProps = {
|
||||
isEditing: false,
|
||||
autoFocus: false,
|
||||
}
|
||||
|
||||
constructor(props) {
|
||||
@@ -127,6 +129,7 @@ class SharePermissionEditor extends React.Component {
|
||||
isTextMode={this.props.isTextMode}
|
||||
isEditing={this.props.isEditing}
|
||||
isEditIconShow={this.props.isEditIconShow}
|
||||
autoFocus={this.props.autoFocus}
|
||||
options={this.getPermissions()}
|
||||
currentOption={this.props.currentPermission}
|
||||
onOptionChanged={this.props.onPermissionChanged}
|
||||
|
Reference in New Issue
Block a user