1
0
mirror of https://github.com/haiwen/seahub.git synced 2025-09-08 10:22:46 +00:00

optimize code (#5605)

This commit is contained in:
杨顺强
2023-08-24 12:10:05 +08:00
committed by GitHub
parent fb4525bef3
commit 68e53b3d45
10 changed files with 14 additions and 1 deletions

View File

@@ -50,6 +50,7 @@ class GroupItem extends React.Component {
<td> <td>
<SharePermissionEditor <SharePermissionEditor
isTextMode={true} isTextMode={true}
autoFocus={true}
isEditIconShow={this.state.isOperationShow} isEditIconShow={this.state.isOperationShow}
currentPermission={item.permission} currentPermission={item.permission}
permissions={this.props.permissions} permissions={this.props.permissions}

View File

@@ -51,6 +51,7 @@ class UserItem extends React.Component {
<td> <td>
<SharePermissionEditor <SharePermissionEditor
isTextMode={true} isTextMode={true}
autoFocus={true}
isEditIconShow={this.state.isOperationShow} isEditIconShow={this.state.isOperationShow}
currentPermission={currentPermission} currentPermission={currentPermission}
permissions={this.props.permissions} permissions={this.props.permissions}

View File

@@ -45,6 +45,7 @@ class GroupItem extends React.Component {
<SharePermissionEditor <SharePermissionEditor
repoID={this.props.repoID} repoID={this.props.repoID}
isTextMode={true} isTextMode={true}
autoFocus={true}
isEditIconShow={this.state.isOperationShow} isEditIconShow={this.state.isOperationShow}
currentPermission={currentPermission} currentPermission={currentPermission}
permissions={this.props.permissions} permissions={this.props.permissions}

View File

@@ -81,6 +81,7 @@ class UserItem extends React.Component {
<SharePermissionEditor <SharePermissionEditor
repoID={this.props.repoID} repoID={this.props.repoID}
isTextMode={true} isTextMode={true}
autoFocus={true}
isEditIconShow={this.state.isOperationShow} isEditIconShow={this.state.isOperationShow}
currentPermission={currentPermission} currentPermission={currentPermission}
permissions={this.props.permissions} permissions={this.props.permissions}

View File

@@ -45,6 +45,7 @@ class GroupItem extends React.Component {
<SharePermissionEditor <SharePermissionEditor
repoID={item.repo_id} repoID={item.repo_id}
isTextMode={true} isTextMode={true}
autoFocus={true}
isEditIconShow={this.state.isOperationShow} isEditIconShow={this.state.isOperationShow}
currentPermission={currentPermission} currentPermission={currentPermission}
permissions={this.props.permissions} permissions={this.props.permissions}

View File

@@ -45,6 +45,7 @@ class UserItem extends React.Component {
<SharePermissionEditor <SharePermissionEditor
repoID={item.repo_id} repoID={item.repo_id}
isTextMode={true} isTextMode={true}
autoFocus={true}
isEditIconShow={this.state.isOperationShow} isEditIconShow={this.state.isOperationShow}
currentPermission={currentPermission} currentPermission={currentPermission}
permissions={this.props.permissions} permissions={this.props.permissions}

View File

@@ -8,6 +8,7 @@ const propTypes = {
isTextMode: PropTypes.bool.isRequired, // there will be two mode. first: text and select. second: just select isTextMode: PropTypes.bool.isRequired, // there will be two mode. first: text and select. second: just select
isEditing: PropTypes.bool, isEditing: PropTypes.bool,
isEditIconShow: PropTypes.bool.isRequired, isEditIconShow: PropTypes.bool.isRequired,
autoFocus: PropTypes.bool,
options: PropTypes.array.isRequired, options: PropTypes.array.isRequired,
currentOption: PropTypes.string.isRequired, currentOption: PropTypes.string.isRequired,
translateOption: PropTypes.func.isRequired, translateOption: PropTypes.func.isRequired,
@@ -16,7 +17,6 @@ const propTypes = {
toggleItemFreezed: PropTypes.func, toggleItemFreezed: PropTypes.func,
enableAddCustomPermission: PropTypes.bool, enableAddCustomPermission: PropTypes.bool,
onAddCustomPermissionToggle: PropTypes.func, onAddCustomPermissionToggle: PropTypes.func,
}; };
class SelectEditor extends React.Component { class SelectEditor extends React.Component {
@@ -24,6 +24,7 @@ class SelectEditor extends React.Component {
static defaultProps = { static defaultProps = {
enableAddCustomPermission: false, enableAddCustomPermission: false,
isEditing: false, isEditing: false,
autoFocus: false,
} }
constructor(props) { constructor(props) {
@@ -145,6 +146,7 @@ class SelectEditor extends React.Component {
menuPortalTarget={document.querySelector('#wrapper')} menuPortalTarget={document.querySelector('#wrapper')}
styles={MenuSelectStyle} styles={MenuSelectStyle}
onMenuClose={this.onMenuClose} onMenuClose={this.onMenuClose}
autoFocus={this.props.autoFocus}
menuShouldScrollIntoView menuShouldScrollIntoView
/> />
} }

View File

@@ -11,6 +11,7 @@ const propTypes = {
repoID: PropTypes.string, repoID: PropTypes.string,
isTextMode: PropTypes.bool.isRequired, isTextMode: PropTypes.bool.isRequired,
isEditing: PropTypes.bool, isEditing: PropTypes.bool,
autoFocus: PropTypes.bool,
isEditIconShow: PropTypes.bool.isRequired, isEditIconShow: PropTypes.bool.isRequired,
permissions: PropTypes.array.isRequired, permissions: PropTypes.array.isRequired,
currentPermission: PropTypes.string.isRequired, currentPermission: PropTypes.string.isRequired,
@@ -23,6 +24,7 @@ class SharePermissionEditor extends React.Component {
static defaultProps = { static defaultProps = {
isEditing: false, isEditing: false,
autoFocus: false,
} }
constructor(props) { constructor(props) {
@@ -127,6 +129,7 @@ class SharePermissionEditor extends React.Component {
isTextMode={this.props.isTextMode} isTextMode={this.props.isTextMode}
isEditing={this.props.isEditing} isEditing={this.props.isEditing}
isEditIconShow={this.props.isEditIconShow} isEditIconShow={this.props.isEditIconShow}
autoFocus={this.props.autoFocus}
options={this.getPermissions()} options={this.getPermissions()}
currentOption={this.props.currentPermission} currentOption={this.props.currentPermission}
onOptionChanged={this.props.onPermissionChanged} onOptionChanged={this.props.onPermissionChanged}

View File

@@ -228,6 +228,7 @@ class Item extends Component {
isTextMode={true} isTextMode={true}
isEditIconShow={isOpIconShown} isEditIconShow={isOpIconShown}
isEditing={true} isEditing={true}
autoFocus={true}
currentPermission={share_permission} currentPermission={share_permission}
permissions={this.permissions} permissions={this.permissions}
onPermissionChanged={this.changePerm} onPermissionChanged={this.changePerm}

View File

@@ -241,6 +241,7 @@ class Item extends Component {
repoID={item.repo_id} repoID={item.repo_id}
isTextMode={true} isTextMode={true}
isEditing={true} isEditing={true}
autoFocus={true}
isEditIconShow={this.state.isOpIconShown} isEditIconShow={this.state.isOpIconShown}
currentPermission={share_permission} currentPermission={share_permission}
permissions={this.permissions} permissions={this.permissions}