From 7f56426ad8f8c6e0abfb7e36319ee5b73f4b4577 Mon Sep 17 00:00:00 2001
From: Michael An <2331806369@qq.com>
Date: Sat, 14 Sep 2024 15:29:26 +0800
Subject: [PATCH] fix deselect markdown file detail (#6780)
---
.../components/dir-view-mode/dir-column-view.js | 1 -
.../dirent-grid-view/dirent-grid-item.js | 15 ++-------------
.../pages/lib-content-view/lib-content-view.js | 10 +++-------
frontend/src/utils/utils.js | 2 +-
4 files changed, 6 insertions(+), 22 deletions(-)
diff --git a/frontend/src/components/dir-view-mode/dir-column-view.js b/frontend/src/components/dir-view-mode/dir-column-view.js
index d16eb763cc..5afdf4367b 100644
--- a/frontend/src/components/dir-view-mode/dir-column-view.js
+++ b/frontend/src/components/dir-view-mode/dir-column-view.js
@@ -26,7 +26,6 @@ const propTypes = {
isTreeDataLoading: PropTypes.bool.isRequired,
treeData: PropTypes.object.isRequired,
currentNode: PropTypes.object,
- currentDirent: PropTypes.object,
onNodeClick: PropTypes.func.isRequired,
onNodeCollapse: PropTypes.func.isRequired,
onNodeExpanded: PropTypes.func.isRequired,
diff --git a/frontend/src/components/dirent-grid-view/dirent-grid-item.js b/frontend/src/components/dirent-grid-view/dirent-grid-item.js
index f1e1c0c06f..146197b661 100644
--- a/frontend/src/components/dirent-grid-view/dirent-grid-item.js
+++ b/frontend/src/components/dirent-grid-view/dirent-grid-item.js
@@ -183,18 +183,8 @@ class DirentGridItem extends React.Component {
this.props.onGridItemMouseDown(event);
};
- getFileUrl = (url) => {
- let fileUrlArr = url.split('/');
- if (fileUrlArr.indexOf('48') !== -1) {
- fileUrlArr.splice(fileUrlArr.indexOf('48'), 1, '192');
- }
- let fileUrl = fileUrlArr.join('/');
- return fileUrl;
- };
-
onGridItemContextMenu = (event) => {
- let dirent = this.props.dirent;
- this.props.onGridItemContextMenu(event, dirent);
+ this.props.onGridItemContextMenu(event, this.props.dirent);
};
getTextRenderWidth = (text, font) => {
@@ -245,7 +235,6 @@ class DirentGridItem extends React.Component {
let { dirent, path, repoID } = this.props;
let direntPath = Utils.joinPath(path, dirent.name);
let iconUrl = Utils.getDirentIcon(dirent, true);
- let fileUrl = dirent.encoded_thumbnail_src ? this.getFileUrl(dirent.encoded_thumbnail_src) : '';
let toolTipID = '';
let tagTitle = '';
@@ -289,7 +278,7 @@ class DirentGridItem extends React.Component {
onDrop={this.onGridItemDragDrop}
>
{(this.canPreview && dirent.encoded_thumbnail_src) ?
-
:
+
:
}
{dirent.is_locked &&
}
diff --git a/frontend/src/pages/lib-content-view/lib-content-view.js b/frontend/src/pages/lib-content-view/lib-content-view.js
index 44d28c5ed8..e0bf79757d 100644
--- a/frontend/src/pages/lib-content-view/lib-content-view.js
+++ b/frontend/src/pages/lib-content-view/lib-content-view.js
@@ -93,7 +93,7 @@ class LibContentView extends React.Component {
asyncOperationProgress: 0,
asyncOperatedFilesLength: 0,
viewId: '0000',
- currentDirent: {}
+ currentDirent: null,
};
this.oldonpopstate = window.onpopstate;
@@ -1914,10 +1914,7 @@ class LibContentView extends React.Component {
};
onCloseMarkdownViewDialog = () => {
- this.setState({
- isViewFile: false,
- currentDirent: {},
- });
+ this.setState({ isViewFile: false });
};
onTreeNodeCollapse = (node) => {
@@ -2193,7 +2190,7 @@ class LibContentView extends React.Component {
};
render() {
- let { currentRepoInfo, userPerm, isCopyMoveProgressDialogShow, isDeleteFolderDialogOpen, currentDirent,
+ let { currentRepoInfo, userPerm, isCopyMoveProgressDialogShow, isDeleteFolderDialogOpen,
path, usedRepoTags } = this.state;
if (this.state.libNeedDecrypt) {
return (
@@ -2358,7 +2355,6 @@ class LibContentView extends React.Component {
isSidePanelFolded={this.props.isSidePanelFolded}
isTreePanelShown={this.state.isTreePanelShown}
currentMode={this.state.currentMode}
- currentDirent={currentDirent}
path={this.state.path}
repoID={this.props.repoID}
currentRepoInfo={this.state.currentRepoInfo}
diff --git a/frontend/src/utils/utils.js b/frontend/src/utils/utils.js
index 5c931d1bd7..e5d83bbc8d 100644
--- a/frontend/src/utils/utils.js
+++ b/frontend/src/utils/utils.js
@@ -396,7 +396,7 @@ export const Utils = {
},
getDirentIcon: function (dirent, isBig) {
- if (!dirent) return mediaUrl + 'img/file/256/' + Utils.FILEEXT_ICON_MAP['default'];
+ if (!dirent) return '';
let size = Utils.isHiDPI() ? 48 : 24;
size = isBig ? 192 : size;
if (dirent.isDir()) {