1
0
mirror of https://github.com/haiwen/seahub.git synced 2025-09-07 01:41:39 +00:00

Merge pull request #3326 from haiwen/update_txt_file_save_mechanism

Update txt file save mechanism
This commit is contained in:
Daniel Pan
2019-04-19 18:42:51 +08:00
committed by GitHub
3 changed files with 101 additions and 17 deletions

View File

@@ -10,6 +10,9 @@ import ShareDialog from '../dialog/share-dialog';
const propTypes = { const propTypes = {
isLocked: PropTypes.bool.isRequired, isLocked: PropTypes.bool.isRequired,
lockedByMe: PropTypes.bool.isRequired, lockedByMe: PropTypes.bool.isRequired,
onSaveChangedContent: PropTypes.func.isRequired,
isSaving: PropTypes.bool.isRequired,
isContentChangedButNotSaved: PropTypes.bool.isRequired,
toggleLockFile: PropTypes.func.isRequired, toggleLockFile: PropTypes.func.isRequired,
toggleCommentPanel: PropTypes.func.isRequired toggleCommentPanel: PropTypes.func.isRequired
}; };
@@ -45,7 +48,6 @@ class FileToolbar extends React.Component {
render() { render() {
const { isLocked, lockedByMe } = this.props; const { isLocked, lockedByMe } = this.props;
let showLockUnlockBtn = false; let showLockUnlockBtn = false;
let lockUnlockText, lockUnlockIcon; let lockUnlockText, lockUnlockIcon;
if (canLockUnlockFile) { if (canLockUnlockFile) {
@@ -101,15 +103,25 @@ class FileToolbar extends React.Component {
href={`${siteRoot}repo/file_revisions/${repoID}/?p=${encodeURIComponent(filePath)}&referer=${encodeURIComponent(location.href)}`} href={`${siteRoot}repo/file_revisions/${repoID}/?p=${encodeURIComponent(filePath)}&referer=${encodeURIComponent(location.href)}`}
/> />
)} )}
{(canEditFile && !err) && ( {(canEditFile && !err) &&
<IconButton ( this.props.isSaving ?
id="edit" <button type={'button'} className={'btn btn-icon btn-secondary btn-active'}>
icon="fa fa-edit" <i className={'fa fa-spin fa-spinner'}/></button> :
text={gettext('Edit')} (
tag="a" this.props.isContentChangedButNotSaved ?
href={`${siteRoot}repo/${repoID}/file/edit/?p=${encodeURIComponent(filePath)}&file_enc=${encodeURIComponent(fileEnc)}`} <IconButton
/> text={gettext('Save')}
)} id={'saveButton'}
icon={'fa fa-save'}
// button imported in this file does not have functionalities of
// isActive as button imported in markdowneditor has
//isActive={!isContentChanged}
onClick={this.props.onSaveChangedContent}
/> :
<button type={'button'} className={'btn btn-icon btn-secondary btn-active'} disabled>
<i className={'fa fa-save'}/></button>
)
)}
{canDownloadFile && ( {canDownloadFile && (
<IconButton <IconButton
id="download-file" id="download-file"

View File

@@ -10,13 +10,17 @@ import CommentPanel from './comment-panel';
import '../../css/file-view.css'; import '../../css/file-view.css';
const propTypes = { const propTypes = {
content: PropTypes.object.isRequired onSaveChangedContent: PropTypes.func.isRequired,
content: PropTypes.object.isRequired,
isSaving: PropTypes.bool.isRequired,
isContentChangedButNotSaved: PropTypes.bool.isRequired,
}; };
const { isStarred, isLocked, lockedByMe, const { isStarred, isLocked, lockedByMe,
repoID, filePath, enableWatermark, userNickName repoID, filePath, enableWatermark, userNickName
} = window.app.pageOptions; } = window.app.pageOptions;
class FileView extends React.Component { class FileView extends React.Component {
constructor(props) { constructor(props) {
@@ -25,7 +29,7 @@ class FileView extends React.Component {
isStarred: isStarred, isStarred: isStarred,
isLocked: isLocked, isLocked: isLocked,
lockedByMe: lockedByMe, lockedByMe: lockedByMe,
isCommentPanelOpen: false isCommentPanelOpen: false,
}; };
} }
@@ -81,6 +85,9 @@ class FileView extends React.Component {
<FileToolbar <FileToolbar
isLocked={this.state.isLocked} isLocked={this.state.isLocked}
lockedByMe={this.state.lockedByMe} lockedByMe={this.state.lockedByMe}
onSaveChangedContent={this.props.onSaveChangedContent}
isSaving={this.props.isSaving}
isContentChangedButNotSaved={this.props.isContentChangedButNotSaved}
toggleLockFile={this.toggleLockFile} toggleLockFile={this.toggleLockFile}
toggleCommentPanel={this.toggleCommentPanel} toggleCommentPanel={this.toggleCommentPanel}
/> />

View File

@@ -1,8 +1,12 @@
import React from 'react'; import React from 'react';
import ReactDOM from 'react-dom'; import ReactDOM from 'react-dom';
import PropTypes from 'prop-types';
import toaster from './components/toast';
import { Utils } from './utils/utils'; import { Utils } from './utils/utils';
import { gettext } from './utils/constants';
import FileView from './components/file-view/file-view'; import FileView from './components/file-view/file-view';
import FileViewTip from './components/file-view/file-view-tip'; import FileViewTip from './components/file-view/file-view-tip';
import { seafileAPI } from './utils/seafile-api';
import CodeMirror from 'react-codemirror'; import CodeMirror from 'react-codemirror';
import 'codemirror/mode/javascript/javascript'; import 'codemirror/mode/javascript/javascript';
@@ -20,7 +24,7 @@ import 'codemirror/lib/codemirror.css';
import './css/text-file-view.css'; import './css/text-file-view.css';
const { const {
err, fileExt, fileContent err, fileExt, fileContent, repoID, filePath, fileName
} = window.app.pageOptions; } = window.app.pageOptions;
const options = { const options = {
@@ -30,18 +34,76 @@ const options = {
theme: 'default', theme: 'default',
textWrapping: true, textWrapping: true,
lineWrapping: true, lineWrapping: true,
readOnly: true, readOnly: false, // set false to let user edit directly
cursorBlinkRate: -1 // hide the cursor
}; };
class ViewFileText extends React.Component { class ViewFileText extends React.Component {
constructor(props) {
super(props);
this.state = {
content: fileContent,
isContentChangedButNotSaved: false,
isSaving: false,
};
this.onSaveChangedContent=this.onSaveChangedContent.bind(this);
}
updateContent = (newContent) => {
this.setState({
isContentChangedButNotSaved: true,
content: newContent,
});
}
onSaveChangedContent () {
let dirPath = '/';
return (
seafileAPI.getUpdateLink(repoID, dirPath).then((res) => {
const uploadLink = res.data;
this.setState({
isSaving: true
});
return seafileAPI.updateFile(
uploadLink,
filePath,
fileName,
this.state.content
).then(() => {
toaster.success(gettext('Successfully saved'), {
duration: 3
});
this.setState({
isSaving: false,
isContentChangedButNotSaved: false
});
});
})
);
}
render() { render() {
return ( return (
<FileView content={<FileContent />} /> <FileView
content={
<FileContent
content={this.state.content}
updateContent={this.updateContent}
/>
}
isSaving={this.state.isSaving}
isContentChangedButNotSaved={this.state.isContentChangedButNotSaved}
onSaveChangedContent={this.onSaveChangedContent}
/>
); );
} }
} }
const propTypes = {
updateContent: PropTypes.func.isRequired,
content: PropTypes.string.isRequired,
};
class FileContent extends React.Component { class FileContent extends React.Component {
render() { render() {
if (err) { if (err) {
@@ -51,14 +113,17 @@ class FileContent extends React.Component {
<div className="file-view-content flex-1 text-file-view"> <div className="file-view-content flex-1 text-file-view">
<CodeMirror <CodeMirror
ref="code-mirror-editor" ref="code-mirror-editor"
value={fileContent} value={this.props.content}
options={options} options={options}
onChange={this.props.updateContent}
/> />
</div> </div>
); );
} }
} }
FileContent.propTypes = propTypes;
ReactDOM.render ( ReactDOM.render (
<ViewFileText />, <ViewFileText />,
document.getElementById('wrapper') document.getElementById('wrapper')