From 9dc68b75d0dc8fafe1a1b7ad49b117be19dd4245 Mon Sep 17 00:00:00 2001 From: zming <517046497@qq.com> Date: Wed, 16 Aug 2017 17:55:52 +0800 Subject: [PATCH] [api] fix share to all groups test --- tests/api/endpoints/test_all_groups.py | 22 +++++++++------------- 1 file changed, 9 insertions(+), 13 deletions(-) diff --git a/tests/api/endpoints/test_all_groups.py b/tests/api/endpoints/test_all_groups.py index 695ee4a05c..c5a62ef26c 100644 --- a/tests/api/endpoints/test_all_groups.py +++ b/tests/api/endpoints/test_all_groups.py @@ -3,16 +3,15 @@ import json from django.core.urlresolvers import reverse -from django.test import override_settings from seahub.test_utils import BaseTestCase +from constance import config + class GroupsShareTest(BaseTestCase): - - @override_settings(ENABLE_SHARE_TO_ALL_GROUPS=True) def test_can_get(self): - self.logout() + config.ENABLE_SHARE_TO_ALL_GROUPS = 1 self.login_as(self.admin) self.admin_group = self.create_group(group_name='test_group', username=self.admin.username) @@ -22,16 +21,13 @@ class GroupsShareTest(BaseTestCase): json.loads(self.client.get(reverse('api-v2.1-all-groups')).content)] self.assertIn('test_group', resp) - def tearDown(self): - self.remove_group(self.admin_group.id) - - @override_settings(ENABLE_SHARE_TO_ALL_GROUPS=True) def test_can_get_with_disable_config(self): - self.logout() self.login_as(self.admin) self.admin_group = self.create_group(group_name='test_disable_config', username=self.admin.username) - self.logout() - self.login_as(self.user) - resp = self.client.get(reverse('api-v2.1-all-groups')) - self.assertEqual(200, resp.status_code) + resp = json.loads(self.client.get(reverse('api-v2.1-all-groups')).content) + self.assertEqual([], resp) + + def tearDown(self): + self.remove_group(self.admin_group.id) +