diff --git a/frontend/src/components/dialog/generate-share-link.js b/frontend/src/components/dialog/generate-share-link.js index 3303c8b8c5..c37b433424 100644 --- a/frontend/src/components/dialog/generate-share-link.js +++ b/frontend/src/components/dialog/generate-share-link.js @@ -143,7 +143,7 @@ class GenerateShareLink extends React.Component { password: '', passwordnew: '', isShowPasswordInput: false, - expireDays: '', + expireDays: shareLinkExpireDaysDefault, isExpireChecked: false, errorInfo: '', sharedLinkInfo: null, @@ -192,8 +192,7 @@ class GenerateShareLink extends React.Component { this.setState({errorInfo: 'Please enter days'}); return false; } - let flag = reg.test(expireDays); - if (!flag) { + if (!reg.test(expireDays)) { this.setState({errorInfo: 'Please enter a non-negative integer'}); return false; } @@ -204,8 +203,7 @@ class GenerateShareLink extends React.Component { this.setState({errorInfo: 'Please enter days'}); return false; } - let flag = reg.test(expireDays); - if (!flag) { + if (!reg.test(expireDays)) { this.setState({errorInfo: 'Please enter a non-negative integer'}); return false; } @@ -229,7 +227,7 @@ class GenerateShareLink extends React.Component { } if (minDays !== 0 && maxDays !== 0) { - if (expireDays < minDays || expireDays < maxDays) { + if (expireDays < minDays || expireDays > maxDays) { this.setState({errorInfo: 'Please enter valid days'}); return false; } @@ -382,7 +380,6 @@ class GenerateShareLink extends React.Component { {this.state.isShowPasswordInput && - {/* todo translate */} {' '}{passwordLengthTip} @@ -396,35 +393,43 @@ class GenerateShareLink extends React.Component { } {this.isExpireDaysNoLimit && ( - - - + + + + + {this.state.isExpireChecked && + + + + } + )} - {this.state.isExpireChecked && - - - - } {!this.isExpireDaysNoLimit && ( - - - + + + + + + + + )}