From bbd4f15cca5e110bc075cba8ff4d303818b60e84 Mon Sep 17 00:00:00 2001
From: Michael An <2331806369@qq.com>
Date: Thu, 27 Feb 2025 15:13:58 +0800
Subject: [PATCH] 13.0-fix click user notification tab (#7528)

---
 frontend/src/user-notifications.js | 22 ++++++++++++++++------
 1 file changed, 16 insertions(+), 6 deletions(-)

diff --git a/frontend/src/user-notifications.js b/frontend/src/user-notifications.js
index 90279dc97e..048a8afb71 100644
--- a/frontend/src/user-notifications.js
+++ b/frontend/src/user-notifications.js
@@ -155,8 +155,8 @@ class UserNotificationsDialog extends React.Component {
     this.props.onNotificationDialogToggle();
   };
 
-  tabItemClick = (e) => {
-    let tab = e.target.getAttribute('value');
+  tabItemClick = (tab) => {
+    if (tab === this.state.activeTab) return;
     this.setState({
       activeTab: tab,
       currentPage: 1
@@ -217,15 +217,25 @@ class UserNotificationsDialog extends React.Component {
         <div className="notice-dialog-side">
           <Nav pills className="flex-column w-100">
             <NavItem className="w-100" role="tab" aria-selected={activeTab === 'general'} aria-controls="general-notice-panel">
-              <NavLink className={classname('w-100', 'mr-0', { 'active': activeTab === 'general' })} onClick={this.tabItemClick} tabIndex="0" value="general">
+              <NavLink
+                className={classname('w-100 mr-0', { 'active': activeTab === 'general' })}
+                onClick={() => this.tabItemClick('general')}
+                tabIndex="0"
+                value="general"
+              >
                 {gettext('General')}
-                {generalNoticeListUnseen > 0 && <span>({generalNoticeListUnseen})</span>}
+                {generalNoticeListUnseen > 0 && <span className="pl-1">({generalNoticeListUnseen})</span>}
               </NavLink>
             </NavItem>
             <NavItem className="w-100" role="tab" aria-selected={activeTab === 'discussion'} aria-controls="discussion-notice-panel">
-              <NavLink className={classname('w-100', 'mr-0', { 'active': activeTab === 'discussion' })} onClick={this.tabItemClick} tabIndex="1" value="discussion">
+              <NavLink
+                className={classname('w-100 mr-0', { 'active': activeTab === 'discussion' })}
+                onClick={() => this.tabItemClick('discussion')}
+                tabIndex="1"
+                value="discussion"
+              >
                 {gettext('Discussion')}
-                {discussionNoticeListUnseen > 0 && <span>({discussionNoticeListUnseen})</span>}
+                {discussionNoticeListUnseen > 0 && <span className="pl-1">({discussionNoticeListUnseen})</span>}
               </NavLink>
             </NavItem>
           </Nav>