From ae59d7bd2dcacb1bbfe069b23c631ab53c4a380d Mon Sep 17 00:00:00 2001 From: er-pai-r <18335219360@163.com> Date: Sat, 4 Nov 2023 11:38:56 +0800 Subject: [PATCH 1/2] feat: sdoc comment avatar size use default --- seahub/seadoc/apis.py | 33 +++++++++++++++++---------------- 1 file changed, 17 insertions(+), 16 deletions(-) diff --git a/seahub/seadoc/apis.py b/seahub/seadoc/apis.py index 5aa94d9260..4cd3890496 100644 --- a/seahub/seadoc/apis.py +++ b/seahub/seadoc/apis.py @@ -49,6 +49,7 @@ from seahub.constants import PERMISSION_READ_WRITE, PERMISSION_INVISIBLE from seahub.seadoc.sdoc_server_api import SdocServerAPI from seahub.file_participants.models import FileParticipant from seahub.base.accounts import User +from seahub.avatar.settings import AVATAR_DEFAULT_SIZE logger = logging.getLogger(__name__) @@ -804,9 +805,9 @@ class SeadocCommentsView(APIView): return api_error(status.HTTP_403_FORBIDDEN, error_msg) try: - avatar_size = int(request.GET.get('avatar_size', 32)) + avatar_size = int(request.GET.get('avatar_size', AVATAR_DEFAULT_SIZE)) except ValueError: - avatar_size = 32 + avatar_size = AVATAR_DEFAULT_SIZE resolved = request.GET.get('resolved', None) if resolved not in ('true', 'false', None): @@ -856,9 +857,9 @@ class SeadocCommentsView(APIView): return api_error(status.HTTP_403_FORBIDDEN, error_msg) try: - avatar_size = int(request.GET.get('avatar_size', 32)) + avatar_size = int(request.GET.get('avatar_size', AVATAR_DEFAULT_SIZE)) except ValueError: - avatar_size = 32 + avatar_size = AVATAR_DEFAULT_SIZE comment = request.data.get('comment', '') detail = request.data.get('detail', '') @@ -889,9 +890,9 @@ class SeadocCommentView(APIView): return api_error(status.HTTP_403_FORBIDDEN, error_msg) try: - avatar_size = int(request.GET.get('avatar_size', 32)) + avatar_size = int(request.GET.get('avatar_size', AVATAR_DEFAULT_SIZE)) except ValueError: - avatar_size = 32 + avatar_size = AVATAR_DEFAULT_SIZE # resource check try: @@ -935,9 +936,9 @@ class SeadocCommentView(APIView): return api_error(status.HTTP_403_FORBIDDEN, error_msg) try: - avatar_size = int(request.GET.get('avatar_size', 32)) + avatar_size = int(request.GET.get('avatar_size', AVATAR_DEFAULT_SIZE)) except ValueError: - avatar_size = 32 + avatar_size = AVATAR_DEFAULT_SIZE # argument check resolved = request.data.get('resolved') @@ -989,9 +990,9 @@ class SeadocCommentRepliesView(APIView): return api_error(status.HTTP_403_FORBIDDEN, error_msg) try: - avatar_size = int(request.GET.get('avatar_size', 32)) + avatar_size = int(request.GET.get('avatar_size', AVATAR_DEFAULT_SIZE)) except ValueError: - avatar_size = 32 + avatar_size = AVATAR_DEFAULT_SIZE start = None end = None page = request.GET.get('page', '') @@ -1034,9 +1035,9 @@ class SeadocCommentRepliesView(APIView): return api_error(status.HTTP_403_FORBIDDEN, error_msg) try: - avatar_size = int(request.GET.get('avatar_size', 32)) + avatar_size = int(request.GET.get('avatar_size', AVATAR_DEFAULT_SIZE)) except ValueError: - avatar_size = 32 + avatar_size = AVATAR_DEFAULT_SIZE reply_content = request.data.get('reply', '') type_content = request.data.get('type', 'reply') author = request.data.get('author', '') @@ -1078,9 +1079,9 @@ class SeadocCommentReplyView(APIView): return api_error(status.HTTP_403_FORBIDDEN, error_msg) try: - avatar_size = int(request.GET.get('avatar_size', 32)) + avatar_size = int(request.GET.get('avatar_size', AVATAR_DEFAULT_SIZE)) except ValueError: - avatar_size = 32 + avatar_size = AVATAR_DEFAULT_SIZE # resource check file_comment = FileComment.objects.filter( @@ -1132,9 +1133,9 @@ class SeadocCommentReplyView(APIView): if reply_content is None: return api_error(status.HTTP_400_BAD_REQUEST, 'reply invalid.') try: - avatar_size = int(request.GET.get('avatar_size', 32)) + avatar_size = int(request.GET.get('avatar_size', AVATAR_DEFAULT_SIZE)) except ValueError: - avatar_size = 32 + avatar_size = AVATAR_DEFAULT_SIZE # resource check file_comment = FileComment.objects.filter( From 33c43ca8d8527677aa0b84c2b008a689eb3eb40b Mon Sep 17 00:00:00 2001 From: er-pai-r <18335219360@163.com> Date: Sat, 4 Nov 2023 11:40:49 +0800 Subject: [PATCH 2/2] feat: history --- seahub/seadoc/apis.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/seahub/seadoc/apis.py b/seahub/seadoc/apis.py index 4cd3890496..9343caed58 100644 --- a/seahub/seadoc/apis.py +++ b/seahub/seadoc/apis.py @@ -563,11 +563,11 @@ class SeadocHistory(APIView): commit_id = repo.head_cmmt_id try: - avatar_size = int(request.GET.get('avatar_size', 32)) + avatar_size = int(request.GET.get('avatar_size', AVATAR_DEFAULT_SIZE)) page = int(request.GET.get('page', 1)) per_page = int(request.GET.get('per_page', 25)) except ValueError: - avatar_size = 32 + avatar_size = AVATAR_DEFAULT_SIZE page = 1 per_page = 25