haiwen/seahub
1
0
Fork 0
mirror of https://github.com/haiwen/seahub.git synced 2025-09-01 23:20:51 +00:00
Code Issues Releases Wiki Activity

Merge pull request #1439 from haiwen/quota

Browse Source 
check quota when copy/move file/dir
This commit is contained in:
xiez
2017-01-04 12:04:52 +08:00
committed by GitHub
parent 65325da7de c7e1fc02d8
commit ce2c67bd83
1 changed files with 111 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

127
seahub/views/ajax.py
View File

@@ -581,47 +581,102 @@ def copy_move_common():
result = {} result = {}
content_type = 'application/json; charset=utf-8' content_type = 'application/json; charset=utf-8'
repo = get_repo(repo_id) # arguments check for src
if not repo:
result['error'] = _(u'Library does not exist.')
return HttpResponse(json.dumps(result), status=400,
content_type=content_type)
# arguments validation
path = request.GET.get('path') path = request.GET.get('path')
obj_name = request.GET.get('obj_name') obj_name = request.GET.get('obj_name')
dst_repo_id = request.POST.get('dst_repo') if not (path and obj_name):
dst_path = request.POST.get('dst_path')
if not (path and obj_name and dst_repo_id and dst_path):
result['error'] = _('Argument missing') result['error'] = _('Argument missing')
return HttpResponse(json.dumps(result), status=400, return HttpResponse(json.dumps(result), status=400,
content_type=content_type) content_type=content_type)
# resource check for src
repo = get_repo(repo_id)
if not repo:
result['error'] = _(u'Library does not exist.')
return HttpResponse(json.dumps(result), status=404,
content_type=content_type)
full_obj_path = posixpath.join(path, obj_name)
file_obj_id = seafile_api.get_file_id_by_path(repo_id, full_obj_path)
dir_obj_id = seafile_api.get_dir_id_by_path(repo_id, full_obj_path)
if not file_obj_id and not dir_obj_id:
result['error'] = _(u'"%s" does not exist.') % full_obj_path
return HttpResponse(json.dumps(result), status=404,
content_type=content_type)
# arguments chech for dst
dst_repo_id = request.POST.get('dst_repo')
dst_path = request.POST.get('dst_path')
if not (dst_repo_id and dst_path):
result['error'] = _('Argument missing')
return HttpResponse(json.dumps(result), status=400,
content_type=content_type)
# resource check for dst
dst_repo = seafile_api.get_repo(dst_repo_id)
if not dst_repo:
result['error'] = _(u'Library does not exist.')
return HttpResponse(json.dumps(result), status=404,
content_type=content_type)
# resource check for dst
# check file path # check file path
if len(dst_path + obj_name) > settings.MAX_PATH: if len(dst_path + obj_name) > settings.MAX_PATH:
result['error'] = _('Destination path is too long.') result['error'] = _('Destination path is too long.')
return HttpResponse(json.dumps(result), status=400, return HttpResponse(json.dumps(result), status=400,
content_type=content_type) content_type=content_type)
# resource check for dst
# return error when dst is the same as src # return error when dst is the same as src
if repo_id == dst_repo_id and path == dst_path: if repo_id == dst_repo_id and path == dst_path:
result['error'] = _('Invalid destination path') result['error'] = _('Invalid destination path')
return HttpResponse(json.dumps(result), status=400, return HttpResponse(json.dumps(result), status=400,
content_type=content_type) content_type=content_type)
# permission check for dst
# check whether user has write permission to dest repo # check whether user has write permission to dest repo
# Leave src folder/file permission checking to corresponding views.
# For 'move', check has read-write perm to src folder;
# For 'cp', check has read perm to src folder.
if check_folder_permission(request, dst_repo_id, dst_path) != 'rw': if check_folder_permission(request, dst_repo_id, dst_path) != 'rw':
result['error'] = _('Permission denied') result['error'] = _('Permission denied')
return HttpResponse(json.dumps(result), status=403, return HttpResponse(json.dumps(result), status=403,
content_type=content_type) content_type=content_type)
# Leave src folder/file permission checking to corresponding # check quota for dst
# views. if file_obj_id:
# For 'move', check has read-write perm to src folder; obj_size = seafile_api.get_file_size(repo.store_id,
# For 'cp', check has read perm to src folder. repo.version, file_obj_id)
return view_method(request, repo_id, path, dst_repo_id, dst_path, if dir_obj_id:
obj_name) obj_size = seafile_api.get_dir_size(repo.store_id,
repo.version, dir_obj_id)
# check quota
out_of_quota = False
try:
if seafile_api.is_repo_owner(request.user.username, dst_repo_id):
# if dst repo is my own repo, only check quota when copy.
if view_method.__name__ in ('cp_file', 'cp_dir'):
out_of_quota = seafile_api.check_quota(dst_repo_id, delta=obj_size)
else:
# if dst repo is NOT my own repo,
# check quota when copy AND move.
out_of_quota = seafile_api.check_quota(dst_repo_id, delta=obj_size)
except Exception as e:
logger.error(e)
result['error'] = _(u'Internal server error')
return HttpResponse(json.dumps(result), status=500,
content_type=content_type)
if out_of_quota:
result['error'] = _('Out of quota.')
return HttpResponse(json.dumps(result), status=403,
content_type=content_type)
return view_method(request, repo_id, path,
dst_repo_id, dst_path, obj_name)
return _arguments_wrapper return _arguments_wrapper
@@ -682,6 +737,7 @@ def cp_file(request, src_repo_id, src_path, dst_repo_id, dst_path, obj_name):
dst_repo_id, dst_path, new_obj_name, dst_repo_id, dst_path, new_obj_name,
username, need_progress=1) username, need_progress=1)
except SearpcError as e: except SearpcError as e:
logger.error(e)
res = None res = None
if not res: if not res:
@@ -768,6 +824,7 @@ def cp_dir(request, src_repo_id, src_path, dst_repo_id, dst_path, obj_name):
dst_repo_id, dst_path, new_obj_name, dst_repo_id, dst_path, new_obj_name,
username, need_progress=1) username, need_progress=1)
except SearpcError, e: except SearpcError, e:
logger.error(e)
res = None res = None
# res can be None or an object # res can be None or an object
@@ -839,6 +896,44 @@ def dirents_copy_move_common():
# operation, 1), if move file, check parent dir perm, 2), if move # operation, 1), if move file, check parent dir perm, 2), if move
# folder, check that folder perm. # folder, check that folder perm.
file_obj_size = 0
for obj_name in obj_file_names:
full_obj_path = posixpath.join(parent_dir, obj_name)
file_obj_id = seafile_api.get_file_id_by_path(repo_id, full_obj_path)
file_obj_size += seafile_api.get_file_size(
repo.store_id, repo.version, file_obj_id)
dir_obj_size = 0
for obj_name in obj_dir_names:
full_obj_path = posixpath.join(parent_dir, obj_name)
dir_obj_id = seafile_api.get_dir_id_by_path(repo_id, full_obj_path)
dir_obj_size += seafile_api.get_dir_size(
repo.store_id, repo.version, dir_obj_id)
# check quota
out_of_quota = False
try:
if seafile_api.is_repo_owner(request.user.username, dst_repo_id):
# if dst repo is my own repo, only check quota when copy.
if view_method.__name__ == 'cp_dirents':
out_of_quota = seafile_api.check_quota(
dst_repo_id, delta=file_obj_size + dir_obj_size)
else:
# if dst repo is NOT my own repo,
# check quota when copy AND move.
out_of_quota = seafile_api.check_quota(
dst_repo_id, delta=file_obj_size + dir_obj_size)
except Exception as e:
logger.error(e)
result['error'] = _(u'Internal server error')
return HttpResponse(json.dumps(result), status=500,
content_type=content_type)
if out_of_quota:
result['error'] = _('Out of quota.')
return HttpResponse(json.dumps(result), status=403,
content_type=content_type)
return view_method(request, repo_id, parent_dir, dst_repo_id, return view_method(request, repo_id, parent_dir, dst_repo_id,
dst_path, obj_file_names, obj_dir_names) dst_path, obj_file_names, obj_dir_names)