[icons] modification

media/js/base.js

@@ -125,6 +125,8 @@ $(function() {
                 }
             });
         }
+
+        return false;
     });
 
     $('#my-info').click(function() {

seahub/share/templates/share/list_priv_shared_folders.html

@@ -25,7 +25,7 @@
         <td>
             <div class="share-permission">
                 <span class="share-permission-cur-value">{{ repo.share_permission }}</span>
-                <span title="{% trans "Edit"%}" class="share-permission-edit-icon sf2-icon-edit op-icon vh"></span>
+                <a href="#" title="{% trans "Edit"%}" class="share-permission-edit-icon sf2-icon-edit op-icon vh"></a>
             </div>
             <select name="permission" class="share-permission-select hide">
                 <option value="{{ repo.props.permission }}" selected="selected">{{ repo.share_permission }}</option>
@@ -66,6 +66,8 @@ addFormPost($('.unshare'));
 $('.share-permission-edit-icon').click(function() {
     $(this).parent().addClass('hide');
     $(this).parent().next().removeClass('hide'); // show 'share-permission-select'
+
+    return false;
 });
 $('.share-permission-select').change(function() {
     var select = $(this),

seahub/share/templates/share/repos.html

@@ -29,7 +29,7 @@
         <td>
             <div class="share-permission">
                 <span class="share-permission-cur-value">{{ repo.share_permission }}</span>
-                <span title="{% trans "Edit"%}" class="share-permission-edit-icon sf2-icon-edit op-icon vh"></span>
+                <a href="#" title="{% trans "Edit"%}" class="share-permission-edit-icon sf2-icon-edit op-icon vh"></a>
             </div>
             <select name="permission" class="share-permission-select hide">
                 <option value="{{ repo.props.permission }}" selected="selected">{{ repo.share_permission }}</option>
@@ -72,6 +72,8 @@ $('.share-permission-edit-icon').click(function() {
         perm_select = cur_perm.next();
     cur_perm.addClass('hide');
     perm_select.removeClass('hide'); // show 'share-permission-select'
+
+    return false;
 });
 $('.share-permission-select').change(function() {
     var select = $(this),

seahub/templates/base.html

@@ -59,7 +59,7 @@
                             <ul class="hide" id="notice-list" data-url="{% url 'set_notice_seen_by_id' %}"></ul>
                             <p class="alc"><a href="{% url 'user_notification_list' %}" class="all">{% trans "See All Notifications" %}</a></p>
                         </div>
-                        <span class="close sf2-icon-x1 op-icon" data-url="{% url 'set_notices_seen' %}" title="{% trans "Close" %}"></span>
+                        <a href="#" class="close sf2-icon-x1 op-icon" data-url="{% url 'set_notices_seen' %}" title="{% trans "Close" %}"></a>
                     </div>
                 </div>
 

seahub/templates/base_for_backbone.html

@@ -70,7 +70,7 @@
                             <ul class="hide" id="notice-list"></ul>
                             <p class="alc"><a href="{% url 'user_notification_list' %}" class="all">{% trans "See All Notifications" %}</a></p>
                         </div>
-                        <span class="close sf2-icon-x1 op-icon" title="{% trans "Close" %}"></span>
+                        <a href="#" class="close sf2-icon-x1 op-icon" title="{% trans "Close" %}"></a>
                     </div>
                 </div>
 

seahub/templates/js/templates.html

@@ -739,7 +739,7 @@
                 {% trans "Read-Only" %}
             <% } %>
             </span>
-            <span title="{% trans "Edit" %}" class="perm-edit-icon sf2-icon-edit op-icon vh"></span>
+            <a href="#" title="{% trans "Edit" %}" class="perm-edit-icon sf2-icon-edit op-icon vh"></a>
         </div>
         <select class="perm-toggle-select hide w100">
             <% if (perm == 'rw') { %>
@@ -752,7 +752,7 @@
         </select>
     </td>
     <td>
-        <span class="sf2-icon-delete delete-icon op-icon vh" title="{% trans "Delete" %}"></span>
+        <a href="#" class="sf2-icon-delete delete-icon op-icon vh" title="{% trans "Delete" %}"></a>
     </td>
 </script>
 <script type="text/template" id="folder-perm-popup-tmpl">
@@ -1206,7 +1206,7 @@
     <td><%= formattedSize %></td>
     <td><%= view_count %></td>
     <td>
-        <span class="sf2-icon-delete op-icon vh rm-link" title="{% trans "Remove"%}"></span>
+        <a href="#" class="sf2-icon-delete op-icon vh rm-link" title="{% trans "Remove"%}"></a>
     </td>
 </script>
 
@@ -1336,14 +1336,14 @@
     <td>
         <% if (permission == 'rw') { %>
             <span class="cur-perm">{% trans "Read-Write" %}</span>
-            <span title="{% trans "Edit" %}" class="edit-icon op-icon sf2-icon-edit vh"></span>
+            <a href="#" title="{% trans "Edit" %}" class="edit-icon op-icon sf2-icon-edit vh"></a>
             <select class="perm-toggle-select hide">
                 <option value="rw" selected="selected">{% trans "Read-Write" %}</option>
                 <option value="r">{% trans "Read-Only"%}</option>
             </select>
         <% } else { %>
             <span class="cur-perm">{% trans "Read-Only" %}</span>
-            <span title="{% trans "Edit" %}" class="edit-icon op-icon sf2-icon-edit vh"></span>
+            <a href="#" title="{% trans "Edit" %}" class="edit-icon op-icon sf2-icon-edit vh"></a>
             <select class="perm-toggle-select hide">
                 <option value="rw">{% trans "Read-Write" %}</option>
                 <option value="r" selected="selected">{% trans "Read-Only"%}</option>
@@ -1351,7 +1351,7 @@
         <% } %>
     </td>
     <td>
-        <span class="rm op-icon sf2-icon-delete vh" title="{% trans "Delete" %}"></span>
+        <a href="#" class="rm op-icon sf2-icon-delete vh" title="{% trans "Delete" %}"></a>
     </td>
 </script>
 

static/scripts/app/views/folder-perm-item.js

@@ -44,6 +44,8 @@ define([
             $(e.currentTarget).closest('td')
                 .find('.perm').addClass('hide').end()
                 .find('.perm-toggle-select').removeClass('hide');
+
+            return false;
         },
 
         editPerm: function (e) {
@@ -130,6 +132,8 @@ define([
                     }
                 }
             });
+
+            return false;
         }
 
     });

static/scripts/app/views/folder-share-item.js

@@ -44,6 +44,8 @@ define([
             $(e.currentTarget).closest('td')
                 .find('.perm').addClass('hide').end()
                 .find('.perm-toggle-select').removeClass('hide');
+
+            return false;
         },
 
         editPerm: function (e) {
@@ -121,6 +123,8 @@ define([
                     }
                 }
             });
+
+            return false;
         }
 
     });

static/scripts/app/views/repo-folder-perm.js

@@ -51,6 +51,8 @@ define([
             var $td = $(e.currentTarget).closest('td');
             $('.cur-perm, .edit-icon', $td).hide();
             $('.perm-toggle-select', $td).show();
+
+            return false;
         },
 
         edit: function(e) {
@@ -134,6 +136,8 @@ define([
                     _this.data.$error.html(err_msg).show();
                 }
             });
+
+            return false;
         }
 
     });

static/scripts/app/views/repo-shared-link.js

@@ -86,6 +86,8 @@ define([
                     _this.data.$error.html(err_msg).show();
                 }
             });
+
+            return false;
         }
 
     });

static/scripts/common.js

@@ -648,6 +648,8 @@ define([
                         }
                     });
                 }
+
+                return false;
             });
 
             $(document).click(function(e) {