From 44a6399086e394d583a8e8d2f410d3aba244b56d Mon Sep 17 00:00:00 2001
From: llj <lingjun.li1@gmail.com>
Date: Thu, 16 Nov 2017 15:45:44 +0800
Subject: [PATCH] [form] improved accessibility for form elements

---
 seahub/templates/js/lib-op-popups.html          |  2 +-
 seahub/templates/js/sysadmin-templates.html     |  6 +++---
 seahub/templates/js/templates.html              | 12 ++++++------
 seahub/templates/libraries.html                 |  2 +-
 seahub/templates/registration/login.html        |  4 ++--
 seahub/templates/snippets/file_share_popup.html |  2 +-
 seahub/templates/snippets/search_form.html      |  8 ++++----
 seahub/templates/view_file_base.html            |  2 +-
 8 files changed, 19 insertions(+), 19 deletions(-)

diff --git a/seahub/templates/js/lib-op-popups.html b/seahub/templates/js/lib-op-popups.html
index af22ce8ce7..c47675683f 100644
--- a/seahub/templates/js/lib-op-popups.html
+++ b/seahub/templates/js/lib-op-popups.html
@@ -105,7 +105,7 @@
         <img src="{{MEDIA_URL}}img/lock.png" alt="" aria-hidden="true" />
         <p class="intro" id="dialogTitle">{% trans "This library is password protected" %}</p>
         <p class="error hide"></p>
-        <input type="password" name="password" class="input" placeholder="{% trans "Password" %}" /><br />
+        <input type="password" name="password" class="input" placeholder="{% trans "Password" %}" title="{% trans "Password" %}" aria-label="{% trans "Password" %}" /><br />
         <button type="submit" class="submit">{% trans "Submit" %}</button>
         <p class="tip">{% trans '*The password will be kept in the server for only 1 hour.' %}</p>
     </form>
diff --git a/seahub/templates/js/sysadmin-templates.html b/seahub/templates/js/sysadmin-templates.html
index 9b4f74f68c..1a10cafcb9 100644
--- a/seahub/templates/js/sysadmin-templates.html
+++ b/seahub/templates/js/sysadmin-templates.html
@@ -105,18 +105,18 @@
     <% if (cur_tab == 'libraries') { %>
         <% if (option == 'all') { %>
             <form action="{% url 'sys_repo_search' %}" method="get" class="side-search-form" id="libs-search-form">
-                <input type="text" name="name" class="input" value="" placeholder="{% trans "Search libraries by name..." %}" />
+                <input type="text" name="name" class="input" value="" placeholder="{% trans "Search libraries by name..." %}" title="{% trans "Search libraries by name..." %}" aria-label="{% trans "Search libraries by name..." %}" />
             </form>
         <% } %>
         <% if (option == 'trash') { %>
             <form action="{% url 'sys_trash_repo_search' %}" method="get" class="side-search-form" id="trash-libs-search-form">
-                <input type="text" name="name" class="input" value="" placeholder="{% trans "Search libraries by owner..." %}" />
+                <input type="text" name="name" class="input" value="" placeholder="{% trans "Search libraries by owner..." %}" title="{% trans "Search libraries by owner..." %}" aria-label="{% trans "Search libraries by owner..." %}" />
             </form>
         <% } %>
     <% } %>
     <% if (cur_tab == 'groups') { %>
         <form action="{% url 'sys_group_search' %}" method="get" class="side-search-form" id="groups-search-form">
-            <input type="text" name="name" class="input" value="" placeholder="{% trans "Search groups by name..." %}" />
+            <input type="text" name="name" class="input" value="" placeholder="{% trans "Search groups by name..." %}" title="{% trans "Search groups by name..." %}" aria-label="{% trans "Search groups by name..." %}" />
         </form>
     <% } %>
 </script>
diff --git a/seahub/templates/js/templates.html b/seahub/templates/js/templates.html
index dd81d99552..276071388d 100644
--- a/seahub/templates/js/templates.html
+++ b/seahub/templates/js/templates.html
@@ -1064,7 +1064,7 @@
                     <button id="delete-download-link">{% trans 'Delete' %}</button>
                     <form id="send-download-link-form" action="" class="hide">
                         <label for="email">{% trans "Send to:"%}</label><br />
-                        <input type="text" class="input" name="email" placeholder="{% trans "Emails, separated by ','"%}" id="email" /><br />
+                        <input type="text" class="input" name="email" placeholder="{% trans "Emails, separated by ','"%}" title="{% trans "Emails, separated by ','"%}" id="email" /><br />
                         <label for="extra-msg">{% trans "Message (optional):"%}</label><br />
                         <textarea class="textarea" name="extra_msg" id="extra-msg"></textarea><br />
                         <p class="error hide"></p>
@@ -1112,7 +1112,7 @@
                     <button id="delete-upload-link">{% trans 'Delete' %}</button>
                     <form id="send-upload-link-form" action="" class="hide">
                         <label for="u-email">{% trans "Send to:"%}</label><br />
-                        <input type="text" class="input" name="email" placeholder="{% trans "Emails, separated by ','"%}" id="u-email" /><br />
+                        <input type="text" class="input" name="email" placeholder="{% trans "Emails, separated by ','"%}" title="{% trans "Emails, separated by ','"%}" id="u-email" /><br />
                         <label for="u-extra-msg">{% trans "Message (optional):"%}</label><br />
                         <textarea class="textarea" name="extra_msg" id="u-extra-msg"></textarea><br />
                         <p class="error hide"></p>
@@ -1720,11 +1720,11 @@
 </script>
 <script type="text/template" id="top-search-form-tmpl">
 <% if (search_repo_id) { %>
-    <input type="text" class="search-input" name="q" placeholder="{% if search_wiki %}{% trans "Search files in this wiki" %}{% else %}{% trans "Search files in this library" %}{% endif %}" value="{{ keyword }}" /> <input type="hidden" name="search_repo" value="<%= search_repo_id %>" />
+    <input type="text" class="search-input" name="q" placeholder="{% if search_wiki %}{% trans "Search files in this wiki" %}{% else %}{% trans "Search files in this library" %}{% endif %}" title="{% if search_wiki %}{% trans "Search files in this wiki" %}{% else %}{% trans "Search files in this library" %}{% endif %}" aria-label="{% if search_wiki %}{% trans "Search files in this wiki" %}{% else %}{% trans "Search files in this library" %}{% endif %}" value="{{ keyword }}" /> <input type="hidden" name="search_repo" value="<%= search_repo_id %>" />
 <% } else { %>
-    <input type="text" class="search-input" name="q" placeholder="{% trans 'Search Files' %}" value="{{ keyword }}" />
+    <input type="text" class="search-input" name="q" placeholder="{% trans "Search Files" %}" title="{% trans "Search Files" %}" aria-label="{% trans "Search Files" %}" value="{{ keyword }}" />
 <% } %>
-<!--span class="icon-caret-down" title="{% trans "advanced" %}"></span--><button type="submit" class="search-submit"><span class="icon-search"></span></button>
+<!--span class="icon-caret-down" title="{% trans "advanced" %}"></span--><button type="submit" class="search-submit" aria-label="{% trans "Submit" %}"><span class="icon-search"></span></button>
 </script>
 <script type="text/template" id="group-item-tmpl">
     <h4 class="group-name ellipsis"><a href="#group/<%= id %>/" title="<%- name %>" class="a normal"><%- name %></a></h4>
@@ -2520,7 +2520,7 @@
         <form action="" method="post" class="msg-form">
             <img src="{% avatar_url request.user 64 %}" alt="" width="32" class="avatar-circle fleft" />
             <div class="msg-body">
-                <textarea name="message" placeholder="{% trans "Add a comment..." %}" class="msg-input"></textarea>
+                <textarea name="message" placeholder="{% trans "Add a comment..." %}" title="{% trans "Add a comment..." %}" aria-label="{% trans "Add a comment..." %}" class="msg-input"></textarea>
                 <p class="error hide"></p>
                 <button type="submit" class="submit msg-submit">{% trans "Submit" %}</button>
             </div>
diff --git a/seahub/templates/libraries.html b/seahub/templates/libraries.html
index d5820b51a7..c9dfe1863c 100644
--- a/seahub/templates/libraries.html
+++ b/seahub/templates/libraries.html
@@ -182,7 +182,7 @@
         <form action="" method="post" class="msg-form">
             <img src="{% avatar_url request.user 64 %}" alt="" width="32" class="avatar-circle fleft" />
             <div class="msg-body">
-                <textarea name="message" placeholder="{% trans "Add a discussion..." %}" class="msg-input"></textarea>
+                <textarea name="message" placeholder="{% trans "Add a discussion..." %}" title="{% trans "Add a discussion..." %}" aria-label="{% trans "Add a discussion..." %}" class="msg-input"></textarea>
                 <button type="submit" class="submit msg-submit">{% trans "Submit" %}</button>
             </div>
         </form>
diff --git a/seahub/templates/registration/login.html b/seahub/templates/registration/login.html
index ac4caf6f94..6c0e7bb12f 100644
--- a/seahub/templates/registration/login.html
+++ b/seahub/templates/registration/login.html
@@ -32,8 +32,8 @@ html, body, #wrapper { height:100%; }
 <div class="login-panel">
     <h1 class="login-panel-hd">{% trans "Log In" %}</h1>
     <form action="" method="post">{% csrf_token %}
-        <input type="text" name="login" placeholder="{% trans "Email or Username" %}" value="" class="input name-input" /><br />
-        <input type="password" name="password" placeholder="{% trans "Password" %}" value="" class="input passwd-input" autocomplete="off" />
+        <input type="text" name="login" placeholder="{% trans "Email or Username" %}" aria-label="{% trans "Email or Username" %}" title="{% trans "Email or Username" %}" value="" class="input name-input" /><br />
+        <input type="password" name="password" placeholder="{% trans "Password" %}" aria-label="{% trans "Password" %}" title="{% trans "Password" %}" value="" class="input passwd-input" autocomplete="off" />
 
         {% if form.captcha %}
         <div class="ovhd">
diff --git a/seahub/templates/snippets/file_share_popup.html b/seahub/templates/snippets/file_share_popup.html
index e6965052ce..40b71432af 100644
--- a/seahub/templates/snippets/file_share_popup.html
+++ b/seahub/templates/snippets/file_share_popup.html
@@ -47,7 +47,7 @@
 
                     <form id="link-send-form" action="" method="post" class="hide">{% csrf_token %}
                         <label for="link-send-input">{% trans "Send to:"%}</label><br />
-                        <input type="text" class="input" id="link-send-input" name="email" placeholder="{% trans "Emails, separated by ','"%}" /><br />
+                        <input type="text" class="input" id="link-send-input" name="email" placeholder="{% trans "Emails, separated by ','"%}" title="{% trans "Emails, separated by ','"%}" /><br />
                         <input type="hidden" name="file_shared_link" value="{{ dir_shared_link }}" />
                         <input type="hidden" name="file_shared_name" value="" />
                         <input type="hidden" name="file_shared_type" value="" />
diff --git a/seahub/templates/snippets/search_form.html b/seahub/templates/snippets/search_form.html
index e9b0a8ff37..568db1338b 100644
--- a/seahub/templates/snippets/search_form.html
+++ b/seahub/templates/snippets/search_form.html
@@ -1,12 +1,12 @@
 {% load i18n %}
                 <form id="top-search-form" method="get" action="{% url 'search' %}" class="search-form fleft">
                     {% if search_repo_id %}
-                    <input type="text" class="search-input" name="q" placeholder="{% if search_wiki %}{% trans "Search files in this wiki" %}{% else %}{% trans "Search files in this library" %}{% endif %}" value="{{ keyword }}" />
+                    <input type="text" class="search-input" name="q" placeholder="{% if search_wiki %}{% trans "Search files in this wiki" %}{% else %}{% trans "Search files in this library" %}{% endif %}" title="{% if search_wiki %}{% trans "Search files in this wiki" %}{% else %}{% trans "Search files in this library" %}{% endif %}" aria-label="{% if search_wiki %}{% trans "Search files in this wiki" %}{% else %}{% trans "Search files in this library" %}{% endif %}" value="{{ keyword }}" />
                     <input type="hidden" name="search_repo" value="{{ search_repo_id }}" />
                     {% else %}
-                    <input type="text" class="search-input" name="q" placeholder="{% trans 'Search Files' %}" value="{{ keyword }}" />
+                    <input type="text" class="search-input" name="q" placeholder="{% trans "Search Files" %}" title="{% trans "Search Files" %}" aria-label="{% trans "Search Files" %}" value="{{ keyword }}" />
                     {% endif %}
-                    <!--span class="icon-caret-down" title="{% trans "advanced" %}"></span--><button type="submit" class="search-submit"><span class="icon-search"></span></button>
+                    <!--span class="icon-caret-down" title="{% trans "advanced" %}"></span--><button type="submit" class="search-submit" aria-label="{% trans "Submit" %}"><span class="icon-search"></span></button>
                 </form>
 
                 <form id="advanced-search-form" method="get" action="{% url 'search' %}" class="search-form hide">
@@ -69,7 +69,7 @@
                                 <span class="vam">{% trans "markdown" %}</span>
                             </label>
                             <br/>
-                            <input type="text" value="{{ input_fileexts }}" name="input_fexts" placeholder="{% trans "Input file extensions here, separate with ','" %}" class="fileext-input" />
+                            <input type="text" value="{{ input_fileexts }}" name="input_fexts" placeholder="{% trans "Input file extensions here, separate with ','" %}" title="{% trans "Input file extensions here, separate with ','" %}" aria-label="{% trans "Input file extensions here, separate with ','" %}" class="fileext-input" />
                             <p class="error hide">{% trans "Please select at least one file type or input at least one file extension" %}</p>
                         </div>
                     </div>
diff --git a/seahub/templates/view_file_base.html b/seahub/templates/view_file_base.html
index 26e5082ba3..c62552915f 100644
--- a/seahub/templates/view_file_base.html
+++ b/seahub/templates/view_file_base.html
@@ -127,7 +127,7 @@
         <form action="" method="post" class="msg-form">
             <img src="{% avatar_url request.user 64 %}" alt="" width="32" class="avatar-circle fleft" />
             <div class="msg-body">
-                <textarea name="message" placeholder="{% trans "Add a comment..." %}" class="msg-input"></textarea>
+                <textarea name="message" placeholder="{% trans "Add a comment..." %}" title="{% trans "Add a comment..." %}" aria-label="{% trans "Add a comment..." %}" class="msg-input"></textarea>
                 <p class="error hide"></p>
                 <button type="submit" class="submit msg-submit">{% trans "Submit" %}</button>
             </div>