From 24e287083180fbde2a5224d1f278c0ec164ebca4 Mon Sep 17 00:00:00 2001 From: Daniel Pan Date: Fri, 4 Mar 2016 16:40:45 +0800 Subject: [PATCH] Show 24px file icon for low DPI screen --- media/img/folder-192.png | Bin 0 -> 1531 bytes static/scripts/app/views/dirent.js | 3 ++- static/scripts/common.js | 23 ++++++++++++++++++++--- 3 files changed, 22 insertions(+), 4 deletions(-) create mode 100644 media/img/folder-192.png diff --git a/media/img/folder-192.png b/media/img/folder-192.png new file mode 100644 index 0000000000000000000000000000000000000000..a7cca733a062eca51bd0f25390ffc0147ec26446 GIT binary patch literal 1531 zcmXw12~<;85KRcH2n0b0P)v?mWl>2HM5`!~gryc5N#a&&qg6x&v4R1b1pdbq>OwU| zE72l~0vbh;B@(hBheHd8Vk=0sk$_D^4F=cE3boFm`_Q&zUrEv?vgh00eG7Yh5+>NfiS>gYUKf^84e9PK^E*(g___1Q8Tn5sjWUb4)ojRW&+o0 zLmH%9P}!_PjsIgTO1@bEdxT|eZGv1gxLF1IX{wJGxb?=Ilw<}5S@9vWdgn)pcV&_P zU{9_du{#~3$BFQtEQ>qQJm#>Wk}`Zg&*bE2cX?*OU@YKf5xSbx~PNhy}P;;MpurX@KA6M zcM)?jYTy5Nz|u$0sNaWQ)Hr({XI0c|PwkFYm419Lh`;JxnK)tKvSrJ;26E?~ui8fg zkLJ$*Qxcj~Je2=)&6>SqnoEztKdwonQkZ$zm-ig72pNMRr@ntvZO0k%zo88U&B1lC z@W5{&U zgg>3DK|U)F(KFiv=njmeiY-|&Np%$i4;VFA4H8$rNFO1?ZDVf>?i(0$dtM)3RaF-5 zVsy;8o5QI6HSiDDzIf5-uv^ghokpyFb}O!!T^zhTMem+oUMuT(X_NOxF%t$@t`(a!n+U>)^<`Y;R!>^jH??} zU+BYW?}kgxX1oe#of|IMobf7z*0BFcNnR@FcW>JESiGzER(>EwP7!XhH!Wg`@f`$O z?@yi`OK6()_$-EQ(w-uZ73O+U&Cawro*i88eBusXj4;%bYAETy`XU}r+^G9TU~-|Y zrQyAv^-s*+!All~;XBXvw**n}U)QB*_X|vJk(*RB!q7%7S75@?3aEs2!C?&^q<4Gv zO%{=NR{K73GKNML#1cGG>DpX@a6_r1{h_&$(=jC1jsAxxu1Bx*fj=ujmlb`C|G)*> YV37_Yy5jSbx@>qzq$N{tu4fnh3m3yRm;e9( literal 0 HcmV?d00001 diff --git a/static/scripts/app/views/dirent.js b/static/scripts/app/views/dirent.js index 73128f8b3b..fecf79f608 100644 --- a/static/scripts/app/views/dirent.js +++ b/static/scripts/app/views/dirent.js @@ -35,12 +35,13 @@ define([ var dirent_path = Common.pathJoin([dir.path, this.model.get('obj_name')]); var is_pro = app.pageOptions.is_pro; var file_audit_enabled = app.pageOptions.file_audit_enabled; + var file_icon_size = Common.isHiDPI() ? 48 : 24; this.$el.html(this.template({ dirent: this.model.attributes, dirent_path: dirent_path, encoded_path: Common.encodePath(dirent_path), - icon_url: this.model.getIconUrl(48), + icon_url: this.model.getIconUrl(file_icon_size), url: this.model.getWebUrl(), download_url: this.model.getDownloadUrl(), category: dir.category, diff --git a/static/scripts/common.js b/static/scripts/common.js index b7268030ff..a72960e4f3 100644 --- a/static/scripts/common.js +++ b/static/scripts/common.js @@ -212,10 +212,27 @@ define([ }, getDirIconUrl: function(is_readonly, size) { - if (is_readonly) { - return app.config.mediaUrl + "img/folder-read-only-192.png"; + if (size > 24) { + if (is_readonly) { + return app.config.mediaUrl + "img/folder-read-only-192.png"; + } else { + return app.config.mediaUrl + "img/folder-192.png"; + } } else { - return app.config.mediaUrl + "img/folder-beige-192.png"; + if (is_readonly) { + return app.config.mediaUrl + "img/folder-read-only-24.png"; + } else { + return app.config.mediaUrl + "img/folder-24.png"; + } + } + }, + + isHiDPI: function() { + var pixelRatio = window.devicePixelRatio ? window.devicePixelRatio : 1; + if (pixelRatio > 1) { + return true; + } else { + return false; } },