haiwen/seahub
1
0
Fork 0
mirror of https://github.com/haiwen/seahub.git synced 2025-09-15 14:49:09 +00:00
Code Issues Releases Wiki Activity

Lib settings fixup (#7109)

Browse Source 
* [lib settings] fixup

* [lib settings] related update(removed unused code & etc.)
This commit is contained in:
llj
2024-11-27 11:18:06 +08:00
committed by GitHub
parent 8edd4c8505
commit dce7f1ac98
3 changed files with 30 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

56
frontend/src/components/dialog/lib-settings.js
View File

@@ -7,7 +7,7 @@ import LibAutoDelSettingPanel from './lib-settings/lib-old-files-auto-del-settin
import { import {
MetadataStatusManagementDialog as LibExtendedPropertiesSettingPanel, MetadataStatusManagementDialog as LibExtendedPropertiesSettingPanel,
MetadataFaceRecognitionDialog as LibFaceRecognitionSettingPanel, MetadataFaceRecognitionDialog as LibFaceRecognitionSettingPanel,
MetadataTagsStatusDialog as LibMetadataTagsStatusSettingsPanel, MetadataTagsStatusDialog as LibMetadataTagsStatusSettingPanel,
useMetadata useMetadata
} from '../../metadata'; } from '../../metadata';
import { useMetadataStatus } from '../../hooks'; import { useMetadataStatus } from '../../hooks';
@@ -15,11 +15,11 @@ import { useMetadataStatus } from '../../hooks';
import '../../css/lib-settings.css'; import '../../css/lib-settings.css';
const TAB = { const TAB = {
HISTORY_SETTINGS: 'history_settings', HISTORY_SETTING: 'history_setting',
AUTO_DELETE_SETTINGS: 'auto_delete_settings', AUTO_DEL_SETTING: 'auto_delete_setting',
EXTENDED_PROPERTIES_SETTINGS: 'extended_properties_settings', EXTENDED_PROPERTIES_SETTING: 'extended_properties_setting',
FACE_RECOGNITION_SETTINGS: 'face_recognition_settings', FACE_RECOGNITION_SETTING: 'face_recognition_setting',
TAGS_SETTINGS: 'tags_settings', TAGS_SETTING: 'tags_setting'
}; };
const propTypes = { const propTypes = {
@@ -29,7 +29,7 @@ const propTypes = {
}; };
const LibSettingsDialog = ({ repoID, currentRepoInfo, toggleDialog, tab }) => { const LibSettingsDialog = ({ repoID, currentRepoInfo, toggleDialog, tab }) => {
const [activeTab, setActiveTab] = useState(tab || TAB.HISTORY_SETTINGS); const [activeTab, setActiveTab] = useState(tab || TAB.HISTORY_SETTING);
const toggleTab = useCallback((tab) => { const toggleTab = useCallback((tab) => {
setActiveTab(tab); setActiveTab(tab);
@@ -61,36 +61,36 @@ const LibSettingsDialog = ({ repoID, currentRepoInfo, toggleDialog, tab }) => {
<div className="lib-setting-nav p-4"> <div className="lib-setting-nav p-4">
<Nav pills className="flex-column"> <Nav pills className="flex-column">
{enableHistorySetting && ( {enableHistorySetting && (
<NavItem role="tab" aria-selected={activeTab === TAB.HISTORY_SETTINGS} aria-controls="history-setting-panel"> <NavItem role="tab" aria-selected={activeTab === TAB.HISTORY_SETTING} aria-controls="history-setting-panel">
<NavLink className={activeTab === TAB.HISTORY_SETTINGS ? 'active' : ''} onClick={(toggleTab.bind(this, TAB.HISTORY_SETTINGS))} tabIndex="0" onKeyDown={onTabKeyDown}> <NavLink className={activeTab === TAB.HISTORY_SETTING ? 'active' : ''} onClick={(toggleTab.bind(this, TAB.HISTORY_SETTING))} tabIndex="0" onKeyDown={onTabKeyDown}>
{gettext('History')} {gettext('History')}
</NavLink> </NavLink>
</NavItem> </NavItem>
)} )}
{enableAutoDelSetting && ( {enableAutoDelSetting && (
<NavItem role="tab" aria-selected={activeTab === TAB.AUTO_DELETE_SETTINGS} aria-controls="auto-del-setting-panel"> <NavItem role="tab" aria-selected={activeTab === TAB.AUTO_DEL_SETTING} aria-controls="auto-del-setting-panel">
<NavLink className={activeTab === TAB.AUTO_DELETE_SETTINGS ? 'active' : ''} onClick={toggleTab.bind(this, TAB.AUTO_DELETE_SETTINGS)} tabIndex="0" onKeyDown={onTabKeyDown}> <NavLink className={activeTab === TAB.AUTO_DEL_SETTING ? 'active' : ''} onClick={toggleTab.bind(this, TAB.AUTO_DEL_SETTING)} tabIndex="0" onKeyDown={onTabKeyDown}>
{gettext('Auto deletion')} {gettext('Auto deletion')}
</NavLink> </NavLink>
</NavItem> </NavItem>
)} )}
{enableExtendedPropertiesSetting && ( {enableExtendedPropertiesSetting && (
<NavItem role="tab" aria-selected={activeTab === TAB.EXTENDED_PROPERTIES_SETTINGS} aria-controls="extended-properties-setting-panel"> <NavItem role="tab" aria-selected={activeTab === TAB.EXTENDED_PROPERTIES_SETTING} aria-controls="extended-properties-setting-panel">
<NavLink className={activeTab === TAB.EXTENDED_PROPERTIES_SETTINGS ? 'active' : ''} onClick={toggleTab.bind(this, TAB.EXTENDED_PROPERTIES_SETTINGS)} tabIndex="0" onKeyDown={onTabKeyDown}> <NavLink className={activeTab === TAB.EXTENDED_PROPERTIES_SETTING ? 'active' : ''} onClick={toggleTab.bind(this, TAB.EXTENDED_PROPERTIES_SETTING)} tabIndex="0" onKeyDown={onTabKeyDown}>
{gettext('Extended properties')} {gettext('Extended properties')}
</NavLink> </NavLink>
</NavItem> </NavItem>
)} )}
{enableMetadataOtherSettings && ( {enableMetadataOtherSettings && (
<NavItem role="tab" aria-selected={activeTab === TAB.FACE_RECOGNITION_SETTINGS} aria-controls="face-recognition-setting-panel"> <NavItem role="tab" aria-selected={activeTab === TAB.FACE_RECOGNITION_SETTING} aria-controls="face-recognition-setting-panel">
<NavLink className={activeTab === TAB.FACE_RECOGNITION_SETTINGS ? 'active' : ''} onClick={toggleTab.bind(this, TAB.FACE_RECOGNITION_SETTINGS)} tabIndex="0" onKeyDown={onTabKeyDown}> <NavLink className={activeTab === TAB.FACE_RECOGNITION_SETTING ? 'active' : ''} onClick={toggleTab.bind(this, TAB.FACE_RECOGNITION_SETTING)} tabIndex="0" onKeyDown={onTabKeyDown}>
{gettext('Face recognition')} {gettext('Face recognition')}
</NavLink> </NavLink>
</NavItem> </NavItem>
)} )}
{enableMetadataOtherSettings && ( {enableMetadataOtherSettings && (
<NavItem role="tab" aria-selected={activeTab === TAB.TAGS_SETTINGS} aria-controls="face-recognition-setting-panel"> <NavItem role="tab" aria-selected={activeTab === TAB.TAGS_SETTING} aria-controls="tags-setting-panel">
<NavLink className={activeTab === TAB.TAGS_SETTINGS ? 'active' : ''} onClick={toggleTab.bind(this, TAB.TAGS_SETTINGS)} tabIndex="0" onKeyDown={onTabKeyDown}> <NavLink className={activeTab === TAB.TAGS_SETTING ? 'active' : ''} onClick={toggleTab.bind(this, TAB.TAGS_SETTING)} tabIndex="0" onKeyDown={onTabKeyDown}>
{gettext('Tags')} {gettext('Tags')}
</NavLink> </NavLink>
</NavItem> </NavItem>
@@ -98,24 +98,24 @@ const LibSettingsDialog = ({ repoID, currentRepoInfo, toggleDialog, tab }) => {
</Nav> </Nav>
</div> </div>
<TabContent activeTab={activeTab} className="flex-fill"> <TabContent activeTab={activeTab} className="flex-fill">
{(enableHistorySetting && activeTab === TAB.HISTORY_SETTINGS) && ( {(enableHistorySetting && activeTab === TAB.HISTORY_SETTING) && (
<TabPane tabId={TAB.HISTORY_SETTINGS} role="tabpanel" id="history-setting-panel"> <TabPane tabId={TAB.HISTORY_SETTING} role="tabpanel" id="history-setting-panel">
<LibHistorySettingPanel <LibHistorySettingPanel
repoID={repoID} repoID={repoID}
toggleDialog={toggleDialog} toggleDialog={toggleDialog}
/> />
</TabPane> </TabPane>
)} )}
{(enableAutoDelSetting && activeTab === TAB.AUTO_DELETE_SETTINGS) && ( {(enableAutoDelSetting && activeTab === TAB.AUTO_DEL_SETTING) && (
<TabPane tabId={TAB.AUTO_DELETE_SETTINGS} role="tabpanel" id="auto-del-setting-panel"> <TabPane tabId={TAB.AUTO_DEL_SETTING} role="tabpanel" id="auto-del-setting-panel">
<LibAutoDelSettingPanel <LibAutoDelSettingPanel
repoID={repoID} repoID={repoID}
toggleDialog={toggleDialog} toggleDialog={toggleDialog}
/> />
</TabPane> </TabPane>
)} )}
{(enableExtendedPropertiesSetting && activeTab === TAB.EXTENDED_PROPERTIES_SETTINGS) && ( {(enableExtendedPropertiesSetting && activeTab === TAB.EXTENDED_PROPERTIES_SETTING) && (
<TabPane tabId={TAB.EXTENDED_PROPERTIES_SETTINGS} role="tabpanel" id="extended-properties-setting-panel"> <TabPane tabId={TAB.EXTENDED_PROPERTIES_SETTING} role="tabpanel" id="extended-properties-setting-panel">
<LibExtendedPropertiesSettingPanel <LibExtendedPropertiesSettingPanel
repoID={repoID} repoID={repoID}
value={enableMetadata} value={enableMetadata}
@@ -124,8 +124,8 @@ const LibSettingsDialog = ({ repoID, currentRepoInfo, toggleDialog, tab }) => {
/> />
</TabPane> </TabPane>
)} )}
{(enableMetadataOtherSettings && activeTab === TAB.FACE_RECOGNITION_SETTINGS) && ( {(enableMetadataOtherSettings && activeTab === TAB.FACE_RECOGNITION_SETTING) && (
<TabPane tabId={TAB.FACE_RECOGNITION_SETTINGS} role="tabpanel" id="face-recognition-setting-panel"> <TabPane tabId={TAB.FACE_RECOGNITION_SETTING} role="tabpanel" id="face-recognition-setting-panel">
<LibFaceRecognitionSettingPanel <LibFaceRecognitionSettingPanel
repoID={repoID} repoID={repoID}
value={enableFaceRecognition} value={enableFaceRecognition}
@@ -134,9 +134,9 @@ const LibSettingsDialog = ({ repoID, currentRepoInfo, toggleDialog, tab }) => {
/> />
</TabPane> </TabPane>
)} )}
{(enableMetadataOtherSettings && activeTab === TAB.TAGS_SETTINGS) && ( {(enableMetadataOtherSettings && activeTab === TAB.TAGS_SETTING) && (
<TabPane tabId={TAB.TAGS_SETTINGS} role="tabpanel" id="face-recognition-setting-panel"> <TabPane tabId={TAB.TAGS_SETTING} role="tabpanel" id="tags-setting-panel">
<LibMetadataTagsStatusSettingsPanel <LibMetadataTagsStatusSettingPanel
repoID={repoID} repoID={repoID}
value={enableTags} value={enableTags}
submit={updateEnableTags} submit={updateEnableTags}

3
frontend/src/components/dir-view-mode/dir-others/index.js
View File

@@ -4,7 +4,7 @@ import { gettext, siteRoot } from '../../../utils/constants';
import { Utils } from '../../../utils/utils'; import { Utils } from '../../../utils/utils';
import TreeSection from '../../tree-section'; import TreeSection from '../../tree-section';
import TrashDialog from '../../dialog/trash-dialog'; import TrashDialog from '../../dialog/trash-dialog';
import LibSettingsDialog, { TAB } from '../../dialog/lib-settings'; import LibSettingsDialog from '../../dialog/lib-settings';
import './index.css'; import './index.css';
@@ -58,7 +58,6 @@ const DirOthers = ({ userPerm, repoID, currentRepoInfo }) => {
repoID={repoID} repoID={repoID}
currentRepoInfo={currentRepoInfo} currentRepoInfo={currentRepoInfo}
toggleDialog={toggleSettingsDialog} toggleDialog={toggleSettingsDialog}
tab={TAB.HISTORY_SETTINGS}
/> />
)} )}
</TreeSection> </TreeSection>

2
frontend/src/components/dir-view-mode/dir-views.js
View File

@@ -43,7 +43,7 @@ const DirViews = ({ userPerm, repoID, currentPath, currentRepoInfo }) => {
<LibSettingsDialog <LibSettingsDialog
repoID={repoID} repoID={repoID}
currentRepoInfo={currentRepoInfo} currentRepoInfo={currentRepoInfo}
tab={TAB.EXTENDED_PROPERTIES_SETTINGS} tab={TAB.EXTENDED_PROPERTIES_SETTING}
toggleDialog={toggleSettingsDialog} toggleDialog={toggleSettingsDialog}
/> />
)} )}