1
0
mirror of https://github.com/haiwen/seahub.git synced 2025-09-02 23:48:47 +00:00

delete item-dropdown-menu unnecessary code

This commit is contained in:
shanshuirenjia
2019-04-22 11:19:26 +08:00
parent 546313a3a7
commit ddb7ec369e
4 changed files with 4 additions and 14 deletions

View File

@@ -431,7 +431,6 @@ class DirentListItem extends React.Component {
<li className="operation-group-item"> <li className="operation-group-item">
<ItemDropDownMenu <ItemDropDownMenu
opItem={this.props.dirent} opItem={this.props.dirent}
menuType={'pc'}
menuClass={'sf2-icon-caret-down'} menuClass={'sf2-icon-caret-down'}
isHandleContextMenuEvent={true} isHandleContextMenuEvent={true}
getOpItemMenuList={this.props.getDirentItemMenuList} getOpItemMenuList={this.props.getDirentItemMenuList}

View File

@@ -7,7 +7,6 @@ import { gettext } from '../../utils/constants';
const propTypes = { const propTypes = {
tagName: PropTypes.string, tagName: PropTypes.string,
opItem: PropTypes.object.isRequired, opItem: PropTypes.object.isRequired,
menuType: PropTypes.oneOf(['pc', 'mobile']),
menuClass: PropTypes.string, menuClass: PropTypes.string,
isHandleContextMenuEvent: PropTypes.bool, isHandleContextMenuEvent: PropTypes.bool,
getOpItemMenuList: PropTypes.func.isRequired, getOpItemMenuList: PropTypes.func.isRequired,
@@ -20,7 +19,6 @@ class ItemDropDownMenu extends React.Component {
static defaultProps = { static defaultProps = {
isHandleContextMenuEvent: true, isHandleContextMenuEvent: true,
menuType: 'pc',
menuClass: 'sf2-icon-caret-down' menuClass: 'sf2-icon-caret-down'
}; };
@@ -36,20 +34,15 @@ class ItemDropDownMenu extends React.Component {
if (this.props.isHandleContextMenuEvent) { if (this.props.isHandleContextMenuEvent) {
this.listenerId = listener.register(this.onShowMenu, this.onHideMenu); this.listenerId = listener.register(this.onShowMenu, this.onHideMenu);
} }
let { opItem, menuType } = this.props; let { opItem } = this.props;
let menuList = this.props.getOpItemMenuList(opItem);
// scene 1: menuType === 'pc', Get some menu operations
// scene 2: menuType === 'mobile', Get all menu operations
let isAllOperations = menuType === 'pc' ? false : true;
let menuList = this.props.getOpItemMenuList(opItem, isAllOperations);
this.setState({menuList: menuList}); this.setState({menuList: menuList});
} }
componentWillReceiveProps(nextProps) { // for toolbar opItem operation componentWillReceiveProps(nextProps) { // for toolbar opItem operation
let { opItem, menuType } = nextProps; let { opItem } = nextProps;
if (opItem.name !== this.props.opItem.name) { if (opItem.name !== this.props.opItem.name) {
let isAllOperations = menuType === 'pc' ? false : true; let menuList = this.props.getOpItemMenuList(opItem);
let menuList = this.props.getOpItemMenuList(opItem, isAllOperations);
this.setState({menuList: menuList}); this.setState({menuList: menuList});
} }
} }

View File

@@ -285,7 +285,6 @@ class MutipleDirOperationToolbar extends React.Component {
<ItemDropDownMenu <ItemDropDownMenu
tagName={'button'} tagName={'button'}
opItem={this.props.selectedDirentList[0]} opItem={this.props.selectedDirentList[0]}
menuType={'pc'}
menuClass={'fas fa-ellipsis-v dirents-more-menu'} menuClass={'fas fa-ellipsis-v dirents-more-menu'}
onMenuItemClick={this.onMenuItemClick} onMenuItemClick={this.onMenuItemClick}
getOpItemMenuList={this.getDirentMenuList} getOpItemMenuList={this.getDirentMenuList}

View File

@@ -256,7 +256,6 @@ class TreeNodeView extends React.Component {
<ItemDropDownMenu <ItemDropDownMenu
opItem={this.props.node} opItem={this.props.node}
menuClass={'fas fa-ellipsis-v'} menuClass={'fas fa-ellipsis-v'}
menuType={'pc'}
getOpItemMenuList={this.caculateMenuList} getOpItemMenuList={this.caculateMenuList}
onMenuItemClick={this.onMenuItemClick} onMenuItemClick={this.onMenuItemClick}
onFreezedItem={this.props.onFreezedItem} onFreezedItem={this.props.onFreezedItem}