haiwen/seahub
1
0
Fork 0
mirror of https://github.com/haiwen/seahub.git synced 2025-08-21 08:25:21 +00:00
Code Issues Releases Wiki Activity

fix set repo history validation (#7563)

Browse Source
This commit is contained in:
Michael An 2025-03-05 16:55:39 +08:00 committed by GitHub
parent a8727ae408
commit df4e04d427
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 30 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
frontend/src/components/dialog/lib-settings/lib-history-setting-panel.js
View File

@ -48,7 +48,16 @@ class LibHistorySetting extends React.Component {
days = this.state.expireDays; days = this.state.expireDays;
} }
let repoID = this.props.repoID; let repoID = this.props.repoID;
if (Number(days) > 0) { // If it's allHistory, days is always -1, no validation is needed;
// If it's noHistory, days is always 0, no validation is needed;
// If it's autoHistory, days needs to be validated to be greater than 0."
if (this.state.autoHistory && Number(days) <= 0) {
this.setState({
errorInfo: gettext('Please enter a non-negative integer'),
});
return;
}
let message = gettext('Successfully set library history.'); let message = gettext('Successfully set library history.');
seafileAPI.setRepoHistoryLimit(repoID, parseInt(days)).then(res => { seafileAPI.setRepoHistoryLimit(repoID, parseInt(days)).then(res => {
toaster.success(message); toaster.success(message);
@ -58,11 +67,6 @@ class LibHistorySetting extends React.Component {
let errMessage = Utils.getErrorMsg(error); let errMessage = Utils.getErrorMsg(error);
toaster.danger(errMessage); toaster.danger(errMessage);
}); });
} else {
this.setState({
errorInfo: gettext('Please enter a non-negative integer'),
});
}
}; };
handleKeyDown = (e) => { handleKeyDown = (e) => {

16
frontend/src/components/dialog/sysadmin-dialog/sysadmin-lib-history-setting-dialog.js
View File

@ -50,7 +50,16 @@ class SysAdminLibHistorySettingDialog extends React.Component {
days = this.state.expireDays; days = this.state.expireDays;
} }
let repoID = this.props.repoID; let repoID = this.props.repoID;
if (Number(days) > 0) { // If it's allHistory, days is always -1, no validation is needed;
// If it's noHistory, days is always 0, no validation is needed;
// If it's autoHistory, days needs to be validated to be greater than 0."
if (this.state.autoHistory && Number(days) <= 0) {
this.setState({
errorInfo: gettext('Please enter a non-negative integer'),
});
return;
}
let message = gettext('Successfully set library history.'); let message = gettext('Successfully set library history.');
systemAdminAPI.sysAdminUpdateRepoHistorySetting(repoID, parseInt(days)).then(res => { systemAdminAPI.sysAdminUpdateRepoHistorySetting(repoID, parseInt(days)).then(res => {
toaster.success(message); toaster.success(message);
@ -60,11 +69,6 @@ class SysAdminLibHistorySettingDialog extends React.Component {
let errMessage = Utils.getErrorMsg(error); let errMessage = Utils.getErrorMsg(error);
toaster.danger(errMessage); toaster.danger(errMessage);
}); });
} else {
this.setState({
errorInfo: gettext('Please enter a non-negative integer'),
});
}
}; };
handleKeyDown = (e) => { handleKeyDown = (e) => {