[shib] Fix shib complete url bug

tests/seahub/thirdpart/shibboleth/test_middleware.py

@@ -35,6 +35,9 @@ class ShibbolethRemoteUserMiddlewareTest(BaseTestCase):
         self.request.META['givenname'] = 'test_gname'
         self.request.META['surname'] = 'test_sname'
 
+        # default settings
+        assert getattr(settings, 'SHIB_ACTIVATE_AFTER_CREATION', True) is True
+
     def test_can_process(self):
         assert len(Profile.objects.all()) == 0
 
@@ -52,7 +55,7 @@ class ShibbolethRemoteUserMiddlewareTest(BaseTestCase):
             reload(backends)
 
             resp = self.middleware.process_request(self.request)
-            assert resp.url == 'shib-complete'
+            assert resp.url == '/shib-complete/'
             assert len(Profile.objects.all()) == 0
 
         # now reload again, so it reverts to original settings

thirdpart/shibboleth/middleware.py

@@ -67,7 +67,7 @@ class ShibbolethRemoteUserMiddleware(RemoteUserMiddleware):
         user = auth.authenticate(remote_user=username, shib_meta=shib_meta)
         if user:
             if not user.is_active:
-                return HttpResponseRedirect('shib-complete')
+                return HttpResponseRedirect(reverse('shib_complete'))
 
             # User is valid.  Set request.user and persist user in the session
             # by logging the user in.