diff --git a/seahub/notifications/models.py b/seahub/notifications/models.py
index 692dadd6ba..a1e67688f9 100644
--- a/seahub/notifications/models.py
+++ b/seahub/notifications/models.py
@@ -56,7 +56,8 @@ def priv_file_share_msg_to_json(share_from, file_name, priv_share_token):
'priv_share_token': priv_share_token})
def group_msg_to_json(group_id, msg_from, message):
- return json.dumps({'group_id': group_id, 'msg_from': msg_from, 'message': message})
+ return json.dumps({'group_id': group_id, 'msg_from': msg_from,
+ 'message': message})
def grpmsg_reply_to_json(msg_id, reply_from, reply_msg):
return json.dumps({'msg_id': msg_id, 'reply_from': reply_from, 'reply_msg': reply_msg})
@@ -158,7 +159,7 @@ class UserNotificationManager(models.Manager):
notice.save()
except UserNotification.InvalidDetailError:
continue
-
+
def seen_group_msg_reply_notice(self, to_user, msg_id=None):
"""Mark all group message replies of a user as seen.
@@ -187,14 +188,11 @@ class UserNotificationManager(models.Manager):
user_notices = super(UserNotificationManager, self).filter(
to_user=to_user, seen=False, msg_type=MSG_TYPE_USER_MESSAGE)
for notice in user_notices:
- try:
- notice_from_user = notice.user_message_detail_to_dict().get('msg_from')
- if from_user == notice_from_user:
- if notice.seen is False:
- notice.seen = True
- notice.save()
- except UserNotification.InvalidDetailError:
- continue
+ notice_from_user = notice.user_message_detail_to_dict().get('msg_from')
+ if from_user == notice_from_user:
+ if notice.seen is False:
+ notice.seen = True
+ notice.save()
def remove_group_msg_notices(self, to_user, group_id):
"""Remove group message notices of a user.
@@ -456,7 +454,6 @@ class UserNotification(models.Model):
Arguments:
- `self`:
- Raises ``InvalidDetailError`` if detail field can not be parsed.
"""
assert self.is_user_message()
@@ -571,11 +568,8 @@ class UserNotification(models.Model):
return _(u"Internal error")
message = d.get('message')
- if message:
- msg = _(u"
%(message)s") % {
- 'message': message,
- }
- return msg
+ if message is not None:
+ return message
else:
return None
@@ -621,11 +615,8 @@ class UserNotification(models.Model):
return _(u"Internal error")
message = d.get('message')
-
- if message:
- msg = _(u"
%(message)s") % {
- 'message': message}
- return msg
+ if message is not None:
+ return message
else:
return None
@@ -665,11 +656,8 @@ class UserNotification(models.Model):
return _(u"Internal error")
reply_msg = d.get('reply_msg')
-
- if reply_msg:
- msg = _(u"
%(reply_msg)s") % {
- 'reply_msg': reply_msg}
- return msg
+ if reply_msg is not None:
+ return reply_msg
else:
return None
@@ -772,7 +760,7 @@ def grpmsg_added_cb(sender, **kwargs):
message = kwargs['message']
group_members = seaserv.get_group_members(int(group_id))
- notify_members = [ x.user_name for x in group_members if x.user_name != from_email ]
+ notify_members = [x.user_name for x in group_members if x.user_name != from_email]
detail = group_msg_to_json(group_id, from_email, message)
UserNotification.objects.bulk_add_group_msg_notices(notify_members, detail)
diff --git a/seahub/notifications/templates/notifications/notice_email.html b/seahub/notifications/templates/notifications/notice_email.html
index 1ec3c7b684..b9052ed022 100644
--- a/seahub/notifications/templates/notifications/notice_email.html
+++ b/seahub/notifications/templates/notifications/notice_email.html
@@ -5,7 +5,7 @@
{% block email_con %}
{% autoescape off %}
-
Hi, {% blocktrans with name=to_user|email2nickname %}{{ name }}{% endblocktrans %}
+Hi, {{ name|email2nickname }}
{% blocktrans count num=notice_count %} diff --git a/seahub/templates/snippets/notifications_popup.html b/seahub/templates/snippets/notifications_popup.html index 828ff66b42..6c1635b3a4 100644 --- a/seahub/templates/snippets/notifications_popup.html +++ b/seahub/templates/snippets/notifications_popup.html @@ -18,15 +18,15 @@ {% if notice.is_group_msg %}
{{ notice.format_group_message_title|safe }}
- {% if notice.format_group_message_detail %}
- {{ notice.format_group_message_detail|safe }}
+ {% if notice.format_group_message_detail %}
+ {{ notice.format_group_message_detail }}
{% endif %}
{{ notice.format_grpmsg_reply_title|safe }}
- {% if notice.format_grpmsg_reply_detail %}
- {{ notice.format_grpmsg_reply_detail|safe }}
+ {% if notice.format_grpmsg_reply_detail %}
+ {{ notice.format_grpmsg_reply_detail}}
{% endif %}
{{ notice.format_user_message_title|safe }}
- {% if notice.format_user_message_detail %}
- {{ notice.format_user_message_detail|safe }}
+ {% if notice.format_user_message_detail %}
+ {{ notice.format_user_message_detail }}
{% endif %}