haiwen/seahub
1
0
Fork 0
mirror of https://github.com/haiwen/seahub.git synced 2025-08-09 02:47:51 +00:00
Code Issues Releases Wiki Activity

[markdown file view] added 'aria-label' to the operation buttons

Browse Source
This commit is contained in:
llj 2021-07-19 18:04:05 +08:00
parent 78d7ff1368
commit f6e055b78b
2 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
frontend/src/components/file-view/file-toolbar.js
View File

@ -172,8 +172,8 @@ class FileToolbar extends React.Component {
<Dropdown isOpen={this.state.dropdownOpen} toggle={this.toggle} className="d-block d-md-none"> <Dropdown isOpen={this.state.dropdownOpen} toggle={this.toggle} className="d-block d-md-none">
<ButtonGroup > <ButtonGroup >
{(canEditFile && !err) && {(canEditFile && !err) &&
( this.props.isSaving ? (this.props.isSaving ?
<button type={'button'} className={'btn btn-icon btn-secondary btn-active'}> <button type={'button'} aria-label={gettext('Saving...')} className={'btn btn-icon btn-secondary btn-active'}>
<i className={'fa fa-spin fa-spinner'}/></button> : <i className={'fa fa-spin fa-spinner'}/></button> :
( (
this.props.needSave ? this.props.needSave ?
@ -192,7 +192,7 @@ class FileToolbar extends React.Component {
)} )}
</ButtonGroup> </ButtonGroup>
<DropdownToggle className="sf2-icon-more mx-1"> <DropdownToggle className="sf2-icon-more mx-1" aria-label={gettext('More Operations')}>
</DropdownToggle> </DropdownToggle>
<DropdownMenu right={true}> <DropdownMenu right={true}>
<DropdownItem> <DropdownItem>

10
frontend/src/components/toolbar/markdown-viewer-toolbar.js
View File

@ -72,7 +72,7 @@ class MoreMenu extends React.PureComponent {
const isSmall = this.props.isSmallScreen; const isSmall = this.props.isSmallScreen;
return ( return (
<Dropdown isOpen={this.state.dropdownOpen} toggle={this.dropdownToggle} direction="down" className="mx-1"> <Dropdown isOpen={this.state.dropdownOpen} toggle={this.dropdownToggle} direction="down" className="mx-1">
<DropdownToggle id="moreButton"> <DropdownToggle id="moreButton" aria-label={gettext('More Operations')}>
<i className="fa fa-ellipsis-v"/> <i className="fa fa-ellipsis-v"/>
<Tooltip toggle={this.tooltipToggle} delay={{show: 0, hide: 0}} target="moreButton" placement='bottom' isOpen={this.state.tooltipOpen}>{gettext('More')} <Tooltip toggle={this.tooltipToggle} delay={{show: 0, hide: 0}} target="moreButton" placement='bottom' isOpen={this.state.tooltipOpen}>{gettext('More')}
</Tooltip> </Tooltip>
@ -179,11 +179,11 @@ class MarkdownViewerToolbar extends React.Component {
<IconButton id={'shareBtn'} text={gettext('Share')} icon={'fa fa-share-alt'} <IconButton id={'shareBtn'} text={gettext('Share')} icon={'fa fa-share-alt'}
onMouseDown={this.props.toggleShareLinkDialog}/> onMouseDown={this.props.toggleShareLinkDialog}/>
} }
{ saving ? {saving ?
<button type={'button'} className={'btn btn-icon btn-secondary btn-active'}> <button type={'button'} aria-label={gettext('Saving...')} className={'btn btn-icon btn-secondary btn-active'}>
<i className={'fa fa-spin fa-spinner'}/></button> <i className={'fa fa-spin fa-spinner'}/></button>
: :
<IconButton text={gettext('Save')} id={'saveButton'} icon={'fa fa-save'} disabled={!contentChanged} <IconButton text={gettext('Save')} id={'saveButton'} icon={'fa fa-save'} disabled={!contentChanged}
onMouseDown={window.seafileEditor && window.seafileEditor.onRichEditorSave} isActive={contentChanged}/> onMouseDown={window.seafileEditor && window.seafileEditor.onRichEditorSave} isActive={contentChanged}/>
} }
{canDownloadFile && ( {canDownloadFile && (
@ -224,7 +224,7 @@ class MarkdownViewerToolbar extends React.Component {
<div className="topbar-btn-container"> <div className="topbar-btn-container">
<ButtonGroup> <ButtonGroup>
{saving ? {saving ?
<button type={'button'} className={'btn btn-icon btn-secondary btn-active'}> <button type={'button'} aria-label={gettext('Saving...')} className={'btn btn-icon btn-secondary btn-active'}>
<i className={'fa fa-spin fa-spinner'}/></button> <i className={'fa fa-spin fa-spinner'}/></button>
: :
<IconButton text={gettext('Save')} id={'saveButton'} icon={'fa fa-save'} disabled={!contentChanged} <IconButton text={gettext('Save')} id={'saveButton'} icon={'fa fa-save'} disabled={!contentChanged}