haiwen/seahub
1
0
Fork 0
mirror of https://github.com/haiwen/seahub.git synced 2025-09-07 01:41:39 +00:00
Code Issues Releases Wiki Activity

[a11y] share dialog: make tab panels accessible by keyboard

Browse Source
This commit is contained in:
llj
2021-10-08 15:19:04 +08:00
parent 11772e0425
commit fb205f3c65
4 changed files with 37 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
frontend/src/components/dialog/share-to-group.js
View File

@@ -39,7 +39,7 @@ class GroupItem extends React.Component {
let item = this.props.item; let item = this.props.item;
let currentPermission = Utils.getSharedPermission(item); let currentPermission = Utils.getSharedPermission(item);
return ( return (
<tr onMouseEnter={this.onMouseEnter} onMouseLeave={this.onMouseLeave}> <tr onMouseEnter={this.onMouseEnter} onMouseLeave={this.onMouseLeave} tabIndex="0" onFocus={this.onMouseEnter}>
<td className='name'>{item.group_info.name}</td> <td className='name'>{item.group_info.name}</td>
<td> <td>
<SharePermissionEditor <SharePermissionEditor
@@ -53,9 +53,13 @@ class GroupItem extends React.Component {
</td> </td>
<td> <td>
<span <span
tabIndex="0"
role="button"
className={`sf2-icon-x3 action-icon ${this.state.isOperationShow ? '' : 'hide'}`} className={`sf2-icon-x3 action-icon ${this.state.isOperationShow ? '' : 'hide'}`}
onClick={this.deleteShareItem} onClick={this.deleteShareItem}
onKeyDown={Utils.onKeyDown}
title={gettext('Delete')} title={gettext('Delete')}
aria-label={gettext('Delete')}
> >
</span> </span>
</td> </td>

6
frontend/src/components/dialog/share-to-invite-people.js
View File

@@ -41,7 +41,7 @@ class UserItem extends React.Component {
let item = this.props.item; let item = this.props.item;
let currentPermission = item.is_admin ? 'admin' : item.permission; let currentPermission = item.is_admin ? 'admin' : item.permission;
return ( return (
<tr onMouseEnter={this.onMouseEnter} onMouseLeave={this.onMouseLeave}> <tr onMouseEnter={this.onMouseEnter} onMouseLeave={this.onMouseLeave} tabIndex="0" onFocus={this.onMouseEnter}>
<td className="name">{item.accepter}</td> <td className="name">{item.accepter}</td>
<td> <td>
<SharePermissionEditor <SharePermissionEditor
@@ -56,9 +56,13 @@ class UserItem extends React.Component {
<td className="name">{item.inviter_name}</td> <td className="name">{item.inviter_name}</td>
<td> <td>
<span <span
tabIndex="0"
role="button"
className={`sf2-icon-x3 action-icon ${this.state.isOperationShow ? '' : 'hide'}`} className={`sf2-icon-x3 action-icon ${this.state.isOperationShow ? '' : 'hide'}`}
onClick={this.deleteShareItem} onClick={this.deleteShareItem}
onKeyDown={Utils.onKeyDown}
title={gettext('Delete')} title={gettext('Delete')}
aria-label={gettext('Delete')}
> >
</span> </span>
</td> </td>

6
frontend/src/components/dialog/share-to-user.js
View File

@@ -52,7 +52,7 @@ class UserItem extends React.Component {
let currentPermission = Utils.getSharedPermission(item); let currentPermission = Utils.getSharedPermission(item);
const { isUserDetailsPopoverOpen } = this.state; const { isUserDetailsPopoverOpen } = this.state;
return ( return (
<tr onMouseEnter={this.onMouseEnter} onMouseLeave={this.onMouseLeave}> <tr onMouseEnter={this.onMouseEnter} onMouseLeave={this.onMouseLeave} tabIndex="0" onFocus={this.onMouseEnter}>
<td className="name"> <td className="name">
<div className="position-relative"> <div className="position-relative">
<img src={item.user_info.avatar_url} <img src={item.user_info.avatar_url}
@@ -89,9 +89,13 @@ class UserItem extends React.Component {
</td> </td>
<td> <td>
<span <span
tabIndex="0"
role="button"
className={`sf2-icon-x3 action-icon ${this.state.isOperationShow ? '' : 'hide'}`} className={`sf2-icon-x3 action-icon ${this.state.isOperationShow ? '' : 'hide'}`}
onClick={this.deleteShareItem} onClick={this.deleteShareItem}
onKeyDown={Utils.onKeyDown}
title={gettext('Delete')} title={gettext('Delete')}
aria-label={gettext('Delete')}
> >
</span> </span>
</td> </td>

7
frontend/src/utils/utils.js
View File

@@ -1498,4 +1498,11 @@ export const Utils = {
return { isCustomPermission: false }; return { isCustomPermission: false };
} }
// for a11y
onKeyDown: function(e) {
if (e.key == 'Enter' || e.key == 'Space') {
e.target.click();
}
}
}; };