From 4ebe503e1bba2171f577b2be0d4acc55bc3cdcec Mon Sep 17 00:00:00 2001 From: Ettore Di Giacinto Date: Thu, 18 Aug 2022 15:19:15 +0000 Subject: [PATCH] robot: Add bundles test suite, fixup linting issues --- internal/agent/installer_suite_test.go | 13 ------------- internal/agent/upgrade.go | 8 ++++++-- 2 files changed, 6 insertions(+), 15 deletions(-) delete mode 100644 internal/agent/installer_suite_test.go diff --git a/internal/agent/installer_suite_test.go b/internal/agent/installer_suite_test.go deleted file mode 100644 index d4afd21..0000000 --- a/internal/agent/installer_suite_test.go +++ /dev/null @@ -1,13 +0,0 @@ -package agent_test - -import ( - "testing" - - . "github.com/onsi/ginkgo/v2" - . "github.com/onsi/gomega" -) - -func TestInstaller(t *testing.T) { - RegisterFailHandler(Fail) - RunSpecs(t, "Installer Suite") -} diff --git a/internal/agent/upgrade.go b/internal/agent/upgrade.go index e4316e7..00e27a4 100644 --- a/internal/agent/upgrade.go +++ b/internal/agent/upgrade.go @@ -20,10 +20,14 @@ func ListReleases() []string { releases := []string{} bus.Manager.Response(events.EventAvailableReleases, func(p *pluggable.Plugin, r *pluggable.EventResponse) { - json.Unmarshal([]byte(r.Data), &releases) + if err := json.Unmarshal([]byte(r.Data), &releases); err != nil { + fmt.Printf("warn: failed unmarshalling data: '%s'\n", err.Error()) + } }) - bus.Manager.Publish(events.EventAvailableReleases, events.EventPayload{}) + if _, err := bus.Manager.Publish(events.EventAvailableReleases, events.EventPayload{}); err != nil { + fmt.Printf("warn: failed publishing event: '%s'\n", err.Error()) + } if len(releases) == 0 { githubRepo, err := utils.OSRelease("GITHUB_REPO")