From a09db09db75c0de4ee83829da9c0e97b5f4796e4 Mon Sep 17 00:00:00 2001
From: Dimitris Karakasilis <dimitris@karakasilis.me>
Date: Wed, 8 Feb 2023 22:13:13 +0200
Subject: [PATCH] seedling: Don't swallow yaml config errors (#846)

* Don't swallow yaml config errors

because installation continues and there is no indication that something
went wrong

Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>

* Apply suggestions from code review

Co-authored-by: Ettore Di Giacinto <mudler@users.noreply.github.com>
Signed-off-by: Dimitris Karakasilis <jimmykarily@gmail.com>

---------

Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
Signed-off-by: Dimitris Karakasilis <jimmykarily@gmail.com>
Co-authored-by: Ettore Di Giacinto <mudler@users.noreply.github.com>
---
 pkg/config/config.go | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/pkg/config/config.go b/pkg/config/config.go
index 702d707..0ee0201 100644
--- a/pkg/config/config.go
+++ b/pkg/config/config.go
@@ -355,7 +355,10 @@ func parseConfig(dir []string, nologs bool) *Config {
 				continue
 			}
 
-			yaml.Unmarshal(b, c) //nolint:errcheck
+			err = yaml.Unmarshal(b, c)
+			if err != nil && !nologs {
+				fmt.Printf("warning: failed to merge config:\n%s\n", err.Error())
+			}
 
 			var newYaml map[string]interface{}
 			yaml.Unmarshal(b, &newYaml) //nolint:errcheck