kairos/kairos-agent
1
0
Fork 0
mirror of https://github.com/kairos-io/kairos-agent.git synced 2025-09-26 05:57:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

Call exec.Command properly, splitting the cmd and args

Browse Source 
This was failing but wasn't visible because it needs

`fail_on_bundles_errors: true` to be set in the Kairos config.

We need to find whether we need a new test or an existing one can be
adapted to catch this.

Signed-off-by: Dimitris Karakasilis <dimitris@karakasilis.me>
This commit is contained in:
Dimitris Karakasilis
2023-11-20 13:54:05 +02:00
parent 944ce8ce74
commit c98c791f60
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
internal/agent/hooks/bundles.go
View File

@@ -1,13 +1,14 @@
package hook package hook
import ( import (
"os"
"os/exec"
"syscall"
config "github.com/kairos-io/kairos-agent/v2/pkg/config" config "github.com/kairos-io/kairos-agent/v2/pkg/config"
v1 "github.com/kairos-io/kairos-agent/v2/pkg/types/v1" v1 "github.com/kairos-io/kairos-agent/v2/pkg/types/v1"
"github.com/kairos-io/kairos-sdk/bundles" "github.com/kairos-io/kairos-sdk/bundles"
"github.com/kairos-io/kairos-sdk/machine" "github.com/kairos-io/kairos-sdk/machine"
"os"
"os/exec"
"syscall"
) )
// BundlePostInstall install bundles just after installation // BundlePostInstall install bundles just after installation
@@ -36,7 +37,8 @@ func (b BundlePostInstall) Run(c config.Config, _ v1.Spec) error {
if c.FailOnBundleErrors && err != nil { if c.FailOnBundleErrors && err != nil {
return err return err
} }
cmd := exec.Command("rsync -aqAX /var/lib/extensions /usr/local/.state/var-lib-extensions.bind")
cmd := exec.Command("rsync", "-aqAX", "/var/lib/extensions", "/usr/local/.state/var-lib-extensions.bind")
_, err = cmd.CombinedOutput() _, err = cmd.CombinedOutput()
if c.FailOnBundleErrors && err != nil { if c.FailOnBundleErrors && err != nil {
return err return err