mirror of
https://github.com/kairos-io/kairos-agent.git
synced 2025-06-26 16:21:40 +00:00
* Fix hooks under encrypted partitions We had a mess of mounting and unmounting things around when we try to copy things to persistent. Part of the changes (using the by-label to mount the persistent) are due to the change in kcrypt. As we set the same label to the encrypted fs and unencrypted fs, our utils.Mount could get mistaken and return the first hit, which usually its the encrypted one, and we cannot mount that one. This patch brings it up to date. - Makes bundles and logs hooks work when we have encrypted persistent. It didnt work before. - Makes both workflows the same. - Locks everything once its over, to not leave encrypted parts around - Mounts OEM so kcrypt can read the config if we are using a remote server for encryption - Mounts by label so there is not a change of getting the wrong device - Uses the mount syscall directly. The util can mistake and return the actual encrypted part if they both have the same label and finds it first --------- Signed-off-by: Itxaka <itxaka@kairos.io>
87 lines
2.9 KiB
Go
87 lines
2.9 KiB
Go
package hook
|
|
|
|
import (
|
|
"fmt"
|
|
"github.com/kairos-io/kairos-agent/v2/pkg/config"
|
|
"github.com/kairos-io/kairos-agent/v2/pkg/constants"
|
|
v1 "github.com/kairos-io/kairos-agent/v2/pkg/types/v1"
|
|
internalutils "github.com/kairos-io/kairos-agent/v2/pkg/utils"
|
|
fsutils "github.com/kairos-io/kairos-agent/v2/pkg/utils/fs"
|
|
"github.com/kairos-io/kairos-sdk/machine"
|
|
"github.com/kairos-io/kairos-sdk/utils"
|
|
kcrypt "github.com/kairos-io/kcrypt/pkg/lib"
|
|
"path/filepath"
|
|
"strings"
|
|
"syscall"
|
|
)
|
|
|
|
// CopyLogs copies all current logs to the persistent partition.
|
|
// useful during install to keep the livecd logs
|
|
// best effort, no error handling
|
|
type CopyLogs struct{}
|
|
|
|
func (k CopyLogs) Run(c config.Config, _ v1.Spec) error {
|
|
c.Logger.Logger.Debug().Msg("Running CopyLogs hook")
|
|
_ = machine.Umount(constants.PersistentDir)
|
|
|
|
// Config passed during install ends up here, kcrypt challenger needs to read it if we are using a server for encryption
|
|
_ = machine.Mount(constants.OEMLabel, constants.OEMPath)
|
|
defer func() {
|
|
_ = machine.Umount(constants.OEMPath)
|
|
}()
|
|
|
|
// Path if we have encrypted persistent
|
|
if len(c.Install.Encrypt) != 0 {
|
|
err := kcrypt.UnlockAll(false)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
// Close all the unencrypted partitions at the end!
|
|
defer func() {
|
|
for _, p := range c.Install.Encrypt {
|
|
c.Logger.Debugf("Closing unencrypted /dev/disk/by-label/%s", p)
|
|
out, err := utils.SH(fmt.Sprintf("cryptsetup close /dev/disk/by-label/%s", p))
|
|
// There is a known error with cryptsetup that it can't close the device because of a semaphore
|
|
// doesnt seem to affect anything as the device is closed as expected so we ignore it if it matches the
|
|
// output of the error
|
|
if err != nil && !strings.Contains(out, "incorrect semaphore state") {
|
|
c.Logger.Errorf("could not close /dev/disk/by-label/%s: %s", p, out)
|
|
}
|
|
}
|
|
}()
|
|
}
|
|
|
|
_, _ = utils.SH("udevadm trigger --type=all || udevadm trigger")
|
|
err := c.Syscall.Mount(filepath.Join("/dev/disk/by-label", constants.PersistentLabel), constants.PersistentDir, "ext4", 0, "")
|
|
if err != nil {
|
|
fmt.Printf("could not mount persistent: %s\n", err)
|
|
return err
|
|
}
|
|
|
|
defer func() {
|
|
err := machine.Umount(constants.PersistentDir)
|
|
if err != nil {
|
|
c.Logger.Errorf("could not unmount persistent partition: %s", err)
|
|
}
|
|
}()
|
|
|
|
// Create the directory on persistent
|
|
varLog := filepath.Join(constants.PersistentDir, ".state", "var-log.bind")
|
|
|
|
err = fsutils.MkdirAll(c.Fs, varLog, 0755)
|
|
if err != nil {
|
|
c.Logger.Errorf("could not create directory on persistent partition: %s", err)
|
|
return nil
|
|
}
|
|
// Copy all current logs to the persistent partition
|
|
err = internalutils.SyncData(c.Logger, c.Runner, c.Fs, "/var/log/", varLog, []string{}...)
|
|
if err != nil {
|
|
c.Logger.Errorf("could not copy logs to persistent partition: %s", err)
|
|
return nil
|
|
}
|
|
syscall.Sync()
|
|
c.Logger.Debugf("Logs copied to persistent partition")
|
|
c.Logger.Logger.Debug().Msg("Finish CopyLogs hook")
|
|
return nil
|
|
}
|