From 747d0ef9ac0e41d3f6bda0077cc50813988a7d47 Mon Sep 17 00:00:00 2001 From: Ettore Di Giacinto Date: Tue, 12 Nov 2019 22:17:51 +0100 Subject: [PATCH] Do not fail in case we cannot remove cached images Add a TODO, we should have a cli flag to treat warnings as fatal --- pkg/compiler/compiler.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/pkg/compiler/compiler.go b/pkg/compiler/compiler.go index f51ae6ae..9ccaff0d 100644 --- a/pkg/compiler/compiler.go +++ b/pkg/compiler/compiler.go @@ -164,7 +164,9 @@ func (cs *LuetCompiler) compileWithImage(image, buildertaggedImage, packageImage // TODO: Handle caching and optionally do not remove things err = cs.Backend.RemoveImage(builderOpts) if err != nil { - return nil, errors.Wrap(err, "Could not remove image") + // TODO: Have a --fatal flag which enables Warnings to exit. + Warning("Could not remove image ", builderOpts.ImageName) + // return nil, errors.Wrap(err, "Could not remove image") } } rootfs, err := ioutil.TempDir(p.GetOutputPath(), "rootfs")