From dce8b5229365478d3de48897bfdaf9488aa02d08 Mon Sep 17 00:00:00 2001 From: Ettore Di Giacinto Date: Wed, 30 Dec 2020 01:15:44 +0100 Subject: [PATCH] Use Conflicts() which already lists revdeps on failure --- pkg/solver/solver.go | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/pkg/solver/solver.go b/pkg/solver/solver.go index 66f56c99..b8824da9 100644 --- a/pkg/solver/solver.go +++ b/pkg/solver/solver.go @@ -589,13 +589,8 @@ func (s *Solver) Uninstall(checkconflicts, full bool, packs ...pkg.Package) (pkg // be removed). Let's only check if we can remove the selected package if !full && checkconflicts { for _, candidate := range toRemove { - if conflicts, _ := s.ConflictsWith(candidate, s.Installed()); conflicts { - revdeps, _ := s.InstalledDatabase.GetRevdeps(candidate) - packs := "" - for _, p := range revdeps { - packs += " " + p.HumanReadableString() - } - return nil, errors.New("Package " + candidate.HumanReadableString() + "has conflicts: required by " + packs) + if conflicts, err := s.Conflicts(candidate, s.Installed()); conflicts { + return nil, errors.Wrap(err, "while searching for "+candidate.HumanReadableString()+" conflicts") } } return toRemove, nil