mirror of
https://github.com/mudler/luet.git
synced 2025-06-02 12:16:40 +00:00
f6a4b634c1
With this change the solver during install now considers only the part of the tree which is required to calculate the solution, it doesn't consider anymore World() as the search space. The search space now is narrowed down to the packages that related to the one which we are considering. In this subset of changes we are also optimizing the Parallel solver avoiding an useless loop. This change boost overall performance on large datasets which don't necessarly have relations touching the whole tree.
393 lines
15 KiB
Go
393 lines
15 KiB
Go
// Copyright © 2019 Ettore Di Giacinto <mudler@gentoo.org>
|
|
//
|
|
// This program is free software; you can redistribute it and/or modify
|
|
// it under the terms of the GNU General Public License as published by
|
|
// the Free Software Foundation; either version 2 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// This program is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU General Public License along
|
|
// with this program; if not, see <http://www.gnu.org/licenses/>.
|
|
|
|
package solver_test
|
|
|
|
import (
|
|
"strconv"
|
|
|
|
pkg "github.com/mudler/luet/pkg/package"
|
|
"github.com/mudler/luet/pkg/solver"
|
|
. "github.com/onsi/ginkgo"
|
|
. "github.com/onsi/gomega"
|
|
|
|
. "github.com/mudler/luet/pkg/solver"
|
|
)
|
|
|
|
var _ = Describe("Decoder", func() {
|
|
db := pkg.NewInMemoryDatabase(false)
|
|
dbInstalled := pkg.NewInMemoryDatabase(false)
|
|
dbDefinitions := pkg.NewInMemoryDatabase(false)
|
|
s := NewSolver(Options{Type: SingleCoreSimple}, dbInstalled, dbDefinitions, db)
|
|
|
|
BeforeEach(func() {
|
|
db = pkg.NewInMemoryDatabase(false)
|
|
dbInstalled = pkg.NewInMemoryDatabase(false)
|
|
dbDefinitions = pkg.NewInMemoryDatabase(false)
|
|
s = NewSolver(Options{Type: SingleCoreSimple}, dbInstalled, dbDefinitions, db)
|
|
})
|
|
|
|
Context("Assertion ordering", func() {
|
|
eq := 0
|
|
for index := 0; index < 300; index++ { // Just to make sure we don't have false positives
|
|
It("Orders them correctly #"+strconv.Itoa(index), func() {
|
|
|
|
C := pkg.NewPackage("C", "", []*pkg.DefaultPackage{}, []*pkg.DefaultPackage{})
|
|
E := pkg.NewPackage("E", "", []*pkg.DefaultPackage{}, []*pkg.DefaultPackage{})
|
|
F := pkg.NewPackage("F", "", []*pkg.DefaultPackage{}, []*pkg.DefaultPackage{})
|
|
G := pkg.NewPackage("G", "", []*pkg.DefaultPackage{}, []*pkg.DefaultPackage{})
|
|
H := pkg.NewPackage("H", "", []*pkg.DefaultPackage{G}, []*pkg.DefaultPackage{})
|
|
D := pkg.NewPackage("D", "", []*pkg.DefaultPackage{H}, []*pkg.DefaultPackage{})
|
|
B := pkg.NewPackage("B", "", []*pkg.DefaultPackage{D}, []*pkg.DefaultPackage{})
|
|
A := pkg.NewPackage("A", "", []*pkg.DefaultPackage{B}, []*pkg.DefaultPackage{})
|
|
|
|
for _, p := range []pkg.Package{A, B, C, D, E, F, G} {
|
|
_, err := dbDefinitions.CreatePackage(p)
|
|
Expect(err).ToNot(HaveOccurred())
|
|
}
|
|
|
|
for _, p := range []pkg.Package{C} {
|
|
_, err := dbInstalled.CreatePackage(p)
|
|
Expect(err).ToNot(HaveOccurred())
|
|
}
|
|
|
|
solution, err := s.Install([]pkg.Package{A})
|
|
Expect(solution).To(ContainElement(PackageAssert{Package: A, Value: true}))
|
|
Expect(solution).To(ContainElement(PackageAssert{Package: B, Value: true}))
|
|
Expect(solution).To(ContainElement(PackageAssert{Package: D, Value: true}))
|
|
Expect(solution).To(ContainElement(PackageAssert{Package: C, Value: true}))
|
|
Expect(solution).To(ContainElement(PackageAssert{Package: H, Value: true}))
|
|
Expect(solution).To(ContainElement(PackageAssert{Package: G, Value: true}))
|
|
|
|
Expect(len(solution)).To(Equal(6))
|
|
Expect(err).ToNot(HaveOccurred())
|
|
solution, err = solution.Order(dbDefinitions, A.GetFingerPrint())
|
|
Expect(err).ToNot(HaveOccurred())
|
|
// Expect(len(solution)).To(Equal(6))
|
|
Expect(solution[0].Package.GetName()).To(Equal("G"))
|
|
Expect(solution[1].Package.GetName()).To(Equal("H"))
|
|
Expect(solution[2].Package.GetName()).To(Equal("D"))
|
|
Expect(solution[3].Package.GetName()).To(Equal("B"))
|
|
eq += len(solution)
|
|
//Expect(solution[4].Package.GetName()).To(Equal("A"))
|
|
//Expect(solution[5].Package.GetName()).To(Equal("C")) As C doesn't have any dep it can be in both positions
|
|
})
|
|
}
|
|
|
|
It("Expects perfect equality when ordered", func() {
|
|
Expect(eq).To(Equal(300 * 5)) // assertions lenghts
|
|
})
|
|
|
|
disequality := 0
|
|
equality := 0
|
|
for index := 0; index < 300; index++ { // Just to make sure we don't have false positives
|
|
It("Doesn't order them correctly otherwise #"+strconv.Itoa(index), func() {
|
|
|
|
C := pkg.NewPackage("C", "", []*pkg.DefaultPackage{}, []*pkg.DefaultPackage{})
|
|
E := pkg.NewPackage("E", "", []*pkg.DefaultPackage{}, []*pkg.DefaultPackage{})
|
|
F := pkg.NewPackage("F", "", []*pkg.DefaultPackage{}, []*pkg.DefaultPackage{})
|
|
G := pkg.NewPackage("G", "", []*pkg.DefaultPackage{}, []*pkg.DefaultPackage{})
|
|
H := pkg.NewPackage("H", "", []*pkg.DefaultPackage{G}, []*pkg.DefaultPackage{})
|
|
D := pkg.NewPackage("D", "", []*pkg.DefaultPackage{H}, []*pkg.DefaultPackage{})
|
|
B := pkg.NewPackage("B", "", []*pkg.DefaultPackage{D}, []*pkg.DefaultPackage{})
|
|
A := pkg.NewPackage("A", "", []*pkg.DefaultPackage{B}, []*pkg.DefaultPackage{})
|
|
|
|
for _, p := range []pkg.Package{A, B, C, D, E, F, G} {
|
|
_, err := dbDefinitions.CreatePackage(p)
|
|
Expect(err).ToNot(HaveOccurred())
|
|
}
|
|
|
|
for _, p := range []pkg.Package{C} {
|
|
_, err := dbInstalled.CreatePackage(p)
|
|
Expect(err).ToNot(HaveOccurred())
|
|
}
|
|
|
|
solution, err := s.Install([]pkg.Package{A})
|
|
Expect(solution).To(ContainElement(PackageAssert{Package: A, Value: true}))
|
|
Expect(solution).To(ContainElement(PackageAssert{Package: B, Value: true}))
|
|
Expect(solution).To(ContainElement(PackageAssert{Package: D, Value: true}))
|
|
Expect(solution).To(ContainElement(PackageAssert{Package: C, Value: true}))
|
|
Expect(solution).To(ContainElement(PackageAssert{Package: H, Value: true}))
|
|
Expect(solution).To(ContainElement(PackageAssert{Package: G, Value: true}))
|
|
|
|
Expect(len(solution)).To(Equal(6))
|
|
Expect(err).ToNot(HaveOccurred())
|
|
if solution[0].Package.GetName() != "G" {
|
|
disequality++
|
|
} else {
|
|
equality++
|
|
}
|
|
if solution[1].Package.GetName() != "H" {
|
|
disequality++
|
|
} else {
|
|
equality++
|
|
}
|
|
if solution[2].Package.GetName() != "D" {
|
|
disequality++
|
|
} else {
|
|
equality++
|
|
}
|
|
if solution[3].Package.GetName() != "B" {
|
|
disequality++
|
|
} else {
|
|
equality++
|
|
}
|
|
if solution[4].Package.GetName() != "A" {
|
|
disequality++
|
|
} else {
|
|
equality++
|
|
}
|
|
|
|
})
|
|
It("Expect disequality", func() {
|
|
Expect(disequality).ToNot(Equal(0))
|
|
Expect(equality).ToNot(Equal(300 * 6))
|
|
})
|
|
}
|
|
})
|
|
|
|
Context("Assertion hashing", func() {
|
|
It("Hashes them, and could be used for comparison", func() {
|
|
|
|
C := pkg.NewPackage("C", "", []*pkg.DefaultPackage{}, []*pkg.DefaultPackage{})
|
|
E := pkg.NewPackage("E", "", []*pkg.DefaultPackage{}, []*pkg.DefaultPackage{})
|
|
F := pkg.NewPackage("F", "", []*pkg.DefaultPackage{}, []*pkg.DefaultPackage{})
|
|
G := pkg.NewPackage("G", "", []*pkg.DefaultPackage{}, []*pkg.DefaultPackage{})
|
|
H := pkg.NewPackage("H", "", []*pkg.DefaultPackage{G}, []*pkg.DefaultPackage{})
|
|
D := pkg.NewPackage("D", "", []*pkg.DefaultPackage{H}, []*pkg.DefaultPackage{})
|
|
B := pkg.NewPackage("B", "", []*pkg.DefaultPackage{D}, []*pkg.DefaultPackage{})
|
|
A := pkg.NewPackage("A", "", []*pkg.DefaultPackage{B}, []*pkg.DefaultPackage{})
|
|
|
|
for _, p := range []pkg.Package{A, B, C, D, E, F, G} {
|
|
_, err := dbDefinitions.CreatePackage(p)
|
|
Expect(err).ToNot(HaveOccurred())
|
|
}
|
|
|
|
for _, p := range []pkg.Package{C} {
|
|
_, err := dbInstalled.CreatePackage(p)
|
|
Expect(err).ToNot(HaveOccurred())
|
|
}
|
|
|
|
solution, err := s.Install([]pkg.Package{A})
|
|
Expect(solution).To(ContainElement(PackageAssert{Package: A, Value: true}))
|
|
Expect(solution).To(ContainElement(PackageAssert{Package: B, Value: true}))
|
|
Expect(solution).To(ContainElement(PackageAssert{Package: D, Value: true}))
|
|
Expect(solution).To(ContainElement(PackageAssert{Package: C, Value: true}))
|
|
Expect(solution).To(ContainElement(PackageAssert{Package: H, Value: true}))
|
|
Expect(solution).To(ContainElement(PackageAssert{Package: G, Value: true}))
|
|
|
|
Expect(len(solution)).To(Equal(6))
|
|
Expect(err).ToNot(HaveOccurred())
|
|
solution, err = solution.Order(dbDefinitions, A.GetFingerPrint())
|
|
Expect(err).ToNot(HaveOccurred())
|
|
// Expect(len(solution)).To(Equal(6))
|
|
Expect(solution[0].Package.GetName()).To(Equal("G"))
|
|
Expect(solution[1].Package.GetName()).To(Equal("H"))
|
|
Expect(solution[2].Package.GetName()).To(Equal("D"))
|
|
Expect(solution[3].Package.GetName()).To(Equal("B"))
|
|
|
|
hash := solution.AssertionHash()
|
|
|
|
solution, err = s.Install([]pkg.Package{B})
|
|
Expect(solution).To(ContainElement(PackageAssert{Package: B, Value: true}))
|
|
Expect(solution).To(ContainElement(PackageAssert{Package: D, Value: true}))
|
|
Expect(solution).To(ContainElement(PackageAssert{Package: C, Value: true}))
|
|
Expect(solution).To(ContainElement(PackageAssert{Package: H, Value: true}))
|
|
Expect(solution).To(ContainElement(PackageAssert{Package: G, Value: true}))
|
|
|
|
Expect(len(solution)).To(Equal(6))
|
|
Expect(err).ToNot(HaveOccurred())
|
|
solution, err = solution.Order(dbDefinitions, B.GetFingerPrint())
|
|
Expect(err).ToNot(HaveOccurred())
|
|
hash2 := solution.AssertionHash()
|
|
|
|
// Expect(len(solution)).To(Equal(6))
|
|
Expect(solution[0].Package.GetName()).To(Equal("G"))
|
|
Expect(solution[1].Package.GetName()).To(Equal("H"))
|
|
Expect(solution[2].Package.GetName()).To(Equal("D"))
|
|
Expect(solution[3].Package.GetName()).To(Equal("B"))
|
|
|
|
Expect(hash).ToNot(Equal(""))
|
|
Expect(hash2).ToNot(Equal(""))
|
|
Expect(hash != hash2).To(BeTrue())
|
|
|
|
})
|
|
It("Hashes them, and could be used for comparison", func() {
|
|
|
|
X := pkg.NewPackage("X", "", []*pkg.DefaultPackage{}, []*pkg.DefaultPackage{})
|
|
Y := pkg.NewPackage("Y", "", []*pkg.DefaultPackage{X}, []*pkg.DefaultPackage{})
|
|
Z := pkg.NewPackage("Z", "", []*pkg.DefaultPackage{X}, []*pkg.DefaultPackage{})
|
|
|
|
for _, p := range []pkg.Package{X, Y, Z} {
|
|
_, err := dbDefinitions.CreatePackage(p)
|
|
Expect(err).ToNot(HaveOccurred())
|
|
}
|
|
|
|
for _, p := range []pkg.Package{} {
|
|
_, err := dbInstalled.CreatePackage(p)
|
|
Expect(err).ToNot(HaveOccurred())
|
|
}
|
|
|
|
solution, err := s.Install([]pkg.Package{Y})
|
|
Expect(err).ToNot(HaveOccurred())
|
|
|
|
solution2, err := s.Install([]pkg.Package{Z})
|
|
Expect(err).ToNot(HaveOccurred())
|
|
orderY, err := solution.Order(dbDefinitions, Y.GetFingerPrint())
|
|
Expect(err).ToNot(HaveOccurred())
|
|
orderZ, err := solution2.Order(dbDefinitions, Z.GetFingerPrint())
|
|
Expect(err).ToNot(HaveOccurred())
|
|
Expect(orderY.Drop(Y).AssertionHash() == orderZ.Drop(Z).AssertionHash()).To(BeTrue())
|
|
})
|
|
|
|
It("Hashes them, Cuts them and could be used for comparison", func() {
|
|
|
|
X := pkg.NewPackage("X", "", []*pkg.DefaultPackage{}, []*pkg.DefaultPackage{})
|
|
Y := pkg.NewPackage("Y", "", []*pkg.DefaultPackage{X}, []*pkg.DefaultPackage{})
|
|
Z := pkg.NewPackage("Z", "", []*pkg.DefaultPackage{X}, []*pkg.DefaultPackage{})
|
|
|
|
for _, p := range []pkg.Package{X, Y, Z} {
|
|
_, err := dbDefinitions.CreatePackage(p)
|
|
Expect(err).ToNot(HaveOccurred())
|
|
}
|
|
|
|
for _, p := range []pkg.Package{} {
|
|
_, err := dbInstalled.CreatePackage(p)
|
|
Expect(err).ToNot(HaveOccurred())
|
|
}
|
|
|
|
solution, err := s.Install([]pkg.Package{Y})
|
|
Expect(err).ToNot(HaveOccurred())
|
|
|
|
solution2, err := s.Install([]pkg.Package{Z})
|
|
Expect(err).ToNot(HaveOccurred())
|
|
orderY, err := solution.Order(dbDefinitions, Y.GetFingerPrint())
|
|
Expect(err).ToNot(HaveOccurred())
|
|
orderZ, err := solution2.Order(dbDefinitions, Z.GetFingerPrint())
|
|
Expect(err).ToNot(HaveOccurred())
|
|
Expect(orderY.Cut(Y).Drop(Y)).To(Equal(orderZ.Cut(Z).Drop(Z)))
|
|
|
|
Expect(orderY.Cut(Y).Drop(Y).AssertionHash()).To(Equal(orderZ.Cut(Z).Drop(Z).AssertionHash()))
|
|
})
|
|
|
|
It("HashFrom can be used equally", func() {
|
|
|
|
X := pkg.NewPackage("X", "", []*pkg.DefaultPackage{}, []*pkg.DefaultPackage{})
|
|
Y := pkg.NewPackage("Y", "", []*pkg.DefaultPackage{X}, []*pkg.DefaultPackage{})
|
|
Z := pkg.NewPackage("Z", "", []*pkg.DefaultPackage{X}, []*pkg.DefaultPackage{})
|
|
|
|
for _, p := range []pkg.Package{X, Y, Z} {
|
|
_, err := dbDefinitions.CreatePackage(p)
|
|
Expect(err).ToNot(HaveOccurred())
|
|
}
|
|
|
|
for _, p := range []pkg.Package{} {
|
|
_, err := dbInstalled.CreatePackage(p)
|
|
Expect(err).ToNot(HaveOccurred())
|
|
}
|
|
|
|
solution, err := s.Install([]pkg.Package{Y})
|
|
Expect(err).ToNot(HaveOccurred())
|
|
|
|
solution2, err := s.Install([]pkg.Package{Z})
|
|
Expect(err).ToNot(HaveOccurred())
|
|
orderY, err := solution.Order(dbDefinitions, Y.GetFingerPrint())
|
|
Expect(err).ToNot(HaveOccurred())
|
|
orderZ, err := solution2.Order(dbDefinitions, Z.GetFingerPrint())
|
|
Expect(err).ToNot(HaveOccurred())
|
|
Expect(orderY.Cut(Y).Drop(Y)).To(Equal(orderZ.Cut(Z).Drop(Z)))
|
|
|
|
Expect(orderY.Cut(Y).HashFrom(Y)).To(Equal(orderZ.Cut(Z).HashFrom(Z)))
|
|
})
|
|
|
|
It("Unique hashes for single packages", func() {
|
|
|
|
X := pkg.NewPackage("X", "", []*pkg.DefaultPackage{}, []*pkg.DefaultPackage{})
|
|
F := pkg.NewPackage("F", "", []*pkg.DefaultPackage{}, []*pkg.DefaultPackage{})
|
|
D := pkg.NewPackage("X", "", []*pkg.DefaultPackage{}, []*pkg.DefaultPackage{})
|
|
|
|
for _, p := range []pkg.Package{X, F, D} {
|
|
_, err := dbDefinitions.CreatePackage(p)
|
|
Expect(err).ToNot(HaveOccurred())
|
|
}
|
|
|
|
for _, p := range []pkg.Package{} {
|
|
_, err := dbInstalled.CreatePackage(p)
|
|
Expect(err).ToNot(HaveOccurred())
|
|
}
|
|
|
|
solution, err := s.Install([]pkg.Package{X})
|
|
Expect(err).ToNot(HaveOccurred())
|
|
|
|
solution2, err := s.Install([]pkg.Package{F})
|
|
Expect(err).ToNot(HaveOccurred())
|
|
|
|
solution3, err := s.Install([]pkg.Package{D})
|
|
Expect(err).ToNot(HaveOccurred())
|
|
|
|
Expect(solution.AssertionHash()).ToNot(Equal(solution2.AssertionHash()))
|
|
Expect(solution3.AssertionHash()).To(Equal(solution.AssertionHash()))
|
|
|
|
})
|
|
|
|
It("Unique hashes for empty assertions", func() {
|
|
empty := solver.PackagesAssertions{}
|
|
empty2 := solver.PackagesAssertions{}
|
|
|
|
Expect(empty.AssertionHash()).To(Equal(empty2.AssertionHash()))
|
|
})
|
|
|
|
It("Unique hashes for single packages with HashFrom", func() {
|
|
|
|
X := pkg.NewPackage("X", "", []*pkg.DefaultPackage{}, []*pkg.DefaultPackage{})
|
|
F := pkg.NewPackage("F", "", []*pkg.DefaultPackage{}, []*pkg.DefaultPackage{})
|
|
D := pkg.NewPackage("X", "", []*pkg.DefaultPackage{}, []*pkg.DefaultPackage{})
|
|
Y := pkg.NewPackage("Y", "", []*pkg.DefaultPackage{X}, []*pkg.DefaultPackage{})
|
|
|
|
empty := solver.PackagesAssertions{}
|
|
|
|
for _, p := range []pkg.Package{X, F, D, Y} {
|
|
_, err := dbDefinitions.CreatePackage(p)
|
|
Expect(err).ToNot(HaveOccurred())
|
|
}
|
|
|
|
for _, p := range []pkg.Package{} {
|
|
_, err := dbInstalled.CreatePackage(p)
|
|
Expect(err).ToNot(HaveOccurred())
|
|
}
|
|
|
|
solution, err := s.Install([]pkg.Package{X})
|
|
Expect(err).ToNot(HaveOccurred())
|
|
|
|
solution2, err := s.Install([]pkg.Package{F})
|
|
Expect(err).ToNot(HaveOccurred())
|
|
|
|
solution3, err := s.Install([]pkg.Package{D})
|
|
Expect(err).ToNot(HaveOccurred())
|
|
|
|
solution4, err := s.Install([]pkg.Package{Y})
|
|
Expect(err).ToNot(HaveOccurred())
|
|
|
|
Expect(solution.HashFrom(X)).ToNot(Equal(solution2.HashFrom(F)))
|
|
Expect(solution3.HashFrom(D)).To(Equal(solution.HashFrom(X)))
|
|
|
|
Expect(empty.AssertionHash()).ToNot(Equal(solution3.HashFrom(D)))
|
|
Expect(empty.AssertionHash()).ToNot(Equal(solution2.HashFrom(F)))
|
|
|
|
Expect(solution4.Drop(Y).AssertionHash()).To(Equal(solution4.HashFrom(Y)))
|
|
})
|
|
})
|
|
})
|