rancher/immucore
1
0
Fork 0
mirror of https://github.com/kairos-io/immucore.git synced 2025-08-01 22:47:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

Drop isrecovery from state struct

Browse Source 
Only needed in one place, can be made into a function

Signed-off-by: Itxaka <itxaka@spectrocloud.com>
This commit is contained in:
Itxaka 2023-02-09 08:54:16 +01:00
parent 8cd3520311
commit cf69cffa4b
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
internal/cmd/commands.go
View File

@ -58,7 +58,6 @@ Sends a generic event payload with the configuration found in the scanned direct
MountRoot: true,
TargetLabel: utils.BootStateToLabel(),
TargetImage: img[0],
IsRecovery: utils.IsRecovery(),
}
err = s.Register(g)

11
pkg/mount/mount.go
View File

@ -34,8 +34,7 @@ type State struct {
StateDir string // e.g. "/usr/local/.state"
MountRoot bool // e.g. if true, it tries to find the image to loopback mount
fstabs []*fstab.Mount
IsRecovery bool // if its recovery it needs different stuff
fstabs []*fstab.Mount
}
const (
@ -179,7 +178,9 @@ func readEnv(file string) (map[string]string, error) {
if err != nil {
return envMap, err
}
defer f.Close()
defer func(f *os.File) {
_ = f.Close()
}(f)
envMap, err = godotenv.Parse(f)
if err != nil {
@ -234,7 +235,7 @@ func (s *State) Register(g *herd.Graph) error {
stateName := runtime.State.Name
stateFs := runtime.State.Type
// Recovery is a different partition
if s.IsRecovery {
if internalUtils.IsRecovery() {
stateName = runtime.Recovery.Name
stateFs = runtime.Recovery.Type
}
@ -282,7 +283,7 @@ func (s *State) Register(g *herd.Graph) error {
// This is building the mountRoot dependendency if it was enabled
mountRootCondition := herd.ConditionalOption(func() bool { return s.MountRoot }, herd.WithDeps(opMountRoot))
// TODO: this needs to be run after sysroot so we can link to /sysroot/system/oem and after /oem mounted
// this needs to be run after sysroot, so we can link to /sysroot/system/oem and after /oem mounted
err = g.Add(opRootfsHook, mountRootCondition, herd.WithDeps(opMountRoot, opMountOEM), herd.WithCallback(s.RunStageOp("rootfs")))
if err != nil {
s.Logger.Err(err).Msg("running rootfs stage")